[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-422-gc8bd1c0

Shawn Moore sartak at bestpractical.com
Tue Aug 17 13:29:11 EDT 2010


The branch, 3.9-trunk has been updated
       via  c8bd1c04ead563bbba312effe75ab30d850dbc00 (commit)
      from  893756bfad69a1b458769c329a549213b99da420 (commit)

Summary of changes:
 lib/RT/Scrip_Overlay.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit c8bd1c04ead563bbba312effe75ab30d850dbc00
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Tue Aug 17 13:30:29 2010 -0400

    Avoid undef warnings by just checking truthiness of these fields
    
        0 is pretty safe

diff --git a/lib/RT/Scrip_Overlay.pm b/lib/RT/Scrip_Overlay.pm
index 5bf3322..b9f4422 100755
--- a/lib/RT/Scrip_Overlay.pm
+++ b/lib/RT/Scrip_Overlay.pm
@@ -106,7 +106,7 @@ sub Create {
         @_
     );
 
-    if (length($args{CustomPrepareCode}) || length($args{CustomCommitCode}) || length($args{CustomIsApplicableCode})) {
+    if ($args{CustomPrepareCode} || $args{CustomCommitCode} || $args{CustomIsApplicableCode}) {
         unless ( $self->CurrentUser->HasRight( Object => $RT::System,
                                                Right  => 'ExecuteCode' ) )
         {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list