[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-511-g50a375e

Shawn Moore sartak at bestpractical.com
Mon Aug 23 20:12:30 EDT 2010


The branch, 3.9-trunk has been updated
       via  50a375e1b5c012275fdd6a11425949c7faa4f3a6 (commit)
      from  236983a3f18289ffac58addffde64792732fcc33 (commit)

Summary of changes:
 t/api/rights_show_ticket.t          |    2 +-
 t/lifecycles/basics.t               |   19 +++++++++----------
 t/lifecycles/dates.t                |   16 ++++++++--------
 t/lifecycles/moving.t               |    8 ++++----
 t/web/gnupg-select-keys-on-create.t |    6 +++---
 5 files changed, 25 insertions(+), 26 deletions(-)

- Log -----------------------------------------------------------------
commit 50a375e1b5c012275fdd6a11425949c7faa4f3a6
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Mon Aug 23 20:14:50 2010 -0400

    Block a bunch of diags behind a TEST_VERBOSE check

diff --git a/t/api/rights_show_ticket.t b/t/api/rights_show_ticket.t
index 3e1d074..c805c9f 100644
--- a/t/api/rights_show_ticket.t
+++ b/t/api/rights_show_ticket.t
@@ -26,7 +26,7 @@ ok $user_b && $user_b->id, 'loaded or created user';
 
 foreach my $option (0 .. 1 ) { RT->Config->Set( 'UseSQLForACLChecks' => $option );
 
-diag "Testing with UseSQLForACLChecks => $option";
+diag "Testing with UseSQLForACLChecks => $option" if $ENV{TEST_VERBOSE};
 
 # Global Cc has right, a User is nobody
 {
diff --git a/t/lifecycles/basics.t b/t/lifecycles/basics.t
index fa958aa..70d4680 100644
--- a/t/lifecycles/basics.t
+++ b/t/lifecycles/basics.t
@@ -18,7 +18,7 @@ my $tstatus = sub {
     return $ticket->Status;
 };
 
-diag "check basic API";
+diag "check basic API" if $ENV{TEST_VERBOSE};
 {
     my $schema = $general->lifecycle;
     isa_ok($schema, 'RT::Lifecycle');
@@ -31,11 +31,10 @@ diag "check basic API";
 my ($baseurl, $m) = RT::Test->started_ok;
 ok $m->login, 'logged in';
 
-diag "check status input on create";
+diag "check status input on create" if $ENV{TEST_VERBOSE};
 {
     $m->goto_create_ticket( $general );
 
-    diag $m->uri;
     my $form = $m->form_name('TicketCreate');
     ok my $input = $form->find_input('Status'), 'found status selector';
 
@@ -53,7 +52,7 @@ diag "check status input on create";
     ok $valid, 'all statuses in the form are valid';
 }
 
-diag "create a ticket";
+diag "create a ticket" if $ENV{TEST_VERBOSE};
 my $tid;
 {
     my $ticket = RT::Ticket->new( $RT::SystemUser );
@@ -62,7 +61,7 @@ my $tid;
     is $ticket->Status, 'new', 'correct status';
 }
 
-diag "new ->(open it)-> open";
+diag "new ->(open it)-> open" if $ENV{TEST_VERBOSE};
 {
     ok $m->goto_ticket( $tid ), 'opened a ticket';
 
@@ -89,7 +88,7 @@ diag "new ->(open it)-> open";
     is $tstatus->($tid), 'open', 'changed status';
 }
 
-diag "open ->(stall)-> stalled";
+diag "open ->(stall)-> stalled" if $ENV{TEST_VERBOSE};
 {
     is $tstatus->($tid), 'open', 'ticket is open';
 
@@ -118,7 +117,7 @@ diag "open ->(stall)-> stalled";
     is $tstatus->($tid), 'stalled', 'changed status';
 }
 
-diag "stall ->(open it)-> open";
+diag "stall ->(open it)-> open" if $ENV{TEST_VERBOSE};
 {
     is $tstatus->($tid), 'stalled', 'ticket is stalled';
 
@@ -145,7 +144,7 @@ diag "stall ->(open it)-> open";
     is $tstatus->($tid), 'open', 'changed status';
 }
 
-diag "open -> deleted, only via modify";
+diag "open -> deleted, only via modify" if $ENV{TEST_VERBOSE};
 {
     is $tstatus->($tid), 'open', 'ticket is open';
 
@@ -164,7 +163,7 @@ diag "open -> deleted, only via modify";
     is $tstatus->($tid), 'deleted', 'deleted ticket';
 }
 
-diag "deleted -> X via modify, only open is available";
+diag "deleted -> X via modify, only open is available" if $ENV{TEST_VERBOSE};
 {
     is $tstatus->($tid), 'deleted', 'ticket is deleted';
 
@@ -178,7 +177,7 @@ diag "deleted -> X via modify, only open is available";
     is join('-', @form_values), '-open', 'only open and default available';
 }
 
-diag "check illegal values and transitions";
+diag "check illegal values and transitions" if $ENV{TEST_VERBOSE};
 {
     {
         my $ticket = RT::Ticket->new( $RT::SystemUser );
diff --git a/t/lifecycles/dates.t b/t/lifecycles/dates.t
index 300aafe..e9dea04 100644
--- a/t/lifecycles/dates.t
+++ b/t/lifecycles/dates.t
@@ -26,7 +26,7 @@ my $tstatus = sub {
 my ($baseurl, $m) = RT::Test->started_ok;
 ok $m->login, 'logged in';
 
-diag "check basic API";
+diag "check basic API" if $ENV{TEST_VERBOSE};
 {
     my $schema = $general->lifecycle;
     isa_ok($schema, 'RT::Lifecycle');
@@ -37,7 +37,7 @@ diag "check basic API";
     is $schema->name, 'delivery', "it's a delivery schema";
 }
 
-diag "dates on create for default schema";
+diag "dates on create for default schema" if $ENV{TEST_VERBOSE};
 {
     {
         my $ticket = RT::Ticket->new( $RT::SystemUser );
@@ -115,7 +115,7 @@ diag "dates on create for default schema";
     }
 }
 
-diag "dates on create for delivery schema";
+diag "dates on create for delivery schema" if $ENV{TEST_VERBOSE};
 {
     {
         my $ticket = RT::Ticket->new( $RT::SystemUser );
@@ -136,7 +136,7 @@ diag "dates on create for delivery schema";
             Subject => 'test',
         );
         ok $id, 'created a ticket';
-        diag($msg);
+        diag($msg) if $ENV{TEST_VERBOSE};
         is $ticket->Status, 'ordered', "Status is ordered";
         my ($statusval,$statusmsg) = $ticket->SetStatus('on way');
         ok($statusval,$statusmsg);
@@ -209,7 +209,7 @@ diag "dates on create for delivery schema";
     }
 }
 
-diag "dates on status change for default schema";
+diag "dates on status change for default schema" if $ENV{TEST_VERBOSE};
 {
     my $ticket = RT::Ticket->new( $RT::SystemUser );
     my ($id, $msg) = $ticket->Create(
@@ -244,7 +244,7 @@ diag "dates on status change for default schema";
     ok $ticket->ResolvedObj->Unix > 0, 'resolved is set';
 }
 
-diag "dates on status change for delivery schema";
+diag "dates on status change for delivery schema" if $ENV{TEST_VERBOSE};
 {
     my $ticket = RT::Ticket->new( $RT::SystemUser );
     my ($id, $msg) = $ticket->Create(
@@ -274,7 +274,7 @@ diag "dates on status change for delivery schema";
     ok $ticket->ResolvedObj->Unix > 0, 'resolved is set';
 }
 
-diag "add partial map between general->delivery";
+diag "add partial map between general->delivery" if $ENV{TEST_VERBOSE};
 {
     my $schemas = RT->Config->Get('Lifecycles');
     $schemas->{'__maps__'} = {
@@ -288,7 +288,7 @@ diag "add partial map between general->delivery";
     RT::Lifecycle->fill_cache;
 }
 
-diag "check date changes on moving a ticket";
+diag "check date changes on moving a ticket" if $ENV{TEST_VERBOSE};
 {
     my $ticket = RT::Ticket->new( $RT::SystemUser );
     my ($id, $msg) = $ticket->Create(
diff --git a/t/lifecycles/moving.t b/t/lifecycles/moving.t
index 59ce82e..52ccb5a 100644
--- a/t/lifecycles/moving.t
+++ b/t/lifecycles/moving.t
@@ -23,7 +23,7 @@ my $tstatus = sub {
     return $ticket->Status;
 };
 
-diag "check moving without a map";
+diag "check moving without a map" if $ENV{TEST_VERBOSE};
 {
     my $ticket = RT::Ticket->new( $RT::SystemUser );
     my ($id, $msg) = $ticket->Create(
@@ -38,7 +38,7 @@ diag "check moving without a map";
     is $ticket->Status, 'new', 'status is steal the same';
 }
 
-diag "add partial map";
+diag "add partial map" if $ENV{TEST_VERBOSE};
 {
     my $schemas = RT->Config->Get('Lifecycles');
     $schemas->{'__maps__'} = {
@@ -49,7 +49,7 @@ diag "add partial map";
     RT::Lifecycle->fill_cache;
 }
 
-diag "check moving with a partial map";
+diag "check moving with a partial map" if $ENV{TEST_VERBOSE};
 {
     {
         my $ticket = RT::Ticket->new( $RT::SystemUser );
@@ -80,7 +80,7 @@ diag "check moving with a partial map";
     }
 }
 
-diag "one way map doesn't work backwards";
+diag "one way map doesn't work backwards" if $ENV{TEST_VERBOSE};
 {
     my $ticket = RT::Ticket->new( $RT::SystemUser );
     my ($id, $msg) = $ticket->Create(
diff --git a/t/web/gnupg-select-keys-on-create.t b/t/web/gnupg-select-keys-on-create.t
index deee6b2..6bf8591 100644
--- a/t/web/gnupg-select-keys-on-create.t
+++ b/t/web/gnupg-select-keys-on-create.t
@@ -199,7 +199,7 @@ diag "check that things still doesn't work if two keys are not trusted" if $ENV{
     is $res{'info'}[1]{'TrustLevel'}, 0, 'is not trusted key';
 }
 
-diag "check that we see key selector even if only one key is trusted but there are more keys";
+diag "check that we see key selector even if only one key is trusted but there are more keys" if $ENV{TEST_VERBOSE};
 {
     RT::Test->clean_caught_mails;
 
@@ -226,7 +226,7 @@ diag "check that we see key selector even if only one key is trusted but there a
     ok !@mail, 'there are no outgoing emails';
 }
 
-diag "check that key selector works and we can select trusted key";
+diag "check that key selector works and we can select trusted key" if $ENV{TEST_VERBOSE};
 {
     RT::Test->clean_caught_mails;
 
@@ -258,7 +258,7 @@ diag "check that key selector works and we can select trusted key";
     check_text_emails( { Encrypt => 1 }, @mail );
 }
 
-diag "check encrypting of attachments";
+diag "check encrypting of attachments" if $ENV{TEST_VERBOSE};
 {
     RT::Test->clean_caught_mails;
 

-----------------------------------------------------------------------


More information about the Rt-commit mailing list