[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-587-g420aee4

Chia-liang Kao clkao at bestpractical.com
Wed Aug 25 23:57:49 EDT 2010


The branch, 3.9-trunk has been updated
       via  420aee4a3825b9d4285e9d43b119fe445af26fcd (commit)
       via  9f428c716a94d52fa103bc75d049ccaf0c75c144 (commit)
      from  4ac52c86b83ef961d0151d7ae71eed5df9b0c004 (commit)

Summary of changes:
 lib/RT/Test.pm                            |   79 ++++++++++-------------------
 t/00-compile.t                            |    2 +-
 t/00-mason-syntax.t                       |    2 +-
 t/api/ace.t                               |    2 +-
 t/api/attachment.t                        |    2 +-
 t/api/attribute-tests.t                   |    2 +-
 t/api/attribute.t                         |    2 +-
 t/api/cf.t                                |    2 +-
 t/api/cf_combo_cascade.t                  |    2 +-
 t/api/cf_date_search.t                    |    2 +-
 t/api/cf_datetime_search.t                |    2 +-
 t/api/cf_pattern.t                        |    2 +-
 t/api/cf_single_values.t                  |    2 +-
 t/api/cf_transaction.t                    |    2 +-
 t/api/config.t                            |    2 +-
 t/api/currentuser.t                       |    2 +-
 t/api/customfield.t                       |    2 +-
 t/api/emailparser.t                       |    2 +-
 t/api/group.t                             |    2 +-
 t/api/groups.t                            |    2 +-
 t/api/i18n.t                              |    2 +-
 t/api/link.t                              |    2 +-
 t/api/queue.t                             |    2 +-
 t/api/rights.t                            |    2 +-
 t/api/rights_show_ticket.t                |    2 +-
 t/api/rt.t                                |    2 +-
 t/api/system.t                            |    2 +-
 t/clicky.t                                |    2 +-
 t/cron.t                                  |    2 +-
 t/customfields/access_via_queue.t         |    2 +-
 t/delegation/cleanup_stalled.t            |    2 +-
 t/delegation/revocation.t                 |    2 +-
 t/i18n/default.t                          |    2 +-
 t/mail/mime_decoding.t                    |    2 +-
 t/mail/verp.t                             |    2 +-
 t/mail/wrong_mime_charset.t               |    2 +-
 t/shredder/00load.t                       |    2 +-
 t/shredder/00skeleton.t                   |    2 +-
 t/shredder/01basics.t                     |    2 +-
 t/shredder/01ticket.t                     |    2 +-
 t/shredder/02group_member.t               |    2 +-
 t/shredder/02queue.t                      |    2 +-
 t/shredder/02template.t                   |    2 +-
 t/shredder/02user.t                       |    2 +-
 t/shredder/03plugin.t                     |    2 +-
 t/shredder/03plugin_summary.t             |    2 +-
 t/shredder/03plugin_tickets.t             |    2 +-
 t/shredder/03plugin_users.t               |    2 +-
 t/ticket/add-watchers.t                   |    2 +-
 t/ticket/cfsort-freeform-multiple.t       |    2 +-
 t/ticket/cfsort-freeform-single.t         |    2 +-
 t/ticket/deferred_owner.t                 |    2 +-
 t/ticket/search.t                         |    2 +-
 t/ticket/search_by_cf_freeform_multiple.t |    2 +-
 t/ticket/search_by_cf_freeform_single.t   |    2 +-
 t/ticket/search_by_links.t                |    2 +-
 t/ticket/search_by_watcher.t              |    2 +-
 t/ticket/search_long_cf_values.t          |    2 +-
 t/ticket/sort-by-custom-ownership.t       |    2 +-
 t/ticket/sort-by-queue.t                  |    2 +-
 t/ticket/sort-by-user.t                   |    2 +-
 t/ticket/sort_by_cf.t                     |    2 +-
 t/web/config_tab_right.t                  |    2 +-
 t/web/dashboards-groups.t                 |    2 +-
 t/web/dashboards-permissions.t            |    2 +-
 t/web/rights1.t                           |    2 +-
 t/web/ticket_owner.t                      |    2 +-
 t/web/ticket_owner_autocomplete.t         |    2 +-
 t/web/ticket_seen.t                       |    2 +-
 69 files changed, 95 insertions(+), 120 deletions(-)

- Log -----------------------------------------------------------------
commit 9f428c716a94d52fa103bc75d049ccaf0c75c144
Author: Chia-liang Kao <clkao at bestpractical.com>
Date:   Thu Aug 26 11:28:52 2010 +0800

    Don't drop db on nodb

diff --git a/lib/RT/Test.pm b/lib/RT/Test.pm
index ba3186e..2fe2eeb 100644
--- a/lib/RT/Test.pm
+++ b/lib/RT/Test.pm
@@ -352,11 +352,6 @@ sub bootstrap_db {
     my $dbh = _get_dbh(RT::Handle->SystemDSN,
                $ENV{RT_DBA_USER}, $ENV{RT_DBA_PASSWORD});
 
-    unless ( $ENV{RT_TEST_PARALLEL} ) {
-        # already dropped db in parallel tests, need to do so for other cases.
-        RT::Handle->DropDatabase( $dbh, Force => 1 );
-    }
-
     if (my $forceopt = $ENV{RT_TEST_FORCE_OPT}) {
         Test::More::diag "forcing $forceopt";
         $args{$forceopt}=1;
@@ -371,6 +366,10 @@ sub bootstrap_db {
     }
 
     unless ($args{nodb}) {
+        unless ( $ENV{RT_TEST_PARALLEL} ) {
+            # already dropped db in parallel tests, need to do so for other cases.
+            RT::Handle->DropDatabase( $dbh, Force => 1 )
+        }
         RT::Handle->CreateDatabase( $dbh );
         $dbh->disconnect;
         $created_new_db++;

commit 420aee4a3825b9d4285e9d43b119fe445af26fcd
Author: Chia-liang Kao <clkao at bestpractical.com>
Date:   Thu Aug 26 11:50:15 2010 +0800

    revert nodb test flag related changes

diff --git a/lib/RT/Test.pm b/lib/RT/Test.pm
index 2fe2eeb..546dd48 100644
--- a/lib/RT/Test.pm
+++ b/lib/RT/Test.pm
@@ -152,19 +152,10 @@ sub import {
 
     $class->bootstrap_db( %args );
 
-    RT::InitPluginPaths();
-
-    RT::ConnectToDatabase()
-        unless $args{nodb};
-
-    RT::InitClasses();
-    RT::InitLogging();
+    RT->Init;
 
     $class->bootstrap_plugins( %args );
 
-    RT::InitPlugins();
-    RT->Config->PostLoadCheck;
-
     $class->set_config_wrapper;
 
     my $screen_logger = $RT::Logger->remove( 'screen' );
@@ -352,60 +343,44 @@ sub bootstrap_db {
     my $dbh = _get_dbh(RT::Handle->SystemDSN,
                $ENV{RT_DBA_USER}, $ENV{RT_DBA_PASSWORD});
 
-    if (my $forceopt = $ENV{RT_TEST_FORCE_OPT}) {
-        Test::More::diag "forcing $forceopt";
-        $args{$forceopt}=1;
-    }
-
-    if ($args{nodb}) {
-        $args{noinitialdata} = 1;
-        $args{nodata} = 1;
-    }
-    elsif ($args{noinitialdata}) {
-        $args{nodata} = 1;
+    unless ( $ENV{RT_TEST_PARALLEL} ) {
+        # already dropped db in parallel tests, need to do so for other cases.
+        RT::Handle->DropDatabase( $dbh, Force => 1 );
     }
 
-    unless ($args{nodb}) {
-        unless ( $ENV{RT_TEST_PARALLEL} ) {
-            # already dropped db in parallel tests, need to do so for other cases.
-            RT::Handle->DropDatabase( $dbh, Force => 1 )
-        }
-        RT::Handle->CreateDatabase( $dbh );
-        $dbh->disconnect;
-        $created_new_db++;
+    RT::Handle->CreateDatabase( $dbh );
+    $dbh->disconnect;
+    $created_new_db++;
 
-        $dbh = _get_dbh(RT::Handle->DSN,
-                        $ENV{RT_DBA_USER}, $ENV{RT_DBA_PASSWORD});
+    $dbh = _get_dbh(RT::Handle->DSN,
+            $ENV{RT_DBA_USER}, $ENV{RT_DBA_PASSWORD});
 
-        $RT::Handle = RT::Handle->new;
-        $RT::Handle->dbh( $dbh );
-        $RT::Handle->InsertSchema( $dbh );
-
-        my $db_type = RT->Config->Get('DatabaseType');
-        $RT::Handle->InsertACL( $dbh ) unless $db_type eq 'Oracle';
+    $RT::Handle = RT::Handle->new;
+    $RT::Handle->dbh( $dbh );
+    $RT::Handle->InsertSchema( $dbh );
 
-        $RT::Handle = RT::Handle->new;
-        $RT::Handle->dbh( undef );
-        RT->ConnectToDatabase;
-        RT->InitLogging;
+    my $db_type = RT->Config->Get('DatabaseType');
+    $RT::Handle->InsertACL( $dbh ) unless $db_type eq 'Oracle';
 
-        unless ($args{noinitialdata}) {
-            $RT::Handle->InsertInitialData;
+    $RT::Handle = RT::Handle->new;
+    $RT::Handle->dbh( undef );
+    RT->ConnectToDatabase;
+    RT->InitLogging;
+    RT->InitSystemObjects;
+    $RT::Handle->InsertInitialData;
 
-            DBIx::SearchBuilder::Record::Cachable->FlushCache;
-        }
+    DBIx::SearchBuilder::Record::Cachable->FlushCache;
+    $RT::Handle = RT::Handle->new;
+    $RT::Handle->dbh( undef );
+    RT->Init;
 
-        $RT::Handle = RT::Handle->new;
-        $RT::Handle->dbh( undef );
-        RT->ConnectToDatabase();
-        $RT::Handle->PrintError;
-        $RT::Handle->dbh->{PrintError} = 1;
+    $RT::Handle->PrintError;
+    $RT::Handle->dbh->{PrintError} = 1;
 
-        unless ( $args{'nodata'} ) {
-            $RT::Handle->InsertData( $RT::EtcPath . "/initialdata" );
-            DBIx::SearchBuilder::Record::Cachable->FlushCache;
-        }
+    unless ( $args{'nodata'} ) {
+        $RT::Handle->InsertData( $RT::EtcPath . "/initialdata" );
     }
+    DBIx::SearchBuilder::Record::Cachable->FlushCache;
 }
 
 sub bootstrap_plugins {
@@ -441,6 +416,7 @@ sub bootstrap_plugins {
     };
 
     RT->Config->Set( Plugins => @plugins );
+    RT->InitPluginPaths;
 
     my $dba_dbh;
     $dba_dbh = _get_dbh(
diff --git a/t/00-compile.t b/t/00-compile.t
index 3c5b92c..1a89e77 100644
--- a/t/00-compile.t
+++ b/t/00-compile.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodb => 1, tests => 31;
+use RT::Test nodata => 1, tests => 31;
 
 require_ok("RT");
 require_ok("RT::Test");
diff --git a/t/00-mason-syntax.t b/t/00-mason-syntax.t
index 9e29acd..a451805 100644
--- a/t/00-mason-syntax.t
+++ b/t/00-mason-syntax.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodb => 1, tests => 1;
+use RT::Test tests => 1;
 
 my $ok = 1;
 
diff --git a/t/api/ace.t b/t/api/ace.t
index 8898d76..4031046 100644
--- a/t/api/ace.t
+++ b/t/api/ace.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodata => 1, tests => 76;
+use RT::Test tests => 76;
 
 
 {
diff --git a/t/api/attachment.t b/t/api/attachment.t
index c6ab366..07c46ba 100644
--- a/t/api/attachment.t
+++ b/t/api/attachment.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodb => 1, tests => 4;
+use RT::Test tests => 4;
 
 
 {
diff --git a/t/api/attribute-tests.t b/t/api/attribute-tests.t
index 71250a8..90c3ddb 100644
--- a/t/api/attribute-tests.t
+++ b/t/api/attribute-tests.t
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodata => 1, tests => 34;
+use RT::Test tests => 34;
 
 
 
diff --git a/t/api/attribute.t b/t/api/attribute.t
index 0f0d456..cb2626a 100644
--- a/t/api/attribute.t
+++ b/t/api/attribute.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodata => 1, tests => 7;
+use RT::Test tests => 7;
 
 
 {
diff --git a/t/api/cf.t b/t/api/cf.t
index b82643e..98114c9 100644
--- a/t/api/cf.t
+++ b/t/api/cf.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings FATAL => 'all';
 
-use RT::Test nodata => 1, tests => 139;
+use RT::Test tests => 139;
 
 # Before we get going, ditch all object_cfs; this will remove 
 # all custom fields systemwide;
diff --git a/t/api/cf_combo_cascade.t b/t/api/cf_combo_cascade.t
index ce5e074..b37345a 100644
--- a/t/api/cf_combo_cascade.t
+++ b/t/api/cf_combo_cascade.t
@@ -2,7 +2,7 @@
 use warnings;
 use strict;
 
-use RT::Test nodata => 1, tests => 11;
+use RT::Test tests => 11;
 
 sub fails { ok(!$_[0], "This should fail: $_[1]") }
 sub works { ok($_[0], $_[1] || 'This works') }
diff --git a/t/api/cf_date_search.t b/t/api/cf_date_search.t
index aea2925..15abd70 100644
--- a/t/api/cf_date_search.t
+++ b/t/api/cf_date_search.t
@@ -3,7 +3,7 @@
 use warnings;
 use strict;
 
-use RT::Test nodata => 1, tests => 13;
+use RT::Test tests => 13;
 
 my $q = RT::Queue->new($RT::SystemUser);
 ok( $q->Create( Name => 'DateCFTest' . $$ ), 'create queue' );
diff --git a/t/api/cf_datetime_search.t b/t/api/cf_datetime_search.t
index 44582e1..d0884f4 100644
--- a/t/api/cf_datetime_search.t
+++ b/t/api/cf_datetime_search.t
@@ -3,7 +3,7 @@
 use warnings;
 use strict;
 
-use RT::Test nodata => 1, tests => 14;
+use RT::Test tests => 14;
 RT->Config->Set( 'Timezone' => 'EST5EDT' ); # -04:00
 
 my $q = RT::Queue->new($RT::SystemUser);
diff --git a/t/api/cf_pattern.t b/t/api/cf_pattern.t
index cf791bc..ffc5b3f 100644
--- a/t/api/cf_pattern.t
+++ b/t/api/cf_pattern.t
@@ -3,7 +3,7 @@ use warnings;
 use strict;
 
 use RT;
-use RT::Test nodata => 1, tests => 17;
+use RT::Test tests => 17;
 
 
 sub fails { ok(!$_[0], "This should fail: $_[1]") }
diff --git a/t/api/cf_single_values.t b/t/api/cf_single_values.t
index 4beb293..8e96edd 100644
--- a/t/api/cf_single_values.t
+++ b/t/api/cf_single_values.t
@@ -3,7 +3,7 @@ use warnings;
 use strict;
 
 use RT;
-use RT::Test nodata => 1, tests => 8;
+use RT::Test tests => 8;
 
 
 
diff --git a/t/api/cf_transaction.t b/t/api/cf_transaction.t
index 589151f..1ed2ab9 100644
--- a/t/api/cf_transaction.t
+++ b/t/api/cf_transaction.t
@@ -4,7 +4,7 @@ use warnings;
 use strict;
 use Data::Dumper;
 
-use RT::Test nodata => 1, tests => 14;
+use RT::Test tests => 14;
 use_ok('RT');
 use_ok('RT::Transactions');
 
diff --git a/t/api/config.t b/t/api/config.t
index a986c3c..8e24be0 100644
--- a/t/api/config.t
+++ b/t/api/config.t
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodb => 1, tests => 9;
+use RT::Test tests => 9;
 
 ok(
     RT::Config->AddOption(
diff --git a/t/api/currentuser.t b/t/api/currentuser.t
index c568b0e..c158048 100644
--- a/t/api/currentuser.t
+++ b/t/api/currentuser.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test noinitialdata => 1, tests => 8;
+use RT::Test tests => 8;
 
 
 {
diff --git a/t/api/customfield.t b/t/api/customfield.t
index 2347d61..44319c4 100644
--- a/t/api/customfield.t
+++ b/t/api/customfield.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodata => 1, tests => 29;
+use RT::Test tests => 29;
 use Test::Warn;
 
 
diff --git a/t/api/emailparser.t b/t/api/emailparser.t
index 18826fe..940c26f 100644
--- a/t/api/emailparser.t
+++ b/t/api/emailparser.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodb => 1, tests => 4;
+use RT::Test tests => 4;
 
 RT->Config->Set( RTAddressRegexp => qr/^rt\@example.com$/i );
 
diff --git a/t/api/group.t b/t/api/group.t
index 19dfd34..551d4f1 100644
--- a/t/api/group.t
+++ b/t/api/group.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodata => 1, tests => 38;
+use RT::Test tests => 38;
 
 
 {
diff --git a/t/api/groups.t b/t/api/groups.t
index f83468c..9a482f5 100644
--- a/t/api/groups.t
+++ b/t/api/groups.t
@@ -1,6 +1,6 @@
 use strict;
 use warnings;
-use RT::Test nodata => 1, tests => 27;
+use RT::Test tests => 27;
 
 RT::Group->AddRights(
     'RTxGroupRight' => 'Just a right for testing rights',
diff --git a/t/api/i18n.t b/t/api/i18n.t
index 6c0da4b..17d71b7 100644
--- a/t/api/i18n.t
+++ b/t/api/i18n.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodb => 1, tests => 9;
+use RT::Test tests => 9;
 
 
 {
diff --git a/t/api/link.t b/t/api/link.t
index f8b86ba..0903525 100644
--- a/t/api/link.t
+++ b/t/api/link.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 83;
+use RT::Test tests => 83;
 use RT::Test::Web;
 
 use RT::Link;
diff --git a/t/api/queue.t b/t/api/queue.t
index 7346ed4..44d5caf 100644
--- a/t/api/queue.t
+++ b/t/api/queue.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodata => 1, tests => 24;
+use RT::Test tests => 24;
 
 
 {
diff --git a/t/api/rights.t b/t/api/rights.t
index b9f742a..a38bcea 100644
--- a/t/api/rights.t
+++ b/t/api/rights.t
@@ -47,7 +47,7 @@
 # 
 # END BPS TAGGED BLOCK }}}
 
-use RT::Test nodata => 1, tests => 30;
+use RT::Test tests => 30;
 
 use strict;
 use warnings;
diff --git a/t/api/rights_show_ticket.t b/t/api/rights_show_ticket.t
index 4d4474e..3e1d074 100644
--- a/t/api/rights_show_ticket.t
+++ b/t/api/rights_show_ticket.t
@@ -1,6 +1,6 @@
 #!/usr/bin/perl -w
 
-use RT::Test nodata => 1, tests => 264;
+use RT::Test tests => 264;
 
 use strict;
 use warnings;
diff --git a/t/api/rt.t b/t/api/rt.t
index 4081a4f..3c06b58 100644
--- a/t/api/rt.t
+++ b/t/api/rt.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodata => 1, tests => 4;
+use RT::Test tests => 4;
 
 
 {
diff --git a/t/api/system.t b/t/api/system.t
index 1979032..3077115 100644
--- a/t/api/system.t
+++ b/t/api/system.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodata => 1, tests => 7;
+use RT::Test tests => 7;
 
 
 {
diff --git a/t/clicky.t b/t/clicky.t
index 0f16db6..9baa2af 100644
--- a/t/clicky.t
+++ b/t/clicky.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 use Test::More;
-use RT::Test nodb => 1, tests => 14;
+use RT::Test tests => 14;
 my %clicky;
 
 BEGIN {
diff --git a/t/cron.t b/t/cron.t
index e28896f..29d7bd7 100644
--- a/t/cron.t
+++ b/t/cron.t
@@ -3,7 +3,7 @@
 use strict;
 
 use RT;
-use RT::Test nodata => 1, tests => 18;
+use RT::Test tests => 18;
 
 
 ### Set up some testing data.  Test the testing data because why not?
diff --git a/t/customfields/access_via_queue.t b/t/customfields/access_via_queue.t
index 2c442bf..f372f31 100644
--- a/t/customfields/access_via_queue.t
+++ b/t/customfields/access_via_queue.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 35;
+use RT::Test tests => 35;
 use RT::Ticket;
 use RT::CustomField;
 
diff --git a/t/delegation/cleanup_stalled.t b/t/delegation/cleanup_stalled.t
index 750576d..f108ecc 100644
--- a/t/delegation/cleanup_stalled.t
+++ b/t/delegation/cleanup_stalled.t
@@ -15,7 +15,7 @@ use warnings;
 
 use RT;
 
-use RT::Test nodata => 1, tests => 98;
+use RT::Test tests => 98;
 
 my ($u1, $u2, $g1, $g2, $g3, $pg1, $pg2, $ace, @groups, @users, @principals);
 @groups = (\$g1, \$g2, \$g3, \$pg1, \$pg2);
diff --git a/t/delegation/revocation.t b/t/delegation/revocation.t
index 2cde33c..151525e 100644
--- a/t/delegation/revocation.t
+++ b/t/delegation/revocation.t
@@ -5,7 +5,7 @@ use warnings;
 
 use RT;
 
-use RT::Test nodata => 1, tests => 22;
+use RT::Test tests => 22;
 
 my ($u1, $g1, $pg1, $pg2, $ace, @groups, @users, @principals);
 @groups = (\$g1, \$pg1, \$pg2);
diff --git a/t/i18n/default.t b/t/i18n/default.t
index c66cc6d..6c9842a 100644
--- a/t/i18n/default.t
+++ b/t/i18n/default.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodb => 0, tests => 8;
+use RT::Test tests => 8;
 
 my ($baseurl, $m) = RT::Test->started_ok;
 $m->get_ok('/');
diff --git a/t/mail/mime_decoding.t b/t/mail/mime_decoding.t
index e5449ef..b0093c5 100644
--- a/t/mail/mime_decoding.t
+++ b/t/mail/mime_decoding.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl
 use strict;
 use warnings;
-use RT::Test nodb => 1, tests => 7;
+use RT::Test nodata => 1, tests => 7;
 
 use_ok('RT::I18N');
 
diff --git a/t/mail/verp.t b/t/mail/verp.t
index ed3af6a..79ede90 100644
--- a/t/mail/verp.t
+++ b/t/mail/verp.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 
 use strict;
-use RT::Test nodb => 1, tests => 1;
+use RT::Test tests => 1;
 TODO: { 
     todo_skip "No tests written for VERP yet", 1;
     ok(1,"a test to skip");
diff --git a/t/mail/wrong_mime_charset.t b/t/mail/wrong_mime_charset.t
index b0079f8..f53c872 100644
--- a/t/mail/wrong_mime_charset.t
+++ b/t/mail/wrong_mime_charset.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl
 use strict;
 use warnings;
-use RT::Test nodb => 1, tests => 3;
+use RT::Test nodata => 1, tests => 3;
 
 use_ok('RT::I18N');
 use utf8;
diff --git a/t/shredder/00load.t b/t/shredder/00load.t
index 21d5ef7..1e06261 100644
--- a/t/shredder/00load.t
+++ b/t/shredder/00load.t
@@ -2,7 +2,7 @@ use strict;
 use warnings;
 use File::Spec;
 use Test::More tests => 11;
-use RT::Test nodb => 1;
+use RT::Test ();
 
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
diff --git a/t/shredder/00skeleton.t b/t/shredder/00skeleton.t
index 3592429..eab9433 100644
--- a/t/shredder/00skeleton.t
+++ b/t/shredder/00skeleton.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 1;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/shredder/01basics.t b/t/shredder/01basics.t
index 069b96f..450f2df 100644
--- a/t/shredder/01basics.t
+++ b/t/shredder/01basics.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 3;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/shredder/01ticket.t b/t/shredder/01ticket.t
index 8052e7c..5625b98 100644
--- a/t/shredder/01ticket.t
+++ b/t/shredder/01ticket.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 15;
-use RT::Test nodb => 1;
+use RT::Test ();
 
 
 BEGIN {
diff --git a/t/shredder/02group_member.t b/t/shredder/02group_member.t
index d6815f4..c391f74 100644
--- a/t/shredder/02group_member.t
+++ b/t/shredder/02group_member.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 22;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/shredder/02queue.t b/t/shredder/02queue.t
index ab7d541..8e3abf3 100644
--- a/t/shredder/02queue.t
+++ b/t/shredder/02queue.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 16;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/shredder/02template.t b/t/shredder/02template.t
index 769a858..14bda86 100644
--- a/t/shredder/02template.t
+++ b/t/shredder/02template.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 7;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/shredder/02user.t b/t/shredder/02user.t
index 4745e2d..03abd6c 100644
--- a/t/shredder/02user.t
+++ b/t/shredder/02user.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 8;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/shredder/03plugin.t b/t/shredder/03plugin.t
index 25b1222..cf51e44 100644
--- a/t/shredder/03plugin.t
+++ b/t/shredder/03plugin.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 28;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/shredder/03plugin_summary.t b/t/shredder/03plugin_summary.t
index 2744531..606cd67 100644
--- a/t/shredder/03plugin_summary.t
+++ b/t/shredder/03plugin_summary.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 4;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/shredder/03plugin_tickets.t b/t/shredder/03plugin_tickets.t
index 08bb15b..57ab0af 100644
--- a/t/shredder/03plugin_tickets.t
+++ b/t/shredder/03plugin_tickets.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 44;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/shredder/03plugin_users.t b/t/shredder/03plugin_users.t
index 4f4ecc8..e49dd7b 100644
--- a/t/shredder/03plugin_users.t
+++ b/t/shredder/03plugin_users.t
@@ -6,7 +6,7 @@ use warnings;
 use Test::Deep;
 use File::Spec;
 use Test::More tests => 9;
-use RT::Test nodb => 1;
+use RT::Test ();
 BEGIN {
     my $shredder_utils = RT::Test::get_relocatable_file('utils.pl',
         File::Spec->curdir());
diff --git a/t/ticket/add-watchers.t b/t/ticket/add-watchers.t
index 19b1fcb..ae993a9 100644
--- a/t/ticket/add-watchers.t
+++ b/t/ticket/add-watchers.t
@@ -45,7 +45,7 @@
 # 
 # END BPS TAGGED BLOCK }}}
 
-use RT::Test nodata => 1, tests => 32;
+use RT::Test tests => 32;
 
 use strict;
 use warnings;
diff --git a/t/ticket/cfsort-freeform-multiple.t b/t/ticket/cfsort-freeform-multiple.t
index b7bcc0a..b5fd93b 100644
--- a/t/ticket/cfsort-freeform-multiple.t
+++ b/t/ticket/cfsort-freeform-multiple.t
@@ -1,6 +1,6 @@
 #!/usr/bin/perl
 
-use RT::Test nodata => 1, tests => 24;
+use RT::Test tests => 24;
 
 use strict;
 use warnings;
diff --git a/t/ticket/cfsort-freeform-single.t b/t/ticket/cfsort-freeform-single.t
index bae7707..4bf3300 100644
--- a/t/ticket/cfsort-freeform-single.t
+++ b/t/ticket/cfsort-freeform-single.t
@@ -1,6 +1,6 @@
 #!/usr/bin/perl
 
-use RT::Test nodata => 1, tests => 57;
+use RT::Test tests => 57;
 
 use strict;
 use warnings;
diff --git a/t/ticket/deferred_owner.t b/t/ticket/deferred_owner.t
index 4b9cb02..917bbcd 100644
--- a/t/ticket/deferred_owner.t
+++ b/t/ticket/deferred_owner.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 18;
+use RT::Test tests => 18;
 use_ok('RT');
 use_ok('RT::Ticket');
 use Test::Warn;
diff --git a/t/ticket/search.t b/t/ticket/search.t
index 849ce46..9cec4f7 100644
--- a/t/ticket/search.t
+++ b/t/ticket/search.t
@@ -6,7 +6,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 43;
+use RT::Test tests => 43;
 
 # setup the queue
 
diff --git a/t/ticket/search_by_cf_freeform_multiple.t b/t/ticket/search_by_cf_freeform_multiple.t
index 0499a31..8793a7c 100644
--- a/t/ticket/search_by_cf_freeform_multiple.t
+++ b/t/ticket/search_by_cf_freeform_multiple.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 105;
+use RT::Test tests => 105;
 use RT::Ticket;
 
 my $q = RT::Test->load_or_create_queue( Name => 'Regression' );
diff --git a/t/ticket/search_by_cf_freeform_single.t b/t/ticket/search_by_cf_freeform_single.t
index 4fe598c..f597071 100644
--- a/t/ticket/search_by_cf_freeform_single.t
+++ b/t/ticket/search_by_cf_freeform_single.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 99;
+use RT::Test tests => 99;
 use RT::Ticket;
 
 my $q = RT::Test->load_or_create_queue( Name => 'Regression' );
diff --git a/t/ticket/search_by_links.t b/t/ticket/search_by_links.t
index 462a766..611c158 100644
--- a/t/ticket/search_by_links.t
+++ b/t/ticket/search_by_links.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 80;
+use RT::Test tests => 80;
 use RT::Ticket;
 
 my $q = RT::Test->load_or_create_queue( Name => 'Regression' );
diff --git a/t/ticket/search_by_watcher.t b/t/ticket/search_by_watcher.t
index 57c3a46..b3a16db 100644
--- a/t/ticket/search_by_watcher.t
+++ b/t/ticket/search_by_watcher.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 119;
+use RT::Test tests => 119;
 use RT::Ticket;
 
 my $q = RT::Test->load_or_create_queue( Name => 'Regression' );
diff --git a/t/ticket/search_long_cf_values.t b/t/ticket/search_long_cf_values.t
index 339ad70..f9cc7b5 100644
--- a/t/ticket/search_long_cf_values.t
+++ b/t/ticket/search_long_cf_values.t
@@ -6,7 +6,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 10;
+use RT::Test tests => 10;
 
 # setup the queue
 
diff --git a/t/ticket/sort-by-custom-ownership.t b/t/ticket/sort-by-custom-ownership.t
index 3e5df64..b358a99 100644
--- a/t/ticket/sort-by-custom-ownership.t
+++ b/t/ticket/sort-by-custom-ownership.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl
 
 use RT;
-use RT::Test nodata => 1, tests => 7;
+use RT::Test tests => 7;
 
 
 use strict;
diff --git a/t/ticket/sort-by-queue.t b/t/ticket/sort-by-queue.t
index 881a59d..8f89bd3 100644
--- a/t/ticket/sort-by-queue.t
+++ b/t/ticket/sort-by-queue.t
@@ -1,6 +1,6 @@
 #!/usr/bin/perl
 
-use RT::Test nodata => 1, tests => 8;
+use RT::Test tests => 8;
 
 use strict;
 use warnings;
diff --git a/t/ticket/sort-by-user.t b/t/ticket/sort-by-user.t
index b5f6552..d1aae1a 100644
--- a/t/ticket/sort-by-user.t
+++ b/t/ticket/sort-by-user.t
@@ -1,6 +1,6 @@
 #!/usr/bin/perl
 
-use RT::Test nodata => 1, tests => 32;
+use RT::Test tests => 32;
 
 use strict;
 use warnings;
diff --git a/t/ticket/sort_by_cf.t b/t/ticket/sort_by_cf.t
index 8999942..7e25884 100644
--- a/t/ticket/sort_by_cf.t
+++ b/t/ticket/sort_by_cf.t
@@ -1,6 +1,6 @@
 #!/usr/bin/perl
 
-use RT::Test nodata => 1, tests => 21;
+use RT::Test tests => 21;
 RT::Init();
 
 use strict;
diff --git a/t/web/config_tab_right.t b/t/web/config_tab_right.t
index d7f4cbf..4dc9ec0 100644
--- a/t/web/config_tab_right.t
+++ b/t/web/config_tab_right.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 8;
+use RT::Test tests => 8;
 
 my ($uname, $upass, $user) = ('tester', 'tester');
 {
diff --git a/t/web/dashboards-groups.t b/t/web/dashboards-groups.t
index 6b39d01..cbf1d6a 100644
--- a/t/web/dashboards-groups.t
+++ b/t/web/dashboards-groups.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test nodata => 1, tests => 40;
+use RT::Test tests => 40;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 my $url = $m->rt_base_url;
diff --git a/t/web/dashboards-permissions.t b/t/web/dashboards-permissions.t
index 8dc7532..1724042 100644
--- a/t/web/dashboards-permissions.t
+++ b/t/web/dashboards-permissions.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 7;
+use RT::Test tests => 7;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 my $url = $m->rt_base_url;
diff --git a/t/web/rights1.t b/t/web/rights1.t
index 28fac73..c8892f2 100644
--- a/t/web/rights1.t
+++ b/t/web/rights1.t
@@ -2,7 +2,7 @@
 use strict;
 use HTTP::Cookies;
 
-use RT::Test nodata => 1, tests => 29;
+use RT::Test tests => 29;
 my ($baseurl, $agent) = RT::Test->started_ok;
 
 # Create a user with basically no rights, to start.
diff --git a/t/web/ticket_owner.t b/t/web/ticket_owner.t
index d018ec1..0460436 100644
--- a/t/web/ticket_owner.t
+++ b/t/web/ticket_owner.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 89;
+use RT::Test tests => 89;
 
 my $queue = RT::Test->load_or_create_queue( Name => 'Regression' );
 ok $queue && $queue->id, 'loaded or created queue';
diff --git a/t/web/ticket_owner_autocomplete.t b/t/web/ticket_owner_autocomplete.t
index b987e69..24df427 100644
--- a/t/web/ticket_owner_autocomplete.t
+++ b/t/web/ticket_owner_autocomplete.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 39;
+use RT::Test tests => 39;
 use JSON qw(from_json);
 
 my $queue = RT::Test->load_or_create_queue( Name => 'Regression' );
diff --git a/t/web/ticket_seen.t b/t/web/ticket_seen.t
index a285c6a..748f2cb 100644
--- a/t/web/ticket_seen.t
+++ b/t/web/ticket_seen.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 21;
+use RT::Test tests => 21;
 
 my $queue = RT::Test->load_or_create_queue( Name => 'Regression' );
 ok $queue && $queue->id, 'loaded or created queue';

-----------------------------------------------------------------------


More information about the Rt-commit mailing list