[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-631-g4f37db8

Jesse Vincent jesse at bestpractical.com
Mon Aug 30 15:44:38 EDT 2010


The branch, 3.9-trunk has been updated
       via  4f37db894b3caead24a4d9ff7181b730b37a11e3 (commit)
       via  ff54c38fecb07be6372e15c424839e0b89eee2f3 (commit)
      from  63a371a74db5d123a36a8a742d306c814031c3aa (commit)

Summary of changes:
 t/mail/gnupg-outgoing.t |   16 +++-------------
 1 files changed, 3 insertions(+), 13 deletions(-)

- Log -----------------------------------------------------------------
commit ff54c38fecb07be6372e15c424839e0b89eee2f3
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Mon Aug 30 15:45:00 2010 -0400

    Rather than testing the webui's ability to process ticky boxes (like we do in other tests)
    just update the $queue object.

diff --git a/t/mail/gnupg-outgoing.t b/t/mail/gnupg-outgoing.t
index 728eda7..7d421ac 100644
--- a/t/mail/gnupg-outgoing.t
+++ b/t/mail/gnupg-outgoing.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 430;
+use RT::Test tests => 422;
 
 plan skip_all => 'GnuPG required.'
     unless eval 'use GnuPG::Interface; 1';
@@ -301,15 +301,7 @@ sub cleanup_headers {
 
 sub set_queue_crypt_options {
     my %args = @_;
-    $m->get_ok("/Admin/Queues/Modify.html?id=". $queue->id);
-    $m->form_with_fields('Sign', 'Encrypt');
-    foreach my $opt ('Sign', 'Encrypt') {
-        if ( $args{$opt} ) {
-            $m->tick($opt => 1);
-        } else {
-            $m->untick($opt => 1);
-        }
-    }
-    $m->submit;
+            $queue->SetEncrypt($args{'Encrypt'});
+            $queue->SetSign($args{'Sign'});
 }
 

commit 4f37db894b3caead24a4d9ff7181b730b37a11e3
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Mon Aug 30 15:46:56 2010 -0400

    shave off a couple (30+) more heavy loads of /.

diff --git a/t/mail/gnupg-outgoing.t b/t/mail/gnupg-outgoing.t
index 7d421ac..358459f 100644
--- a/t/mail/gnupg-outgoing.t
+++ b/t/mail/gnupg-outgoing.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 422;
+use RT::Test tests => 390;
 
 plan skip_all => 'GnuPG required.'
     unless eval 'use GnuPG::Interface; 1';
@@ -224,7 +224,6 @@ sub create_a_ticket {
 
     unlike($m->content, qr/unable to sign outgoing email messages/);
 
-    $m->get_ok('/'); # ensure that the mail has been processed
 
     my @mail = RT::Test->fetch_caught_mails;
     check_text_emails( \%args, @mail );
@@ -252,7 +251,6 @@ sub update_ticket {
     is $m->status, 200, "request successful";
     $m->content_like(qr/Message recorded/, 'Message recorded') or diag $m->content;
 
-    $m->get_ok('/'); # ensure that the mail has been processed
 
     my @mail = RT::Test->fetch_caught_mails;
     check_text_emails( \%args, @mail );

-----------------------------------------------------------------------


More information about the Rt-commit mailing list