[Rt-commit] rt annotated tag, rt-3.9.7, created. rt-3.9.7
Jesse Vincent
jesse at bestpractical.com
Tue Dec 7 15:48:43 EST 2010
The annotated tag, rt-3.9.7 has been created
at c5bfb5c6cc49f952e051fbf661b823efd9059d58 (tag)
tagging f408beefa34c77ee822ebc6063075777a47f0060 (commit)
replaces rt-3.9.6
tagged by Jesse Vincent
on Tue Dec 7 15:46:32 2010 -0500
- Log -----------------------------------------------------------------
RT 3.9.7
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEABECAAYFAkz+nS0ACgkQEi9d9xCOQEZlHwCfVB6h/9zECcBCyyXmWNwAT3Y1
UYoAn0Gtdu0Vq2Ar8otoVvQuVgOUcJ+j
=1Lk8
-----END PGP SIGNATURE-----
Alex Vandiver (39):
Merge branch '3.9-trunk' into googleish-refactor
Perltidy
Fix module name in POD
Since we check Content, we need to enable FTS
Refactor parsing and dispatch of Googleish
Add active search limits to tests
Quoted values are always subject searches
Allow #123 as a ticket id
Make 123 always mean Id = 123; users can use "123" to search subjects
Searches by id are exempt from queue and status limiting, for obvious reasons
Refactor GuessType into iterating over a list of check subs, and picking the first one
Allow "owner:me" to match tickets I own, and "me" to do that as well
For completeness, add watcher:
Add q:queuename as an alias for queue:queuename
Fix tests -- quoting _should_ only kick in on ' and \
Fix tests -- "me" is equivilent to your username
Quoted phrases are always subject searches
Allow googlish handlers to return a list of limits to push
Allow searching for active or inactive tickets using [active] or [status:active]
Merge branch 'googleish-refactor' into 3.9-trunk
Merge branch 'unique-group-names' into 3.9-trunk
Add a flag to disallow anyone, including the superuser, from executing code
Minor error message wording nits on upgrade script
Merge branch '3.9-attributes_as_columns' into 3.9-trunk
Merge branch '3.8-trunk' into 3.9-trunk
Merge branch 'history-folding' into 3.9-trunk
Merge a couple lost commits from branch 'timezones_in_charts' into 3.8-trunk
Clean out now-removed files from .gitignore
Merge branch 'decode_words_rework' into 3.8-trunk
Fix Oracle upgrade syntax
Showing Starts in two places on the page leads to both JS and update errors
By doing the ticket search later, we can limit on queue and status
Remove mistaken debugging warn()
Short-circuit the query if we have no queues
Don't localize <i> tags
Merge duplicate statements in the SQL log, with some (3 lines) locality fuzz
Merge branch '3.8-trunk' into 3.9-trunk
Limit ObjectsForLoading further to Groups which have a Dashboard attrbiute
We don't care about the list of objects, only if it is empty or not
Chia-liang Kao (11):
callback for admin/queue page menus
Remove webmux and friends
Remove non-psgi web interface codepath
remove crazy alter_superclass for web::request
remove speedycgi and fastcgi-server in rt-test-dependencies.
note about running other psgi servers
Merge branch 'webmux-removal' into 3.9-trunk
remove the IPC::Run::SafeHandles hack and a like.
Fix up ba49022
Run tests with DevelMode=0 by default
replace outdated web server configuration instructions with docs/web_deployment.pod
Emmanuel Lacour (1):
Fix permission issue that allows everyone with SeeCustomField right to modify the existing customfield values (closes: #16089)
Jesse Vincent (29):
Add Transaction type to CSS classes in Ticket history for easier local
Postgres 9 changed their default representation of BYTEA values. RT
Fix t/web/ticket_txn_content.t by actually making
Replace older login infrastructure from a few test files with RT core
Add IE6 friendly variants of menuing images
A bunch of work toward IE6-compatible layouts.
closer to reasonable IE styles
Aileron corner rounding for IE7 and IE8, along with cleanups to rendering on
Added rounded corners for IE7 and 8 in the web2 theme
Clean up folding of plaintext messages and colorization of message
Add a new "inline RT news" component in the adminui
Remove extra markup we don't actually need. trs++
First pass at fixing up "PlainTextPre"
restore plaintextmono
refactor to remove <%PERL> blocks
Unified plain and HTML message display codepaths. Cleaned up extra
Clean up newlines right around stanza breaks
Yet another pass at fixing newline issues
qr'' to qr{} in Elements/Tabs
qr{xxx} in the dispatcher to qr{^/xxx}
qr{/} to qr{^/} in the dispatcher
clean up some straggling dispatcher regexes
Add slightly better diagnostic information on a slightly misconfigured
Fix a variable name in lib/RT/User_Overlay.pm
ACLing for Private/Public key methods (which aren't accessible through a
UI improvements for key management
Better page name for user key management page
Remove the mistaken addition of DevelMode to siteconfig
Remove outdated "Tabular" feature from User/Group lists.
Kevin Falcone (20):
remove debugging
Quick copyediting pass
This prevents you from creating Transaction Custom Fields
Show errors inline like EditCustomFields
Ensure that signatures are loaded on Jumbo
Remove some tabs
Handle SearchTypeless SavedSearches gracefully
remove empty if check.
Switch to aileron as default theme
Fix path
Add classes and ids to the Custom Field Editing page
Add EditCustomFieldsSingleColumn config option
Add some extra scrip logging when debugging
aafceca9b93263a2d79eff4c9b38a8a88004af90 blocked RTFM from being able to
CollectionList has a really naive algorithm for naming
Remove an unused file (Elements/OCFS) and the one unreachable file which
Start installing into /opt/rt4 by default
Remove unused make target
Rename our default database to rt4
clean up rt3 references
Lyle Ross (1):
Updated RedHat layout:
Matt Zagrabelny (4):
Link the Basics title in SelfService/Display.html to the Update page
Add a callback after the requestor textbox in Ticket/Create
Use EditTransactionCustomFields in ModifyAll
Add two callbacks to ModifyAll.html
Ruslan Zakirov (111):
don't print anything if there is no custom fields
$hide_empty argument in TitleBox widget
use hide_empty feature instead of loading custom fields
Bump required version of HTML::Mason to 1.43
don't use @_, but 'my @list', very confusing
pass rest from DecodeMIMEWordsToUTF8 further and use explicit return
localize $@ as we don't throw it further
$enc and $encoding are confusing => s/enc/to_charset/
DecodeMIMEWordsToEncoding: apply quoting trick only to some fields
pass header name into DecodeMIMEWordsTo*
don't corupt queries with negative not-quoted numbers
RT::Queue->lifecycle -> RT::Queue->Lifecycle
is_valid -> IsValid
camel case RT::Lifecycle->IsInitial
more camel casing for lifecycles
Lifecycle->load -> Lifecycle->Load
more camel casing lifecycles code
camel casing in lifecycles
camel casing in lifecycles
finish commit on camel casing lifecycles
describe RT::Lifecycle->Queues
FromSet->StatusType with description
typo in var name
factor out RightsDescription from RegisterRights
adjust ForLocalization method for new storage format
announce rights and its descriptions for localization
move and describe method
describe methods related to move maps
Rename Maps in lifecycles to MoveMaps
delete all manipulation routines from lifecycles
don't check ModifyTicket, as each status change can be protected with own status
tidy code a little bit
support undef argument in Lifecycle->Transitions
pre-fill transitions from '' in the cache
describe transition from '' in the config
clarify docs on lifecycles a little bit
support RT::Lifecycle->IsTransition( '' => 'foo' )
allow to create tickets only with status from '' transitions
SelectStatus: show only ('' -> *) when queue is provided
allow to pass just list of statuses into SelectStatus
change configs
make sure all uses of SelectStatus are correct
improve tests
more tests for googleish search
add Lifecycle column to queues
schema upgrade bits for lifecycle column
generate new Queue.pm using factory
don't use %LifecycleMap in tests
set lifecycle during create
Lifecycle value from DB column
drop LifecycleMap option from the config
set proper lifecycle in the test
drop "exit;" somebody left in the test
fix typo in status name
mark test as todo
add AuthToken column in schemas
use AuthToken from DB not, from attributes
upgrade for schemas
move AuthToken from Attributes into the column on upgrade
regen User.pm
delete some spaces from factory script to match the current state
BasedOn column
use BasedOn from columns, not attributes
upgrade schema properly
move BasedOn from Attributes on upgrade
regenerate CustomField.pm
handle BasedOn in Create properly
move HasRenderType closer to its friends
use RenderType from column instead of attributes
check render type on Create
actually add RenderType column on CustomFields
upgrade schema with RenderType
refactor upgrde script for re-use
move RenderType from Attributes on upgrade
regen CustomField.pm
SubjectTag column on Queues
add SubjectTag column on upgrade
upgrade function that moves SubjectTag from attributes
regen Queue.pm
use SubjectTag from column, not from attributes
gather subject tags from column in Queues table
CustomFields.ValuesClass column
add CustomFields.ValuesClass on upgrade
set CustomFields.ValuesClass from Attributes table
use CustomFields.Values class instead of attributes
ValuesClass is validated against config, fix test
we depend on SB 1.59 now
pass undef in ValidateValuesClass
add lifecycle editor to queue's admin page
add lifecycle to queue's column map
move some functions into RT::Test
factor out query generators out HasRight and friends
Principal->HasRights method
use new cache entry in HasRight
fill ACL cache when ticket is about to be displayed
use HasRights in tabs
simple tests for HasRights
document HasRights and cleanup HasRight's docs
handle special ExecuteCode right
drop historical methods that related to status changes
move lifecycle's default values and give them more reasonable names
refactor lifecycle defaults in the RT config
use new lifecycle defaults API
don't log localized message
use new lifecycle defaults API
adjust lifecycle tests
move schema upgrade from 3.9.6 to 3.9.7
Merge branch '3.9-lifecycles_improvments_v2' into 3.9-trunk
Merge branch '3.9-double_acl_cache' into 3.9-trunk
disable GnuPG to avoid warnings and test failures
Merge branch 'hide_empty_in_title_box' into 3.9-trunk
Shawn M Moore (101):
Try safeguarding against searches without ->Content
Give EditTransactionCustomFields an AsTable option
Make Create.html TxnCFs a table to more closely match TicketCFs
Integrate EditTxnCFs into the table of fields
Typo fix in the Scalar::Util breakage message
Fix and prettify a broken regex
Fix some File::Temp usage in rt-message-catalog
Factor out PO_DIR and update it to share/po
Fix extract-message-catalog's path
Update more lib/RT/I18N directories
Pull in updated translations from Rosetta
Add new Icelandic translation
Fix our SavedSearches synopsis..
Refactor most of RT::SavedSearches into a new RT::SharedSettings
Create an RT::Dashboards pseudo-collection using RT::SharedSettings
Factor out loading a Dashboard's subscription into a method
Convert Elements/Dashboards to using CollectionList
Add the Edit link for dashboards back in
Add a ColumnMap for Dashboards and use its ShowURL
Include Subscription in ColumnMap and Elements/Dashboards
The parameter Subscription.html wants is id not DashboardId
Make the Dashboards title box a link too
Factor out the CollectionList stuff into ShowDashboards
We don't use ShowSubscription any more (since it's in columnmap now)
DashboardTabs obsolete since dashboards were subsumed into the menu
Re-add ListActions to the dashboards index page
Include request_path in the dashboard FakeRequest
Put $id into the dashboard table tag's id
Move the one file in t/maildigest into t/mail
Move savedsearch.t into t/api
Move more tests out of the top-level t/
When sending a real dashboard, include edit links at the bottom
Remove spurious +x mode from Dashboards/Modify.html
Don't use loc-style messages for logging
Use $RT::Logger directly for errors and warnings
Eliminate --debug in favor of $RT::Logger->debug
Eliminate --verbose in favor of $RT::Logger->info
Remove skip-acl option which doesn't do anything
A bit more help prose
Depend on HTML::RewriteAttributes 0.04
Move the mail log to just before we do mail the dashboard
Librarize rt-email-dashboards
Use the right parameter for the To address
Thread the From address down to BuildEmail
Better limit the scope of Mason var localization
Pass CLI args through the dashboard mail subsystem
Kick down some log levels in dashboard mailing
Don't escape the quotes in selected="selected" etc
First pass at tests for dashboard mail
Remove some code I cribbed mail stuff off of
Remove set_mail_catcher which is just a no-op
set_mail_catcher is unneeded
"RT::Logger->debug and return" is not always going to return
Test the dashboard mail subject
Explicitly set Frequency and Hour
More tests for various dashboard times etc
Have GPG's test config extend regular test config
Factor out the dashboard mail checking into functions
Name the two timestamps for readability
Some more interesting combinations
Move the MailDashboards calls into the test functions
Lie less about the dashboard subject template
Document @EmailDashboardRemove which we've supported for a while
Test the From address (== OwnerEmail) from dashboards
Test some dashboard config
URLs will have the domain in it
Clean up CullRTAddresses
Merge branch 'librarize-send-dashboards' into 3.9-trunk
Use lexical filehandles in bin/rt
Bring up DateTime and DateTime::Locale to real deps
DateTime::Locale not ::Format
Kill a bunch more needless qr''s
Dashboards have outgrown having just queries
Factor out an ObsoleteSubscription method
Rewording text fix
Use the right method name for munging URI params
Trivial fix to be more consistent for localization
Factor out RT::Date->LocaleObj so we only have this code once
Localize the subscription timestamp dropdown
Use only the HH:00 format internally
Localize the hour for Dashboard ColumnMap as well
Fix weird double initialization that snuck in
RT::Ticket::Resolve went away, use SetStatus instead
query_form doesn't return the query_form when used as a setter
Default TxnRecipients to '' to avoid undef warnings
Ignore AuthToken for searching on users
More undef cleaning
Use the query_string function we already have
Remove ancient (2.0.x) file that apparently isn't used anywhere
Remove some useless =cuts
Add dashboard classes to t/00-compile.t
_PrivacyObjects(create => 1) no longer dwims
DashboardsForObjects can be removed in favor of ListOfDashboards
Remove some vim folding markers
RT::Groups->ForWhichCurrentUserHasRight
Override ObjectsForLoading to make it faster with a more direct query
Fix HasRight calls
Return the alias from WithMember
Only load dashboards from user-defined groups
Tests for ForWhichCurrentUserHasRight
Merge branch 'dashboard-acl-query' into 3.9-trunk
Thomas Sibley (36):
Fix a template content type bug when relying on $PreferredContentType
Also bail out of the rich text editor for the iPad
Redirect to the desired page after logging in a user
Add more entropy to the next page hash and yes, we need to ++ the session
Refactor the "error and tangent" pattern to a method
Don't show login errors as a bulleted list
Fix passing login errors when on /
Do the right thing with //Ticket/Display.html when it's the REQUEST_URI
If we're adding the hostname to a relative URL, also add the port
Tests for the new login flow
Delete next page hashes from the session as we use them
Also show The Basics link on SelfService with right ReplyToTicket
Merge branch 'redirect-after-login' into 3.8-trunk
First pass at importing history folding from a client project
Silence some uninit warnings
Use the ShowUser element more often for consistent user display
Provide a default saved search option with no value
Pass the Page parameter too since the list is now paged
Switch to autocomplete for selecting users and groups when editing members
Enforce unique group names for user defined groups
Warn about existing duplicate group names
Check for non-unique UserDefined group names in rt-validator
Add upgrading information about unique group names
Tweak the wording of the group unique name warning
Merge branch 'setowner-refactor' into 3.9-trunk
Fix typo
Validate group name uniqueness only for enabled groups
Make sure preferences widgets clear the ones before them
Prefix the CF name and type classes to avoid conflicts
Merge branch '3.8-edit-custom-fields-enhancements' into 3.8-trunk
Use the jQuery plugin Supposition to help keep menus in the viewport
Revert "Kill the superfluous Settings submenu to decrease the menu levels"
Remove a stray console.log() from debugging
Fix the header selectors so it doesn't get the wrong nav on web2
Revert "Fix tests to account for my menu changes"
Move the section to CSS mapping to Perl
Tom Lanyon (1):
Logic bug in bin/fastcgi_server; allow use of --port.
sunnavy (46):
change bookmark toggle from id to class so we can toggle more elements
missing a closing div tag
missing a Approver->Name change
tweak a tiny bit
customize out_method to encode right
make Approver->Name change in upgrade
case fix: the other 2 use lower cases
make content html to test more
no need to ajax more than once
for SetOwner: txn type is always Set, but we also want the customized description, which can be accomplished by checking the old/new values
set link to /m/index.html?NotMobile=1 directly to avoid cases where server/browser can't figure it out
multiple background-color makes ie<8 unhappy
make body in login page a bit higher and left/right sides symmetrical
update web2 css mainly to avoid overlap for ie
ie7 lacks a bit space in bottom of #app-nav
new config DisplayTicketAfterQuickCreate thanks to Ivan Kohler
test config DisplayTicketAfterQuickCreate
add RT::I18N::_CanonicalizeCharset
test for RT::I18N::_CanonicalizeCharset
RT->Config->Get auto dereference if config variable is @ or %
EmailDashboardRemove maybe undef
force to refresh as "use $module" does not try to reload
rewrite clicky.t: test clicky with httpurl,httpurl_overwrite and none
try to parse #anchor in makeclicky
should clear the message box if the message is recorded already
dashboard title was updated in 8897ee388a
WebURL has trailing / already
rt_base_url has trailing /
$path may end with /
show create and/or select links in pagemenu
no warnings test in the end
BasedOn may be empty
capture the warning
in case id is not a number
warning fix
ease the ::Lexicon used only once warning
catch the Time::ParseDate warning
don't call $agent directly in subs, trans it to @_ first.
seems no need to stop_server here any more
no need to checkk @SERVERS
warning fix
Config->Set prefers flat list
need to explicitly set the input value as we customized select callback
clean old code: no need Groups-Name any more
fix the bug for /Admin/Users too, see also f701c40700d3
returned name should be only from phrase for RT::Interface::Email::ParseAddressFromHeader
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list