[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-187-gc26119f

Thomas Sibley trs at bestpractical.com
Thu Jul 29 14:28:21 EDT 2010


The branch, 3.9-trunk has been updated
       via  c26119f0ef8e2b0f6739bf7617b13ab81269eff5 (commit)
      from  0e31592b0e2abbd9ca4156604b710d12399de5be (commit)

Summary of changes:
 share/html/NoAuth/css/base/misc.css         |   14 ++++++++++++
 share/html/Ticket/Elements/EditCustomFields |   30 ++++++++------------------
 2 files changed, 23 insertions(+), 21 deletions(-)

- Log -----------------------------------------------------------------
commit c26119f0ef8e2b0f6739bf7617b13ab81269eff5
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Jul 29 14:28:06 2010 -0400

    Stop using a table to layout CF edit fields

diff --git a/share/html/NoAuth/css/base/misc.css b/share/html/NoAuth/css/base/misc.css
index d46f8a4..eb3c171 100644
--- a/share/html/NoAuth/css/base/misc.css
+++ b/share/html/NoAuth/css/base/misc.css
@@ -98,3 +98,17 @@ hr.clear {
     border: none;
     font-size: 1px;
 }
+
+
+/* Custom fields */
+
+.cflabel {
+    float: left;
+}
+
+.edit-custom-field {
+    width: 48%;
+    float: left;
+    margin: 0.5em;
+}
+
diff --git a/share/html/Ticket/Elements/EditCustomFields b/share/html/Ticket/Elements/EditCustomFields
index be4b8fd..e9438d9 100755
--- a/share/html/Ticket/Elements/EditCustomFields
+++ b/share/html/Ticket/Elements/EditCustomFields
@@ -46,19 +46,16 @@
 %# 
 %# END BPS TAGGED BLOCK }}}
 % $m->callback( %ARGS, CallbackName => 'BeforeCustomFields' );
-<table>
-% my $i = 0;
+<div class="edit-custom-fields">
 % while ( my $CustomField = $CustomFields->Next ) {
 % next unless $CustomField->CurrentUserHasRight('ModifyCustomField');
-% $i++;
-% if ( $i % 2 ) {
-<tr>
-% }
-    <td class="cflabel">
+
+  <div class="edit-custom-field">
+    <div class="cflabel">
       <b><% loc($CustomField->Name) %></b><br />
       <i><% $CustomField->FriendlyType %></i>
-    </td>
-    <td class="entry">
+    </div>
+    <div class="entry">
 % my $default = $m->notes('Field-' . $CustomField->Id);
 % $default ||= $ARGS{"CustomField-". $CustomField->Id };
       <& /Elements/EditCustomField, 
@@ -72,20 +69,11 @@
         <br />
         <span class="cfinvalidfield"><% $msg %></span>
 %  }
-    </td>
-
-% unless ( $i % 2 ) {
-</tr>
-% }
-
-% }
-
-%# close row if required
-% if ( $i % 2 ) {
-</tr>
+    </div>
+  </div>
 % }
 
-</table>
+</div>
 % $m->callback( %ARGS, CallbackName => 'AfterCustomFields', TicketObj => $TicketObj, QueueObj => $QueueObj );
 <%INIT>
 my $CustomFields;

-----------------------------------------------------------------------


More information about the Rt-commit mailing list