[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-100-g0d04a0e

Shawn Moore sartak at bestpractical.com
Wed Jun 30 17:48:18 EDT 2010


The branch, 3.9-trunk has been updated
       via  0d04a0ebf31f6c8dde9831518ed50068470dd6cc (commit)
      from  fde9e681c3fab37c9482c7a39d42f446b35156e4 (commit)

Summary of changes:
 etc/RT_Config.pm.in                       |   11 -----------
 share/html/Admin/CustomFields/Modify.html |    9 ---------
 2 files changed, 0 insertions(+), 20 deletions(-)

- Log -----------------------------------------------------------------
commit 0d04a0ebf31f6c8dde9831518ed50068470dd6cc
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Wed Jun 30 17:48:53 2010 -0400

    Revert "New config $HideCustomFieldValidator"
    
    This reverts commit 83ace0a90979429c8784623f0dde1d4d638c362e.
    
    Too specific (and kinda useless) for core, this is shipping out to an
    extension

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index 0142e71..c148c25 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -1539,17 +1539,6 @@ Use this to set the default units for time entry to hours instead of minutes.
 
 Set($DefaultTimeUnitsToHours, 0);
 
-=item C<$HideCustomFieldValidator>
-
-Use this to hide the regular expression used to validate custom field values.
-This applies only to the custom field admin interface. The regular expression's
-first comment will be used as the label for that validator. For example, the
-validator C<(?#Digits)^[\d.]+$> will display as just C<Digits>.
-
-=cut
-
-Set($HideCustomFieldValidator, 0);
-
 =back
 
 =head1 L<Net::Server> (rt-server) Configuration
diff --git a/share/html/Admin/CustomFields/Modify.html b/share/html/Admin/CustomFields/Modify.html
index 14eceb3..f75607a 100644
--- a/share/html/Admin/CustomFields/Modify.html
+++ b/share/html/Admin/CustomFields/Modify.html
@@ -230,15 +230,6 @@ my @CFvalidations = (
 
 $m->callback(CallbackName => 'ValidationPatterns', Values => \@CFvalidations);
 
-if (RT->Config->Get('HideCustomFieldValidator')) {
-    for my $pattern (@CFvalidations) {
-        next if ref($pattern);
-        if (my ($name) = $pattern =~ /\(\?\#(\w+)\)/) {
-            $pattern = { name => $pattern, label => $name };
-        }
-    }
-}
-
 </%INIT>
 <%ARGS>
 $id => undef

-----------------------------------------------------------------------


More information about the Rt-commit mailing list