[Rt-commit] rt branch, 3.8/no-dollar-underbar, created. rt-3.8.10-2-g3545769

Kevin Falcone falcone at bestpractical.com
Fri Apr 15 12:49:58 EDT 2011


The branch, 3.8/no-dollar-underbar has been created
        at  35457690becf4d73d09a027dabba9038948ffca0 (commit)

- Log -----------------------------------------------------------------
commit 35457690becf4d73d09a027dabba9038948ffca0
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Apr 15 12:21:26 2011 -0400

    Net::LDAP::Contant was breaking when trying to modify $_
    
    Changing to a named variable in this loop makes it happier

diff --git a/lib/RT/Base.pm b/lib/RT/Base.pm
index 3970850..c7fc66e 100755
--- a/lib/RT/Base.pm
+++ b/lib/RT/Base.pm
@@ -168,8 +168,8 @@ sub _ImportOverlays {
     my $class = shift;
     my ($package,undef,undef) = caller();
     $package =~ s|::|/|g;
-    for (qw(Overlay Vendor Local)) {
-        my $filename = $package."_".$_.".pm";
+    for my $type (qw(Overlay Vendor Local)) {
+        my $filename = $package."_".$type.".pm";
         eval { require $filename };
         die $@ if ($@ && $@ !~ qr{^Can't locate $filename});
     }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list