[Rt-commit] rt branch, 4.0/code-policy, created. rt-4.0.2-27-gbf8618d
? sunnavy
sunnavy at bestpractical.com
Mon Aug 22 02:17:34 EDT 2011
The branch, 4.0/code-policy has been created
at bf8618d2c9a6578fb1089efa86aeabcc09a7e1bf (commit)
- Log -----------------------------------------------------------------
commit bc0f6ac4926e8bd8a54f6924bde7bdc9ac5b988c
Author: sunnavy <sunnavy at bestpractical.com>
Date: Mon Aug 22 10:10:45 2011 +0800
code policy test
diff --git a/t/99-policy.t b/t/99-policy.t
new file mode 100644
index 0000000..b65b9c3
--- /dev/null
+++ b/t/99-policy.t
@@ -0,0 +1,64 @@
+use strict;
+use warnings;
+
+use RT::Test nodb => 1;
+use File::Find;
+
+sub check {
+ my $file = shift;
+ my $type = shift;
+
+ local $/;
+ open my $fh, '<', $file or die $!;
+ my $content = <$fh>;
+ like(
+ $content,
+ qr/^use strict(?:;|\s+)/m,
+ $File::Find::name . ' has "use strict"'
+ );
+ like(
+ $content,
+ qr/^use warnings(?:;|\s+)/m,
+ $File::Find::name . ' has "use warnings"'
+ );
+ my $mode = sprintf( '%04o', ( stat $file )[2] & 07777 );
+ if ( $type eq 'script' ) {
+ like( $content, qr/^#!/, $File::Find::name . ' has shebang' );
+ if ( $file =~ /\.in/ ) {
+ is( $mode, '0644', $File::Find::name . ' permission is 0644' );
+ }
+ else {
+ is( $mode, '0754', $File::Find::name . ' permission is 0754' );
+ }
+ }
+ else {
+ unlike( $content, qr/^#!/, $File::Find::name . ' has no shebang' );
+ is( $mode, '0644', $File::Find::name . ' permission is 0644' );
+ }
+}
+
+find(
+ sub {
+ return unless -f && /\.pm$/;
+ check( $_, 'lib' );
+ },
+ 'lib',
+);
+
+find(
+ sub {
+ return unless -f && /\.t$/;
+ check( $_, 'test' );
+ },
+ 't',
+);
+
+find(
+ sub {
+ return unless -f;
+ check( $_, 'script' );
+ },
+ 'bin',
+ 'sbin'
+);
+
commit cf05bd27b3662755ce8dce5b59f0bc3574f17408
Author: sunnavy <sunnavy at bestpractical.com>
Date: Mon Aug 22 10:11:15 2011 +0800
update code to meet code policy
diff --git a/bin/rt-crontool.in b/bin/rt-crontool.in
old mode 100755
new mode 100644
index 0eb61b4..4b5d19c
--- a/bin/rt-crontool.in
+++ b/bin/rt-crontool.in
@@ -47,6 +47,7 @@
#
# END BPS TAGGED BLOCK }}}
use strict;
+use warnings;
use Carp;
# fix lib paths, some may be relative
diff --git a/bin/rt-mailgate.in b/bin/rt-mailgate.in
old mode 100755
new mode 100644
diff --git a/bin/rt.in b/bin/rt.in
old mode 100755
new mode 100644
index 3bb5a37..688779b
--- a/bin/rt.in
+++ b/bin/rt.in
@@ -50,6 +50,7 @@
# Abhijit Menon-Sen <ams at wiw.org>
use strict;
+use warnings;
if ( $ARGV[0] && $ARGV[0] =~ /^(?:--help|-h)$/ ) {
require Pod::Usage;
diff --git a/lib/RT/Action/EscalatePriority.pm b/lib/RT/Action/EscalatePriority.pm
index 090695c..01aed22 100644
--- a/lib/RT/Action/EscalatePriority.pm
+++ b/lib/RT/Action/EscalatePriority.pm
@@ -78,6 +78,7 @@ package RT::Action::EscalatePriority;
use base 'RT::Action';
use strict;
+use warnings;
#Do what we need to do and send it out.
diff --git a/lib/RT/Action/ExtractSubjectTag.pm b/lib/RT/Action/ExtractSubjectTag.pm
index 756c981..94d6272 100644
--- a/lib/RT/Action/ExtractSubjectTag.pm
+++ b/lib/RT/Action/ExtractSubjectTag.pm
@@ -49,6 +49,7 @@
package RT::Action::ExtractSubjectTag;
use base 'RT::Action';
use strict;
+use warnings;
sub Describe {
my $self = shift;
diff --git a/lib/RT/Action/RecordComment.pm b/lib/RT/Action/RecordComment.pm
index 5d3664d..bc30584 100644
--- a/lib/RT/Action/RecordComment.pm
+++ b/lib/RT/Action/RecordComment.pm
@@ -49,6 +49,7 @@
package RT::Action::RecordComment;
use base 'RT::Action';
use strict;
+use warnings;
=head1 NAME
diff --git a/lib/RT/Action/RecordCorrespondence.pm b/lib/RT/Action/RecordCorrespondence.pm
index 109c0df..6e98838 100644
--- a/lib/RT/Action/RecordCorrespondence.pm
+++ b/lib/RT/Action/RecordCorrespondence.pm
@@ -49,6 +49,7 @@
package RT::Action::RecordCorrespondence;
use base 'RT::Action';
use strict;
+use warnings;
=head1 NAME
diff --git a/lib/RT/Action/SetPriority.pm b/lib/RT/Action/SetPriority.pm
index 1b6c758..bcfbad2 100644
--- a/lib/RT/Action/SetPriority.pm
+++ b/lib/RT/Action/SetPriority.pm
@@ -50,6 +50,7 @@ package RT::Action::SetPriority;
use base 'RT::Action';
use strict;
+use warnings;
#Do what we need to do and send it out.
diff --git a/lib/RT/Action/UserDefined.pm b/lib/RT/Action/UserDefined.pm
index 3d8e73c..1bb0450 100644
--- a/lib/RT/Action/UserDefined.pm
+++ b/lib/RT/Action/UserDefined.pm
@@ -50,6 +50,7 @@ package RT::Action::UserDefined;
use base 'RT::Action';
use strict;
+use warnings;
=head2 Prepare
diff --git a/lib/RT/Condition/AnyTransaction.pm b/lib/RT/Condition/AnyTransaction.pm
index 7558794..77e3e42 100644
--- a/lib/RT/Condition/AnyTransaction.pm
+++ b/lib/RT/Condition/AnyTransaction.pm
@@ -50,6 +50,7 @@ package RT::Condition::AnyTransaction;
use base 'RT::Condition';
use strict;
+use warnings;
=head2 IsApplicable
diff --git a/lib/RT/Condition/BeforeDue.pm b/lib/RT/Condition/BeforeDue.pm
index 643b5a6..72c8b9a 100644
--- a/lib/RT/Condition/BeforeDue.pm
+++ b/lib/RT/Condition/BeforeDue.pm
@@ -52,6 +52,7 @@ use base 'RT::Condition';
use RT::Date;
use strict;
+use warnings;
sub IsApplicable {
my $self = shift;
diff --git a/lib/RT/Condition/Overdue.pm b/lib/RT/Condition/Overdue.pm
index 17f71f5..feb8db3 100644
--- a/lib/RT/Condition/Overdue.pm
+++ b/lib/RT/Condition/Overdue.pm
@@ -59,6 +59,7 @@ Returns true if the ticket we're operating on is overdue
package RT::Condition::Overdue;
use base 'RT::Condition';
use strict;
+use warnings;
=head2 IsApplicable
diff --git a/lib/RT/Condition/OwnerChange.pm b/lib/RT/Condition/OwnerChange.pm
index 42048cd..7e15332 100644
--- a/lib/RT/Condition/OwnerChange.pm
+++ b/lib/RT/Condition/OwnerChange.pm
@@ -49,6 +49,7 @@
package RT::Condition::OwnerChange;
use base 'RT::Condition';
use strict;
+use warnings;
=head2 IsApplicable
diff --git a/lib/RT/Condition/PriorityChange.pm b/lib/RT/Condition/PriorityChange.pm
index b13b48d..c9b0650 100644
--- a/lib/RT/Condition/PriorityChange.pm
+++ b/lib/RT/Condition/PriorityChange.pm
@@ -49,6 +49,7 @@
package RT::Condition::PriorityChange;
use base 'RT::Condition';
use strict;
+use warnings;
=head2 IsApplicable
diff --git a/lib/RT/Condition/PriorityExceeds.pm b/lib/RT/Condition/PriorityExceeds.pm
index 916b71d..8c511e2 100644
--- a/lib/RT/Condition/PriorityExceeds.pm
+++ b/lib/RT/Condition/PriorityExceeds.pm
@@ -49,6 +49,7 @@
package RT::Condition::PriorityExceeds;
use base 'RT::Condition';
use strict;
+use warnings;
=head2 IsApplicable
diff --git a/lib/RT/Condition/QueueChange.pm b/lib/RT/Condition/QueueChange.pm
index dab4299..847967d 100644
--- a/lib/RT/Condition/QueueChange.pm
+++ b/lib/RT/Condition/QueueChange.pm
@@ -49,6 +49,7 @@
package RT::Condition::QueueChange;
use base 'RT::Condition';
use strict;
+use warnings;
=head2 IsApplicable
diff --git a/lib/RT/Condition/StatusChange.pm b/lib/RT/Condition/StatusChange.pm
index f3479cc..ae9b41b 100644
--- a/lib/RT/Condition/StatusChange.pm
+++ b/lib/RT/Condition/StatusChange.pm
@@ -49,6 +49,7 @@
package RT::Condition::StatusChange;
use base 'RT::Condition';
use strict;
+use warnings;
=head2 DESCRIPTION
diff --git a/lib/RT/Condition/UserDefined.pm b/lib/RT/Condition/UserDefined.pm
index fac3394..4a24431 100644
--- a/lib/RT/Condition/UserDefined.pm
+++ b/lib/RT/Condition/UserDefined.pm
@@ -49,6 +49,7 @@
package RT::Condition::UserDefined;
use base 'RT::Condition';
use strict;
+use warnings;
=head2 IsApplicable
diff --git a/lib/RT/Dashboards.pm b/lib/RT/Dashboards.pm
index 3509a0a..3d5f010 100644
--- a/lib/RT/Dashboards.pm
+++ b/lib/RT/Dashboards.pm
@@ -70,6 +70,7 @@ package RT::Dashboards;
use RT::Dashboard;
use strict;
+use warnings;
use base 'RT::SharedSettings';
sub RecordClass {
diff --git a/lib/RT/Interface/CLI.pm b/lib/RT/Interface/CLI.pm
index f98d2d5..a3a3041 100644
--- a/lib/RT/Interface/CLI.pm
+++ b/lib/RT/Interface/CLI.pm
@@ -47,6 +47,7 @@
# END BPS TAGGED BLOCK }}}
package RT::Interface::CLI;
use strict;
+use warnings;
use RT;
use base 'Exporter';
diff --git a/lib/RT/ObjectTopic.pm b/lib/RT/ObjectTopic.pm
index e45b3e3..c87818c 100644
--- a/lib/RT/ObjectTopic.pm
+++ b/lib/RT/ObjectTopic.pm
@@ -52,7 +52,6 @@
# !! DO NOT EDIT THIS FILE !!
#
-
=head1 NAME
RT::ObjectTopic
@@ -66,8 +65,11 @@ RT::ObjectTopic
=cut
-no warnings 'redefine';
package RT::ObjectTopic;
+use strict;
+use warnings;
+no warnings 'redefine';
+
use RT::Record;
use RT::Topic;
diff --git a/lib/RT/SavedSearches.pm b/lib/RT/SavedSearches.pm
index 069bf92..c696543 100644
--- a/lib/RT/SavedSearches.pm
+++ b/lib/RT/SavedSearches.pm
@@ -70,6 +70,7 @@ package RT::SavedSearches;
use RT::SavedSearch;
use strict;
+use warnings;
use base 'RT::SharedSettings';
sub RecordClass {
diff --git a/lib/RT/Search/ActiveTicketsInQueue.pm b/lib/RT/Search/ActiveTicketsInQueue.pm
index ed2c0fa..508479a 100644
--- a/lib/RT/Search/ActiveTicketsInQueue.pm
+++ b/lib/RT/Search/ActiveTicketsInQueue.pm
@@ -66,6 +66,7 @@ Find all active tickets in the queue named in the argument passed in
package RT::Search::ActiveTicketsInQueue;
use strict;
+use warnings;
use base qw(RT::Search);
diff --git a/lib/RT/Search/FromSQL.pm b/lib/RT/Search/FromSQL.pm
index f5fd50a..775df5d 100644
--- a/lib/RT/Search/FromSQL.pm
+++ b/lib/RT/Search/FromSQL.pm
@@ -66,6 +66,7 @@ Find all tickets described by the SQL statement passed as an argument
package RT::Search::FromSQL;
use strict;
+use warnings;
use base qw(RT::Search);
=head2 Describe
diff --git a/lib/RT/SharedSettings.pm b/lib/RT/SharedSettings.pm
index 8013e89..8cc6fdd 100644
--- a/lib/RT/SharedSettings.pm
+++ b/lib/RT/SharedSettings.pm
@@ -70,6 +70,7 @@ package RT::SharedSettings;
use RT::SharedSetting;
use strict;
+use warnings;
use base 'RT::Base';
sub new {
diff --git a/lib/RT/Shredder/Dependencies.pm b/lib/RT/Shredder/Dependencies.pm
index 753364f..8de16dd 100644
--- a/lib/RT/Shredder/Dependencies.pm
+++ b/lib/RT/Shredder/Dependencies.pm
@@ -49,6 +49,7 @@
package RT::Shredder::Dependencies;
use strict;
+use warnings;
use RT::Shredder::Exceptions;
use RT::Shredder::Constants;
use RT::Shredder::Dependency;
diff --git a/lib/RT/Shredder/Dependency.pm b/lib/RT/Shredder/Dependency.pm
index 1de1a93..a2f2caa 100644
--- a/lib/RT/Shredder/Dependency.pm
+++ b/lib/RT/Shredder/Dependency.pm
@@ -49,6 +49,7 @@
package RT::Shredder::Dependency;
use strict;
+use warnings;
use RT::Shredder::Constants;
use RT::Shredder::Exceptions;
diff --git a/lib/RT/Test/GnuPG.pm b/lib/RT/Test/GnuPG.pm
index 56e748b..bd9a287 100644
--- a/lib/RT/Test/GnuPG.pm
+++ b/lib/RT/Test/GnuPG.pm
@@ -48,6 +48,7 @@
package RT::Test::GnuPG;
use strict;
+use warnings;
use Test::More;
use base qw(RT::Test);
use File::Temp qw(tempdir);
diff --git a/lib/RT/Topics.pm b/lib/RT/Topics.pm
index a32de3d..9fac0c2 100644
--- a/lib/RT/Topics.pm
+++ b/lib/RT/Topics.pm
@@ -47,6 +47,7 @@
# END BPS TAGGED BLOCK }}}
use strict;
+use warnings;
no warnings qw(redefine);
package RT::Topics;
diff --git a/lib/RT/URI/base.pm b/lib/RT/URI/base.pm
index 1534149..8414dc4 100644
--- a/lib/RT/URI/base.pm
+++ b/lib/RT/URI/base.pm
@@ -49,6 +49,7 @@
package RT::URI::base;
use strict;
+use warnings;
use base qw(RT::Base);
=head1 NAME
diff --git a/sbin/rt-dump-metadata.in b/sbin/rt-dump-metadata.in
old mode 100755
new mode 100644
index 6232468..b37d5f9
--- a/sbin/rt-dump-metadata.in
+++ b/sbin/rt-dump-metadata.in
@@ -47,6 +47,7 @@
#
# END BPS TAGGED BLOCK }}}
use strict;
+use warnings;
# As we specify that XML is UTF-8 and we output it to STDOUT, we must be sure
# it is UTF-8 so further XMLin will not break
diff --git a/sbin/rt-email-group-admin.in b/sbin/rt-email-group-admin.in
old mode 100755
new mode 100644
diff --git a/sbin/rt-server.in b/sbin/rt-server.in
old mode 100755
new mode 100644
diff --git a/sbin/rt-setup-database.in b/sbin/rt-setup-database.in
old mode 100755
new mode 100644
diff --git a/sbin/rt-shredder.in b/sbin/rt-shredder.in
old mode 100755
new mode 100644
diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
old mode 100755
new mode 100644
index 04fe46e..abdf712
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -52,6 +52,7 @@
#
use strict;
+use warnings;
no warnings qw(numeric redefine);
use Getopt::Long;
my %args;
diff --git a/t/00-mason-syntax.t b/t/00-mason-syntax.t
index 256c56e..e3f625b 100644
--- a/t/00-mason-syntax.t
+++ b/t/00-mason-syntax.t
@@ -1,5 +1,3 @@
-#!/usr/bin/perl
-
use strict;
use warnings;
diff --git a/t/api/attachment_filename.t b/t/api/attachment_filename.t
index bcbfe00..6bfc707 100644
--- a/t/api/attachment_filename.t
+++ b/t/api/attachment_filename.t
@@ -1,3 +1,5 @@
+use strict;
+use warnings;
use RT::Test tests => 5;
use MIME::Entity;
my $ticket = RT::Ticket->new(RT->SystemUser);
diff --git a/t/api/cf_rights.t b/t/api/cf_rights.t
index f55214a..e8a75c1 100644
--- a/t/api/cf_rights.t
+++ b/t/api/cf_rights.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/api/cron.t b/t/api/cron.t
index 6f9d7f6..6bd992d 100644
--- a/t/api/cron.t
+++ b/t/api/cron.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl -w
-
use strict;
+use warnings;
use RT;
use RT::Test nodata => 1, tests => 18;
diff --git a/t/api/date.t b/t/api/date.t
index 9756e51..ad1e3ec 100644
--- a/t/api/date.t
+++ b/t/api/date.t
@@ -1,9 +1,9 @@
-#!/usr/bin/perl
use Test::MockTime qw(set_fixed_time restore_time);
use DateTime;
-use warnings; use strict;
+use warnings;
+use strict;
use RT::Test tests => 172;
use RT::User;
use Test::Warn;
diff --git a/t/api/i18n_guess.t b/t/api/i18n_guess.t
index 139ec1a..956cb15 100644
--- a/t/api/i18n_guess.t
+++ b/t/api/i18n_guess.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/api/password-types.t b/t/api/password-types.t
index 5f253d5..e5155e3 100644
--- a/t/api/password-types.t
+++ b/t/api/password-types.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/api/rights.t b/t/api/rights.t
index a1795ca..9328fda 100644
--- a/t/api/rights.t
+++ b/t/api/rights.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
# BEGIN BPS TAGGED BLOCK {{{
#
# COPYRIGHT:
diff --git a/t/api/rights_show_ticket.t b/t/api/rights_show_ticket.t
index 62f62c4..c8107fe 100644
--- a/t/api/rights_show_ticket.t
+++ b/t/api/rights_show_ticket.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use RT::Test nodata => 1, tests => 264;
diff --git a/t/api/rtname.t b/t/api/rtname.t
index ef6092b..8b7b54b 100644
--- a/t/api/rtname.t
+++ b/t/api/rtname.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/api/scrip_order.t b/t/api/scrip_order.t
index 22d3f21..6fba7e5 100644
--- a/t/api/scrip_order.t
+++ b/t/api/scrip_order.t
@@ -1,6 +1,6 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT;
use RT::Test tests => 7;
diff --git a/t/api/template-insert.t b/t/api/template-insert.t
index 1bf5fc3..743b73c 100644
--- a/t/api/template-insert.t
+++ b/t/api/template-insert.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/api/versions_sorter.t b/t/api/versions_sorter.t
index b2ec547..fb628f1 100644
--- a/t/api/versions_sorter.t
+++ b/t/api/versions_sorter.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use RT::Test nodata => 1, tests => 3;
diff --git a/t/articles/article.t b/t/articles/article.t
index 33becb0..7a3474f 100644
--- a/t/articles/article.t
+++ b/t/articles/article.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/articles/articles.t b/t/articles/articles.t
index c6fe651..8d2918e 100644
--- a/t/articles/articles.t
+++ b/t/articles/articles.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/articles/basic-api.t b/t/articles/basic-api.t
index f9f9f89..168b8cb 100644
--- a/t/articles/basic-api.t
+++ b/t/articles/basic-api.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/articles/cfsearch.t b/t/articles/cfsearch.t
index 49420e5..3bfa667 100644
--- a/t/articles/cfsearch.t
+++ b/t/articles/cfsearch.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/articles/class.t b/t/articles/class.t
index 886ad38..3ada648 100644
--- a/t/articles/class.t
+++ b/t/articles/class.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/articles/interface.t b/t/articles/interface.t
index d04be8b..85782bf 100644
--- a/t/articles/interface.t
+++ b/t/articles/interface.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/articles/queue-specific-class.t b/t/articles/queue-specific-class.t
index 38159e7..903e9c0 100644
--- a/t/articles/queue-specific-class.t
+++ b/t/articles/queue-specific-class.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/articles/search-interface.t b/t/articles/search-interface.t
index eb3a4f7..74b398e 100644
--- a/t/articles/search-interface.t
+++ b/t/articles/search-interface.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/articles/upload-customfields.t b/t/articles/upload-customfields.t
index 912c23d..e5ed5d1 100644
--- a/t/articles/upload-customfields.t
+++ b/t/articles/upload-customfields.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/articles/uri-a.t b/t/articles/uri-a.t
index 82d0f1b..70b59b0 100644
--- a/t/articles/uri-a.t
+++ b/t/articles/uri-a.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/articles/uri-articles.t b/t/articles/uri-articles.t
index 4124b19..b6a1c8d 100644
--- a/t/articles/uri-articles.t
+++ b/t/articles/uri-articles.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/customfields/access_via_queue.t b/t/customfields/access_via_queue.t
index 690e177..cca45e7 100644
--- a/t/customfields/access_via_queue.t
+++ b/t/customfields/access_via_queue.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/customfields/api.t b/t/customfields/api.t
index d739a57..1edc9e8 100644
--- a/t/customfields/api.t
+++ b/t/customfields/api.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings FATAL => 'all';
diff --git a/t/customfields/combo_cascade.t b/t/customfields/combo_cascade.t
index 28eee45..fba2fac 100644
--- a/t/customfields/combo_cascade.t
+++ b/t/customfields/combo_cascade.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/customfields/date_search.t b/t/customfields/date_search.t
index b425b9e..6d7bfd0 100644
--- a/t/customfields/date_search.t
+++ b/t/customfields/date_search.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/customfields/datetime_search.t b/t/customfields/datetime_search.t
index 11fe3bc..707610b 100644
--- a/t/customfields/datetime_search.t
+++ b/t/customfields/datetime_search.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/customfields/external.t b/t/customfields/external.t
index 0abf6ec..62c2cef 100644
--- a/t/customfields/external.t
+++ b/t/customfields/external.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/customfields/ip.t b/t/customfields/ip.t
index f73e63f..1e39e2c 100644
--- a/t/customfields/ip.t
+++ b/t/customfields/ip.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/customfields/iprange.t b/t/customfields/iprange.t
index 118d23c..af9a52f 100644
--- a/t/customfields/iprange.t
+++ b/t/customfields/iprange.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/customfields/iprangev6.t b/t/customfields/iprangev6.t
index d823dd6..3b8a4d6 100644
--- a/t/customfields/iprangev6.t
+++ b/t/customfields/iprangev6.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/customfields/ipv6.t b/t/customfields/ipv6.t
index 09c4d30..0d4075f 100644
--- a/t/customfields/ipv6.t
+++ b/t/customfields/ipv6.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/customfields/pattern.t b/t/customfields/pattern.t
index 7d1090f..2fccb45 100644
--- a/t/customfields/pattern.t
+++ b/t/customfields/pattern.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/customfields/single_values.t b/t/customfields/single_values.t
index 15a0016..42ba479 100644
--- a/t/customfields/single_values.t
+++ b/t/customfields/single_values.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/customfields/sort_order.t b/t/customfields/sort_order.t
index 2453a7c..ba0b654 100644
--- a/t/customfields/sort_order.t
+++ b/t/customfields/sort_order.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/customfields/transaction.t b/t/customfields/transaction.t
index 22f8459..f2e660e 100644
--- a/t/customfields/transaction.t
+++ b/t/customfields/transaction.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/fts/indexed_mysql.t b/t/fts/indexed_mysql.t
index f0395a5..d5012af 100644
--- a/t/fts/indexed_mysql.t
+++ b/t/fts/indexed_mysql.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/fts/indexed_oracle.t b/t/fts/indexed_oracle.t
index 5d71712..98db304 100644
--- a/t/fts/indexed_oracle.t
+++ b/t/fts/indexed_oracle.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/fts/indexed_pg.t b/t/fts/indexed_pg.t
index ea5cad1..c73b4fb 100644
--- a/t/fts/indexed_pg.t
+++ b/t/fts/indexed_pg.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/fts/not_indexed.t b/t/fts/not_indexed.t
index 0a1abd0..9ec77eb 100644
--- a/t/fts/not_indexed.t
+++ b/t/fts/not_indexed.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/i18n/caching.t b/t/i18n/caching.t
index ebb2942..f3d1b01 100644
--- a/t/i18n/caching.t
+++ b/t/i18n/caching.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/i18n/default.t b/t/i18n/default.t
index 6c26b62..ea0848f 100644
--- a/t/i18n/default.t
+++ b/t/i18n/default.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/i18n/footer.t b/t/i18n/footer.t
index e0d0905..5fb8ed4 100644
--- a/t/i18n/footer.t
+++ b/t/i18n/footer.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/lifecycles/basics.t b/t/lifecycles/basics.t
index 2f3d55a..c521bf0 100644
--- a/t/lifecycles/basics.t
+++ b/t/lifecycles/basics.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/lifecycles/dates.t b/t/lifecycles/dates.t
index d8a27f6..4f613f8 100644
--- a/t/lifecycles/dates.t
+++ b/t/lifecycles/dates.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/lifecycles/moving.t b/t/lifecycles/moving.t
index 6e0d64b..5f184e2 100644
--- a/t/lifecycles/moving.t
+++ b/t/lifecycles/moving.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/lifecycles/utils.pl b/t/lifecycles/utils.pl
index 6fb2293..3813df3 100644
--- a/t/lifecycles/utils.pl
+++ b/t/lifecycles/utils.pl
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/mail/charsets-outgoing.t b/t/mail/charsets-outgoing.t
index e17dd98..2fc91f2 100644
--- a/t/mail/charsets-outgoing.t
+++ b/t/mail/charsets-outgoing.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
use Encode;
diff --git a/t/mail/crypt-gnupg.t b/t/mail/crypt-gnupg.t
index c0a8756..ffb0597 100644
--- a/t/mail/crypt-gnupg.t
+++ b/t/mail/crypt-gnupg.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/mail/dashboards.t b/t/mail/dashboards.t
index 31fe701..3de7a01 100644
--- a/t/mail/dashboards.t
+++ b/t/mail/dashboards.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/mail/digest-attributes.t b/t/mail/digest-attributes.t
index 5b45606..badd59b 100644
--- a/t/mail/digest-attributes.t
+++ b/t/mail/digest-attributes.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use warnings;
use strict;
diff --git a/t/mail/extractsubjecttag.t b/t/mail/extractsubjecttag.t
index c9f4615..f367606 100644
--- a/t/mail/extractsubjecttag.t
+++ b/t/mail/extractsubjecttag.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
use utf8;
diff --git a/t/mail/gateway.t b/t/mail/gateway.t
index 9f0e669..2b646cc 100644
--- a/t/mail/gateway.t
+++ b/t/mail/gateway.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
# BEGIN BPS TAGGED BLOCK {{{
#
# COPYRIGHT:
diff --git a/t/mail/gnupg-bad.t b/t/mail/gnupg-bad.t
index c9b28c9..a1c45be 100644
--- a/t/mail/gnupg-bad.t
+++ b/t/mail/gnupg-bad.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/mail/gnupg-incoming.t b/t/mail/gnupg-incoming.t
index e591add..2d5d5d9 100644
--- a/t/mail/gnupg-incoming.t
+++ b/t/mail/gnupg-incoming.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/mail/gnupg-outgoing-encrypted.t b/t/mail/gnupg-outgoing-encrypted.t
index 4f2a28f..96c7487 100644
--- a/t/mail/gnupg-outgoing-encrypted.t
+++ b/t/mail/gnupg-outgoing-encrypted.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/mail/gnupg-outgoing-plain.t b/t/mail/gnupg-outgoing-plain.t
index ee9a8ac..62ae0ed 100644
--- a/t/mail/gnupg-outgoing-plain.t
+++ b/t/mail/gnupg-outgoing-plain.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/mail/gnupg-outgoing-signed.t b/t/mail/gnupg-outgoing-signed.t
index 2ea20a2..4aa262b 100644
--- a/t/mail/gnupg-outgoing-signed.t
+++ b/t/mail/gnupg-outgoing-signed.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/mail/gnupg-outgoing-signed_encrypted.t b/t/mail/gnupg-outgoing-signed_encrypted.t
index 0b82cf1..806f62d 100644
--- a/t/mail/gnupg-outgoing-signed_encrypted.t
+++ b/t/mail/gnupg-outgoing-signed_encrypted.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/mail/gnupg-realmail.t b/t/mail/gnupg-realmail.t
index 7d1dbca..834014c 100644
--- a/t/mail/gnupg-realmail.t
+++ b/t/mail/gnupg-realmail.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/mail/gnupg-reverification.t b/t/mail/gnupg-reverification.t
index 96a37a0..939bf33 100644
--- a/t/mail/gnupg-reverification.t
+++ b/t/mail/gnupg-reverification.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/mail/gnupg-special.t b/t/mail/gnupg-special.t
index d001091..3e5bf91 100644
--- a/t/mail/gnupg-special.t
+++ b/t/mail/gnupg-special.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/mail/mime_decoding.t b/t/mail/mime_decoding.t
index e5449ef..d8e9af8 100644
--- a/t/mail/mime_decoding.t
+++ b/t/mail/mime_decoding.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
use RT::Test nodb => 1, tests => 7;
diff --git a/t/mail/multipart.t b/t/mail/multipart.t
index c37fb6a..77f76f2 100644
--- a/t/mail/multipart.t
+++ b/t/mail/multipart.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
# BEGIN BPS TAGGED BLOCK {{{
#
# COPYRIGHT:
diff --git a/t/mail/one-time-recipients.t b/t/mail/one-time-recipients.t
index 985f955..3484d14 100644
--- a/t/mail/one-time-recipients.t
+++ b/t/mail/one-time-recipients.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
use utf8;
diff --git a/t/mail/outlook.t b/t/mail/outlook.t
index 4a566a1..e055d43 100644
--- a/t/mail/outlook.t
+++ b/t/mail/outlook.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
# BEGIN BPS TAGGED BLOCK {{{
#
# COPYRIGHT:
diff --git a/t/mail/sendmail.t b/t/mail/sendmail.t
index bb5d2db..44903f3 100644
--- a/t/mail/sendmail.t
+++ b/t/mail/sendmail.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl -w
-
use strict;
+use warnings;
use File::Spec ();
use RT::Test tests => 141;
diff --git a/t/mail/verp.t b/t/mail/verp.t
index ed3af6a..a07f800 100644
--- a/t/mail/verp.t
+++ b/t/mail/verp.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl -w
-
use strict;
+use warnings;
use RT::Test nodb => 1, tests => 1;
TODO: {
todo_skip "No tests written for VERP yet", 1;
diff --git a/t/mail/wrong_mime_charset.t b/t/mail/wrong_mime_charset.t
index 511a7e6..530b5f3 100644
--- a/t/mail/wrong_mime_charset.t
+++ b/t/mail/wrong_mime_charset.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
use RT::Test nodb => 1, tests => 6;
diff --git a/t/shredder/00skeleton.t b/t/shredder/00skeleton.t
index eab9433..c23e064 100644
--- a/t/shredder/00skeleton.t
+++ b/t/shredder/00skeleton.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/01basics.t b/t/shredder/01basics.t
index 99e66c7..b0000b1 100644
--- a/t/shredder/01basics.t
+++ b/t/shredder/01basics.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/01ticket.t b/t/shredder/01ticket.t
index 7dff16d..9c290fa 100644
--- a/t/shredder/01ticket.t
+++ b/t/shredder/01ticket.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/02group_member.t b/t/shredder/02group_member.t
index 9f8a6c6..5952e1e 100644
--- a/t/shredder/02group_member.t
+++ b/t/shredder/02group_member.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/02queue.t b/t/shredder/02queue.t
index fb5e36d..7cfd378 100644
--- a/t/shredder/02queue.t
+++ b/t/shredder/02queue.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/02template.t b/t/shredder/02template.t
index 16fa615..4d0cd4f 100644
--- a/t/shredder/02template.t
+++ b/t/shredder/02template.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/02user.t b/t/shredder/02user.t
index 8c8657c..d97511d 100644
--- a/t/shredder/02user.t
+++ b/t/shredder/02user.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/03plugin.t b/t/shredder/03plugin.t
index cf51e44..4ba2fbf 100644
--- a/t/shredder/03plugin.t
+++ b/t/shredder/03plugin.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/03plugin_summary.t b/t/shredder/03plugin_summary.t
index 2744531..ec3b6e9 100644
--- a/t/shredder/03plugin_summary.t
+++ b/t/shredder/03plugin_summary.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/03plugin_tickets.t b/t/shredder/03plugin_tickets.t
index 092b570..2b7b8e3 100644
--- a/t/shredder/03plugin_tickets.t
+++ b/t/shredder/03plugin_tickets.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/03plugin_users.t b/t/shredder/03plugin_users.t
index 4f4ecc8..8f4d71d 100644
--- a/t/shredder/03plugin_users.t
+++ b/t/shredder/03plugin_users.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/shredder/utils.pl b/t/shredder/utils.pl
index b8409bf..ef9fc87 100644
--- a/t/shredder/utils.pl
+++ b/t/shredder/utils.pl
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/ticket/action_linear_escalate.t b/t/ticket/action_linear_escalate.t
index 2a1be61..0d1ff8a 100644
--- a/t/ticket/action_linear_escalate.t
+++ b/t/ticket/action_linear_escalate.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/ticket/add-watchers.t b/t/ticket/add-watchers.t
index e49c694..81fa7fc 100644
--- a/t/ticket/add-watchers.t
+++ b/t/ticket/add-watchers.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
# BEGIN BPS TAGGED BLOCK {{{
#
# COPYRIGHT:
diff --git a/t/ticket/badlinks.t b/t/ticket/badlinks.t
index 71ab739..6fac5d5 100644
--- a/t/ticket/badlinks.t
+++ b/t/ticket/badlinks.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
use RT::Test tests => 14;
diff --git a/t/ticket/batch-upload-csv.t b/t/ticket/batch-upload-csv.t
index cedc014..8dc906e 100644
--- a/t/ticket/batch-upload-csv.t
+++ b/t/ticket/batch-upload-csv.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
-use strict; use warnings;
+use strict;
+use warnings;
use RT::Test tests => 12;
use_ok('RT');
diff --git a/t/ticket/cfsort-freeform-multiple.t b/t/ticket/cfsort-freeform-multiple.t
index e285d0e..ba6150b 100644
--- a/t/ticket/cfsort-freeform-multiple.t
+++ b/t/ticket/cfsort-freeform-multiple.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use RT::Test nodata => 1, tests => 41;
diff --git a/t/ticket/cfsort-freeform-single.t b/t/ticket/cfsort-freeform-single.t
index 35a53fb..ae109e9 100644
--- a/t/ticket/cfsort-freeform-single.t
+++ b/t/ticket/cfsort-freeform-single.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use RT::Test nodata => 1, tests => 89;
diff --git a/t/ticket/clicky.t b/t/ticket/clicky.t
index 85e6690..ae49ccf 100644
--- a/t/ticket/clicky.t
+++ b/t/ticket/clicky.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/ticket/googleish_search.t b/t/ticket/googleish_search.t
index 5d7809a..966bcce 100644
--- a/t/ticket/googleish_search.t
+++ b/t/ticket/googleish_search.t
@@ -1,5 +1,4 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/ticket/link_search.t b/t/ticket/link_search.t
index dbcf4b4..9e5ed1c 100644
--- a/t/ticket/link_search.t
+++ b/t/ticket/link_search.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl -w
-
use strict;
+use warnings;
use RT;
# Load the config file
diff --git a/t/ticket/merge.t b/t/ticket/merge.t
index d06d541..2484b65 100644
--- a/t/ticket/merge.t
+++ b/t/ticket/merge.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/ticket/requestor-order.t b/t/ticket/requestor-order.t
index bdacc46..d8308d3 100644
--- a/t/ticket/requestor-order.t
+++ b/t/ticket/requestor-order.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
-use strict; use warnings;
+use strict;
+use warnings;
use RT::Test tests => 58;
use_ok('RT');
diff --git a/t/ticket/search.t b/t/ticket/search.t
index fd0a7e0..35e5948 100644
--- a/t/ticket/search.t
+++ b/t/ticket/search.t
@@ -1,4 +1,3 @@
-#!/opt/perl/bin/perl -w
# tests relating to searching. Especially around custom fields, and
# corner cases.
diff --git a/t/ticket/search_by_cf_freeform_multiple.t b/t/ticket/search_by_cf_freeform_multiple.t
index 4e7cddc..1b4f092 100644
--- a/t/ticket/search_by_cf_freeform_multiple.t
+++ b/t/ticket/search_by_cf_freeform_multiple.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/ticket/search_by_cf_freeform_single.t b/t/ticket/search_by_cf_freeform_single.t
index 278a3ce..f8462a9 100644
--- a/t/ticket/search_by_cf_freeform_single.t
+++ b/t/ticket/search_by_cf_freeform_single.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/ticket/search_by_links.t b/t/ticket/search_by_links.t
index 61b69b7..d25d300 100644
--- a/t/ticket/search_by_links.t
+++ b/t/ticket/search_by_links.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/ticket/search_by_txn.t b/t/ticket/search_by_txn.t
index 0e5f76d..6f970aa 100644
--- a/t/ticket/search_by_txn.t
+++ b/t/ticket/search_by_txn.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use warnings;
use strict;
diff --git a/t/ticket/search_by_watcher.t b/t/ticket/search_by_watcher.t
index 809450b..321ee7d 100644
--- a/t/ticket/search_by_watcher.t
+++ b/t/ticket/search_by_watcher.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/ticket/search_long_cf_values.t b/t/ticket/search_long_cf_values.t
index 6ce8505..5b904b3 100644
--- a/t/ticket/search_long_cf_values.t
+++ b/t/ticket/search_long_cf_values.t
@@ -1,4 +1,3 @@
-#!/opt/perl/bin/perl -w
# tests relating to searching. Especially around custom fields with long values
# (> 255 chars)
diff --git a/t/ticket/sort-by-custom-ownership.t b/t/ticket/sort-by-custom-ownership.t
index b06e9a0..80e88a8 100644
--- a/t/ticket/sort-by-custom-ownership.t
+++ b/t/ticket/sort-by-custom-ownership.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use RT;
use RT::Test nodata => 1, tests => 7;
diff --git a/t/ticket/sort-by-queue.t b/t/ticket/sort-by-queue.t
index bf2934b..f54ccf7 100644
--- a/t/ticket/sort-by-queue.t
+++ b/t/ticket/sort-by-queue.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use RT::Test nodata => 1, tests => 12;
diff --git a/t/ticket/sort-by-user.t b/t/ticket/sort-by-user.t
index 10d43de..42f95fc 100644
--- a/t/ticket/sort-by-user.t
+++ b/t/ticket/sort-by-user.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use RT::Test nodata => 1, tests => 52;
diff --git a/t/ticket/sort_by_cf.t b/t/ticket/sort_by_cf.t
index 65704da..30f6ad8 100644
--- a/t/ticket/sort_by_cf.t
+++ b/t/ticket/sort_by_cf.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use RT::Test nodata => 1, tests => 21;
RT::Init();
diff --git a/t/validator/group_members.t b/t/validator/group_members.t
index 7818014..fbe7580 100644
--- a/t/validator/group_members.t
+++ b/t/validator/group_members.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/web/admin_groups.t b/t/web/admin_groups.t
index 783b5ad..075fb62 100644
--- a/t/web/admin_groups.t
+++ b/t/web/admin_groups.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/admin_user.t b/t/web/admin_user.t
index fde075f..24156a9 100644
--- a/t/web/admin_user.t
+++ b/t/web/admin_user.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/attachment_encoding.t b/t/web/attachment_encoding.t
index 2fe8200..e0b2acc 100644
--- a/t/web/attachment_encoding.t
+++ b/t/web/attachment_encoding.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/attachments.t b/t/web/attachments.t
index 6f175f6..d46bef6 100644
--- a/t/web/attachments.t
+++ b/t/web/attachments.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test tests => 16;
diff --git a/t/web/basic.t b/t/web/basic.t
index 31e28c4..e61e80e 100644
--- a/t/web/basic.t
+++ b/t/web/basic.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/cf_access.t b/t/web/cf_access.t
index 0eaf7b3..9dc3c59 100644
--- a/t/web/cf_access.t
+++ b/t/web/cf_access.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test tests => 25;
diff --git a/t/web/cf_date.t b/t/web/cf_date.t
index 887aa42..4ea93e4 100644
--- a/t/web/cf_date.t
+++ b/t/web/cf_date.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/cf_datetime.t b/t/web/cf_datetime.t
index 9781c5e..8cc099d 100644
--- a/t/web/cf_datetime.t
+++ b/t/web/cf_datetime.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/cf_onqueue.t b/t/web/cf_onqueue.t
index 422eeff..bd6ae66 100644
--- a/t/web/cf_onqueue.t
+++ b/t/web/cf_onqueue.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test tests => 14;
my ($baseurl, $m) = RT::Test->started_ok;
diff --git a/t/web/cf_select_one.t b/t/web/cf_select_one.t
index 15fe416..92fcf53 100644
--- a/t/web/cf_select_one.t
+++ b/t/web/cf_select_one.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/clickjacking-preventions.t b/t/web/clickjacking-preventions.t
index dde8295..e3f7f44 100644
--- a/t/web/clickjacking-preventions.t
+++ b/t/web/clickjacking-preventions.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/command_line.t b/t/web/command_line.t
index 1fed8e6..5dbd445 100644
--- a/t/web/command_line.t
+++ b/t/web/command_line.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl -w
-
use strict;
+use warnings;
use File::Spec ();
use Test::Expect;
use RT::Test tests => 303, actual_server => 1;
diff --git a/t/web/command_line_with_unknown_field.t b/t/web/command_line_with_unknown_field.t
index 736be4d..6856cc9 100644
--- a/t/web/command_line_with_unknown_field.t
+++ b/t/web/command_line_with_unknown_field.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl -w
-
use strict;
+use warnings;
use File::Spec ();
use Test::Expect;
use RT::Test tests => 14, actual_server => 1;
diff --git a/t/web/compilation_errors.t b/t/web/compilation_errors.t
index 1f82ab9..5e3ef58 100644
--- a/t/web/compilation_errors.t
+++ b/t/web/compilation_errors.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl
-
use strict;
+use warnings;
use Test::More;
use File::Find;
BEGIN {
diff --git a/t/web/config_tab_right.t b/t/web/config_tab_right.t
index 361506c..69bf80c 100644
--- a/t/web/config_tab_right.t
+++ b/t/web/config_tab_right.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/web/crypt-gnupg.t b/t/web/crypt-gnupg.t
index 6bdefda..6f7aba1 100644
--- a/t/web/crypt-gnupg.t
+++ b/t/web/crypt-gnupg.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test::GnuPG
tests => 102,
diff --git a/t/web/custom_frontpage.t b/t/web/custom_frontpage.t
index 43c5f6e..8db89a5 100644
--- a/t/web/custom_frontpage.t
+++ b/t/web/custom_frontpage.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test tests => 12;
my ($baseurl, $m) = RT::Test->started_ok;
diff --git a/t/web/custom_search.t b/t/web/custom_search.t
index f8fde25..bf7d659 100644
--- a/t/web/custom_search.t
+++ b/t/web/custom_search.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test tests => 13;
my ($baseurl, $m) = RT::Test->started_ok;
diff --git a/t/web/dashboards-basics.t b/t/web/dashboards-basics.t
index 1d56da5..edb7068 100644
--- a/t/web/dashboards-basics.t
+++ b/t/web/dashboards-basics.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test tests => 122;
my ($baseurl, $m) = RT::Test->started_ok;
diff --git a/t/web/dashboards-deleted-saved-search.t b/t/web/dashboards-deleted-saved-search.t
index 4cd7fea..cb96aca 100644
--- a/t/web/dashboards-deleted-saved-search.t
+++ b/t/web/dashboards-deleted-saved-search.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/dashboards-groups.t b/t/web/dashboards-groups.t
index ac2a5ac..db2fccf 100644
--- a/t/web/dashboards-groups.t
+++ b/t/web/dashboards-groups.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test nodata => 1, tests => 64;
my ($baseurl, $m) = RT::Test->started_ok;
diff --git a/t/web/dashboards-permissions.t b/t/web/dashboards-permissions.t
index f2e59e5..433fdd3 100644
--- a/t/web/dashboards-permissions.t
+++ b/t/web/dashboards-permissions.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/dashboards-search-cache.t b/t/web/dashboards-search-cache.t
index ad2a969..517e26e 100644
--- a/t/web/dashboards-search-cache.t
+++ b/t/web/dashboards-search-cache.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test tests => 20;
my ($baseurl, $m) = RT::Test->started_ok;
diff --git a/t/web/gnupg-headers.t b/t/web/gnupg-headers.t
index 88b3ab9..03e6090 100644
--- a/t/web/gnupg-headers.t
+++ b/t/web/gnupg-headers.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test::GnuPG
tests => 15,
diff --git a/t/web/gnupg-select-keys-on-create.t b/t/web/gnupg-select-keys-on-create.t
index cf27e48..893ae65 100644
--- a/t/web/gnupg-select-keys-on-create.t
+++ b/t/web/gnupg-select-keys-on-create.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/web/gnupg-select-keys-on-update.t b/t/web/gnupg-select-keys-on-update.t
index 4842dcd..1509d1d 100644
--- a/t/web/gnupg-select-keys-on-update.t
+++ b/t/web/gnupg-select-keys-on-update.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/web/gnupg-tickyboxes.t b/t/web/gnupg-tickyboxes.t
index 9445397..eb4388a 100644
--- a/t/web/gnupg-tickyboxes.t
+++ b/t/web/gnupg-tickyboxes.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/web/googleish_search.t b/t/web/googleish_search.t
index e2a4e91..ce2ab65 100644
--- a/t/web/googleish_search.t
+++ b/t/web/googleish_search.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/html_template.t b/t/web/html_template.t
index 662a26b..4e7bc29 100644
--- a/t/web/html_template.t
+++ b/t/web/html_template.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/logout.t b/t/web/logout.t
index 889e5fc..73ff25c 100644
--- a/t/web/logout.t
+++ b/t/web/logout.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/offline_messages_utf8.t b/t/web/offline_messages_utf8.t
index 582cc27..8cfb8c9 100644
--- a/t/web/offline_messages_utf8.t
+++ b/t/web/offline_messages_utf8.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/offline_utf8.t b/t/web/offline_utf8.t
index 4eb3953..c5278d3 100644
--- a/t/web/offline_utf8.t
+++ b/t/web/offline_utf8.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/passthrough-jsmin b/t/web/passthrough-jsmin
index 3d9bf01..41b0196 100755
--- a/t/web/passthrough-jsmin
+++ b/t/web/passthrough-jsmin
@@ -1,4 +1,3 @@
-#!/bin/sh
echo "// passthrough-jsmin added this";
diff --git a/t/web/private-components.t b/t/web/private-components.t
index ceb2b34..3ece854 100644
--- a/t/web/private-components.t
+++ b/t/web/private-components.t
@@ -1,4 +1,5 @@
use strict;
+use warnings;
use RT::Test tests => 24;
my ($baseurl, $agent) = RT::Test->started_ok;
diff --git a/t/web/query_builder.t b/t/web/query_builder.t
index 0abbfac..73ef7f0 100644
--- a/t/web/query_builder.t
+++ b/t/web/query_builder.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl
-
use strict;
+use warnings;
use HTTP::Request::Common;
use HTTP::Cookies;
use LWP;
diff --git a/t/web/query_log.t b/t/web/query_log.t
index e19f44d..89cca2d 100644
--- a/t/web/query_log.t
+++ b/t/web/query_log.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/quickcreate.t b/t/web/quickcreate.t
index b257f9d..c49ad8c 100644
--- a/t/web/quickcreate.t
+++ b/t/web/quickcreate.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/quicksearch.t b/t/web/quicksearch.t
index 8cc084c..922dc31 100644
--- a/t/web/quicksearch.t
+++ b/t/web/quicksearch.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/redirect-after-login.t b/t/web/redirect-after-login.t
index d429d30..1ebb40e 100644
--- a/t/web/redirect-after-login.t
+++ b/t/web/redirect-after-login.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/reminders.t b/t/web/reminders.t
index 32e130c..b07aefc 100644
--- a/t/web/reminders.t
+++ b/t/web/reminders.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
use RT::Test tests => 35;
diff --git a/t/web/requestor_groups_edit_link.t b/t/web/requestor_groups_edit_link.t
index 9d1fefd..cf67311 100644
--- a/t/web/requestor_groups_edit_link.t
+++ b/t/web/requestor_groups_edit_link.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/requestor_groups_limit.t b/t/web/requestor_groups_limit.t
index 7987a13..abc21ca 100644
--- a/t/web/requestor_groups_limit.t
+++ b/t/web/requestor_groups_limit.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/rest-non-ascii-subject.t b/t/web/rest-non-ascii-subject.t
index d7a89af..8b870a8 100644
--- a/t/web/rest-non-ascii-subject.t
+++ b/t/web/rest-non-ascii-subject.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
# Test ticket creation with REST using non ascii subject
use strict;
use warnings;
diff --git a/t/web/rest-sort.t b/t/web/rest-sort.t
index 6b4d351..5ddaa8e 100644
--- a/t/web/rest-sort.t
+++ b/t/web/rest-sort.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
use RT::Test tests => 25;
diff --git a/t/web/rest.t b/t/web/rest.t
index 5e7194c..c8ab920 100644
--- a/t/web/rest.t
+++ b/t/web/rest.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
use RT::Test tests => 18;
diff --git a/t/web/richtext-autohandler.t b/t/web/richtext-autohandler.t
index 734426f..724a7b3 100644
--- a/t/web/richtext-autohandler.t
+++ b/t/web/richtext-autohandler.t
@@ -1,4 +1,5 @@
use strict;
+use warnings;
use RT::Test tests => 9;
my ($baseurl, $agent) = RT::Test->started_ok;
diff --git a/t/web/rights.t b/t/web/rights.t
index 9a5f358..23b357f 100644
--- a/t/web/rights.t
+++ b/t/web/rights.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
use strict;
use warnings;
diff --git a/t/web/rights1.t b/t/web/rights1.t
index 24e5c34..63ddb38 100644
--- a/t/web/rights1.t
+++ b/t/web/rights1.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use HTTP::Cookies;
use RT::Test nodata => 1, tests => 31;
diff --git a/t/web/saved_search_chart.t b/t/web/saved_search_chart.t
index 2821f07..376fe4d 100644
--- a/t/web/saved_search_chart.t
+++ b/t/web/saved_search_chart.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/saved_search_permissions.t b/t/web/saved_search_permissions.t
index 5cae30b..f61c931 100644
--- a/t/web/saved_search_permissions.t
+++ b/t/web/saved_search_permissions.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/saved_search_update.t b/t/web/saved_search_update.t
index dfb18d4..f06f70f 100644
--- a/t/web/saved_search_update.t
+++ b/t/web/saved_search_update.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/scrub.t b/t/web/scrub.t
index 6483a75..a710eb0 100644
--- a/t/web/scrub.t
+++ b/t/web/scrub.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/search_bulk_update_links.t b/t/web/search_bulk_update_links.t
index 7d150a6..ffe2efe 100644
--- a/t/web/search_bulk_update_links.t
+++ b/t/web/search_bulk_update_links.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/search_rss.t b/t/web/search_rss.t
index 95de931..9a53a8d 100644
--- a/t/web/search_rss.t
+++ b/t/web/search_rss.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl
-
use strict;
+use warnings;
use RT::Test tests => 38;
my ($baseurl, $agent) = RT::Test->started_ok;
diff --git a/t/web/search_tabs.t b/t/web/search_tabs.t
index 3cd8f8b..7299a99 100644
--- a/t/web/search_tabs.t
+++ b/t/web/search_tabs.t
@@ -1,6 +1,6 @@
-#!/usr/bin/perl
-
use strict;
+use warnings;
+
use RT::Test tests => 7;
my ($baseurl, $agent) = RT::Test->started_ok;
diff --git a/t/web/template.t b/t/web/template.t
index 40a5366..a24f741 100644
--- a/t/web/template.t
+++ b/t/web/template.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/ticket-create-utf8.t b/t/web/ticket-create-utf8.t
index 8d36bd1..bebc57b 100644
--- a/t/web/ticket-create-utf8.t
+++ b/t/web/ticket-create-utf8.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/ticket_forward.t b/t/web/ticket_forward.t
index c8205be..90bd3b5 100644
--- a/t/web/ticket_forward.t
+++ b/t/web/ticket_forward.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/ticket_owner.t b/t/web/ticket_owner.t
index 4db39e6..8150853 100644
--- a/t/web/ticket_owner.t
+++ b/t/web/ticket_owner.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/ticket_owner_autocomplete.t b/t/web/ticket_owner_autocomplete.t
index 3aa3f28..040aa73 100644
--- a/t/web/ticket_owner_autocomplete.t
+++ b/t/web/ticket_owner_autocomplete.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/ticket_owner_issues_16656.t b/t/web/ticket_owner_issues_16656.t
index a6306f7..c9fc783 100644
--- a/t/web/ticket_owner_issues_16656.t
+++ b/t/web/ticket_owner_issues_16656.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/ticket_seen.t b/t/web/ticket_seen.t
index 8dacaf5..e40782f 100644
--- a/t/web/ticket_seen.t
+++ b/t/web/ticket_seen.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
diff --git a/t/web/ticket_txn_content.t b/t/web/ticket_txn_content.t
index 06ea7e7..e1df805 100644
--- a/t/web/ticket_txn_content.t
+++ b/t/web/ticket_txn_content.t
@@ -1,5 +1,5 @@
-#!/usr/bin/perl -w
use strict;
+use warnings;
use RT::Test tests => 63;
use File::Temp 'tempfile';
diff --git a/t/web/ticket_update_without_content.t b/t/web/ticket_update_without_content.t
index 54f0c5a..b4247ab 100644
--- a/t/web/ticket_update_without_content.t
+++ b/t/web/ticket_update_without_content.t
@@ -1,4 +1,3 @@
-#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/t/web/unlimited_search.t b/t/web/unlimited_search.t
index 988a291..6a5f697 100644
--- a/t/web/unlimited_search.t
+++ b/t/web/unlimited_search.t
@@ -1,6 +1,5 @@
-#!/usr/bin/perl
-
use strict;
+use warnings;
use RT::Test tests => 85;
my ($baseurl, $agent) = RT::Test->started_ok;
diff --git a/t/web/user_update.t b/t/web/user_update.t
index dc908fc..d5751ab 100644
--- a/t/web/user_update.t
+++ b/t/web/user_update.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
use utf8;
diff --git a/t/web/walk.t b/t/web/walk.t
index 34fab14..97aa36e 100644
--- a/t/web/walk.t
+++ b/t/web/walk.t
@@ -1,4 +1,3 @@
-#!/usr/bin/perl
use strict;
use warnings;
commit bf8618d2c9a6578fb1089efa86aeabcc09a7e1bf
Author: sunnavy <sunnavy at bestpractical.com>
Date: Mon Aug 22 11:35:02 2011 +0800
test and fix devel tools to meet code policy too
diff --git a/devel/tools/factory b/devel/tools/factory
index d561989..8b3fbbd 100755
--- a/devel/tools/factory
+++ b/devel/tools/factory
@@ -47,6 +47,7 @@
#
# END BPS TAGGED BLOCK }}}
use strict;
+use warnings;
use DBI;
die "Usage: $0 database namespace" if @ARGV != 2;
diff --git a/devel/tools/license_tag b/devel/tools/license_tag
index d85c958..d2b3df2 100755
--- a/devel/tools/license_tag
+++ b/devel/tools/license_tag
@@ -48,6 +48,8 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
+use strict;
+use warnings;
my $LICENSE = <<'EOL';
COPYRIGHT:
diff --git a/devel/tools/merge-rosetta.pl b/devel/tools/merge-rosetta.pl
old mode 100644
new mode 100755
index cb97cc1..ee5a762
--- a/devel/tools/merge-rosetta.pl
+++ b/devel/tools/merge-rosetta.pl
@@ -46,4 +46,6 @@
# those contributions and any derivatives thereof.
#
# END BPS TAGGED BLOCK }}}
+use strict;
+use warnings;
exec('sbin/rt-message-catalog', 'rosetta', @ARGV);
diff --git a/devel/tools/tweak-template-locstring b/devel/tools/tweak-template-locstring
old mode 100644
new mode 100755
index 729ac1f..ffb1e36
--- a/devel/tools/tweak-template-locstring
+++ b/devel/tools/tweak-template-locstring
@@ -47,6 +47,7 @@
#
# END BPS TAGGED BLOCK }}}
use strict;
+use warnings;
# run this script with:
# perl -0pi sbin/tweak-template-locstring `ack -f share/html -G 'html$'`
s!\<\&\|\/l([^&]*)\&\>[\n\s]+(.*?)[\n\s]*\<\/\&\>!;my ($arg, $x) = ($1, $2); $x =~ s/\s*\n\s*/ /g;"<&|/l$arg&>$x</&>"!smge;
diff --git a/t/99-policy.t b/t/99-policy.t
index b65b9c3..98a6529 100644
--- a/t/99-policy.t
+++ b/t/99-policy.t
@@ -31,6 +31,14 @@ sub check {
is( $mode, '0754', $File::Find::name . ' permission is 0754' );
}
}
+ elsif ( $type eq 'devel' ) {
+ like(
+ $content,
+ qr{^#!/usr/bin/env perl},
+ $File::Find::name . ' has shebang'
+ );
+ is( $mode, '0755', $File::Find::name . ' permission is 0755' );
+ }
else {
unlike( $content, qr/^#!/, $File::Find::name . ' has no shebang' );
is( $mode, '0644', $File::Find::name . ' permission is 0644' );
@@ -59,6 +67,13 @@ find(
check( $_, 'script' );
},
'bin',
- 'sbin'
+ 'sbin',
);
+find(
+ sub {
+ return unless -f && $_ !~ /\.conf$/;
+ check( $_, 'devel' );
+ },
+ 'devel/tools',
+);
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list