[Rt-commit] rt branch, 4.0/cf-cascaded-options-fix, created. rt-4.0.4-144-gf258108

? sunnavy sunnavy at bestpractical.com
Mon Dec 19 23:47:55 EST 2011


The branch, 4.0/cf-cascaded-options-fix has been created
        at  f258108601329f4d2365b4b2b1f464247b3ae713 (commit)

- Log -----------------------------------------------------------------
commit f258108601329f4d2365b4b2b1f464247b3ae713
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Dec 20 11:14:29 2011 +0800

    always show cf no-category options on firefox8/chrome15
    
    On firefox8/chrome15, option.label is not always the same as
    option.getAttribute('label'), which makes no-category options invisible when a
    category is selected.
    
    e.g. "(no value)" option doesn't have a label attribute, but ".label"
    returns "(no value)"
    
    see also #18983

diff --git a/share/html/NoAuth/js/cascaded.js b/share/html/NoAuth/js/cascaded.js
index d7110d5..e2bdaea 100644
--- a/share/html/NoAuth/js/cascaded.js
+++ b/share/html/NoAuth/js/cascaded.js
@@ -75,6 +75,8 @@ function filter_cascade (id, val) {
         else {
             for (i in complete_children) {
                 if (!complete_children[i].label ||
+                      (complete_children[i].hasAttribute &&
+                            !complete_children[i].hasAttribute('label') ) ||
                         complete_children[i].label.substr(0, val.length) == val ) {
                     if ( complete_children[i].cloneNode ) {
                         new_option = complete_children[i].cloneNode(true);

-----------------------------------------------------------------------


More information about the Rt-commit mailing list