[Rt-commit] rt branch, 4.2/queue-summary-refactoring, updated. rt-4.0.0rc4-29-g67cd856

Ruslan Zakirov ruz at bestpractical.com
Tue Feb 1 16:21:10 EST 2011


The branch, 4.2/queue-summary-refactoring has been updated
       via  67cd856d599af200f4c65db95b555f879a749773 (commit)
       via  764ff02151d97021305e5c7c5545a7879e6a43db (commit)
       via  dbda3478e86052f3c28b25b79d26d9a58966f53e (commit)
       via  2c5b795cd9d2319c6feaed5c81e06d233dfad171 (commit)
       via  e4e5b09ba4c6fee57482f311cb37eb2184454571 (commit)
      from  ece2ee525e7002ee235d71619bc03cbb2c854f01 (commit)

Summary of changes:
 lib/RT/SQL.pm                               |    7 ++
 share/html/Elements/MyAdminQueues           |   12 +++-
 share/html/Elements/MySupportQueues         |   12 +++-
 share/html/Elements/QueueSummary            |   74 ++++++++++++++++++++
 share/html/Elements/QueueSummaryByLifecycle |  100 ++++++++++-----------------
 share/html/Elements/QueueSummaryByStatus    |   61 ++--------------
 share/html/Elements/Quicksearch             |   14 +---
 share/html/Elements/Tabs                    |    1 -
 share/html/Prefs/QueueSummary.html          |   89 +++++++++++++++++-------
 9 files changed, 212 insertions(+), 158 deletions(-)
 create mode 100644 share/html/Elements/QueueSummary

- Log -----------------------------------------------------------------
commit e4e5b09ba4c6fee57482f311cb37eb2184454571
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Wed Feb 2 00:15:38 2011 +0300

    RT::SQL->Quote helper

diff --git a/lib/RT/SQL.pm b/lib/RT/SQL.pm
index 4f2c00d..67acfa0 100644
--- a/lib/RT/SQL.pm
+++ b/lib/RT/SQL.pm
@@ -217,6 +217,13 @@ sub _BitmaskToString {
     return join ' or ', @res;
 }
 
+sub Quote {
+    my $v = defined(wantarray)? \"$_[1]" : \$_[1];
+    $$v =~ s{(['\\])}{\\$1}g;
+    $$v = "'$$v'";
+    return $$v;
+}
+
 sub PossibleCustomFields {
     my %args = (Query => undef, CurrentUser => undef, @_);
 

commit 2c5b795cd9d2319c6feaed5c81e06d233dfad171
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Wed Feb 2 00:16:45 2011 +0300

    merge common code in QueueSummary* into /Elements/QueueSummary

diff --git a/share/html/Elements/QueueSummary b/share/html/Elements/QueueSummary
new file mode 100644
index 0000000..50c04c0
--- /dev/null
+++ b/share/html/Elements/QueueSummary
@@ -0,0 +1,74 @@
+<%INIT>
+$queues ||= RT::Queues->new( $session{'CurrentUser'} );
+$queues->UnLimit unless $queues->_isLimited;
+
+$m->callback( CallbackName => 'SQLFilter', Queues => $queues );
+
+my @queues = $queue_filter
+    ? grep $queue_filter->($_), @{ $queues->ItemsArrayRef }
+    : @{ $queues->ItemsArrayRef }
+;
+$m->callback( CallbackName => 'Filter', Queues => \@queues );
+
+$preference = $preference
+    ? $session{'CurrentUser'}->UserObj->Preferences($preference, {})
+    : {}
+;
+
+my $comp = '/Elements/QueueSummaryByStatus';
+if ( $preference->{'SplitByLifecycle'} ) {
+    $comp = '/Elements/QueueSummaryByLifecycle';
+}
+if ( $preference->{'Unwanted'} && keys %{ $preference->{'Unwanted'} } ) {
+    @queues = grep !$preference->{'Unwanted'}{ $_->Name }, @queues;
+}
+
+return $m->comp( $comp ) unless @queues;
+
+my %lifecycle = map { lc $_->Name => $_ } map $_->Lifecycle, @queues;
+
+unless (@statuses) {
+    my %seen;
+    foreach my $set ( 'initial', 'active' ) {
+        foreach my $lifecycle ( map $lifecycle{$_}, sort keys %lifecycle ) {
+            push @statuses, grep !$seen{ lc $_ }++, $lifecycle->Valid($set);
+        }
+    }
+}
+
+use RT::Report::Tickets;
+my $report = RT::Report::Tickets->new( RT->SystemUser );
+my $query =
+    '('. join(" OR ", map "Status = $_", map RT::SQL->Quote($_), @statuses) .')'
+    .' AND ('. join(' OR ', map "Queue = ". $_->id, @queues) .')';
+$report->SetupGroupings( Query => $query, GroupBy => [qw(Status Queue)] );
+
+my (%data, %data_has_status);
+while ( my $entry = $report->Next ) {
+    my ($queue, $status, $count) = map $entry->__Value($_), qw(Queue Status id);
+
+    $data{ $queue }{ $status } = $count;
+    $data{ $queue }{''} += $count;
+    $data_has_status{ $status } = 1;
+}
+
+unless ( $preference->{'ShowEmptyColumns'} ) {
+    @statuses = grep $data_has_status{$_}, @statuses;
+}
+unless ( $preference->{'ShowEmptyRows'} ) {
+    @queues = grep $data{ $_->id }{''}, @queues;
+}
+
+return $m->comp(
+    $comp,
+    queues   => \@queues,
+    statuses => \@statuses,
+    data     => \%data,
+);
+</%INIT>
+<%ARGS>
+$queues => undef
+$queue_filter => undef
+$preference => undef,
+ at statuses => ()
+</%ARGS>
diff --git a/share/html/Elements/QueueSummaryByLifecycle b/share/html/Elements/QueueSummaryByLifecycle
index ddb6234..65366fe 100644
--- a/share/html/Elements/QueueSummaryByLifecycle
+++ b/share/html/Elements/QueueSummaryByLifecycle
@@ -45,41 +45,41 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
+<table border="0" cellspacing="0" cellpadding="1" width="100%" class="queue-summary">
+
 <%perl>
-    foreach my $lifecycle ( map $lifecycle{$_}, sort keys %lifecycle ) {
-    my @cur_statuses = grep $lifecycle->IsValid($_), @statuses;
-    next unless @cur_statuses;
-</%perl>
+my $i = 0;
 
-<table border="0" cellspacing="0" cellpadding="1" width="100%" class="queue-summary">
+foreach my $group ( map $groups{$_}, sort keys %groups ) {
+    my @statuses = @{ $group->{'statuses'} };
+</%perl>
 
 <tr>
     <th class="collection-as-table"><&|/l&>Queue</&></th>
-% for my $status ( @cur_statuses ) {
+% for my $status ( @statuses ) {
     <th class="collection-as-table"><% loc($status) %></th>
 % }
+% for ( 1 .. ($max - @statuses) ) {
+    <th class="collection-as-table">&nbsp;</th>
+% }
 </tr>
 
 <%PERL>
-my $i = 0;
-for my $queue (@queues) {
-    next if lc($queue->{Lifecycle} || '') ne lc $lifecycle->Name;
-
+for my $queue (@{ $group->{'queues'} }) {
     $i++;
-    my $name = $queue->{Name};
-    $name =~ s/'/\\'/g;
-    my $queue_cond = "Queue = '$name' AND ";
-    my $all_q = $queue_cond . '(' . join( " OR ", map "Status = '$_'", @cur_statuses ) . ')';
+    my $name = RT::SQL->Quote( $queue->Name );
+    my $queue_cond = "Queue = $name AND ";
+    my $all_q = $queue_cond . '(' . join( " OR ", map "Status = $_", map RT::SQL->Quote($_), @statuses ) . ')';
 </%PERL>
 <tr class="<% $i%2 ? 'oddline' : 'evenline'%>" >
 
 <td>
-    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $all_q |u,n %>" title="<% $queue->{Description} %>"><% $queue->{Name} %></a>
+    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $all_q |u,n %>" title="<% $queue->Description %>"><% $queue->Name %></a>
 </td>
 
-%   for my $status (@cur_statuses) {
+%   for my $status (@statuses) {
 <td align="right">
-    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $queue_cond ."Status = '$status'" |u,n %>"><% $data->{$queue->{id}}->{$status } || '-' %></a>
+    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $queue_cond ."Status = ". RT::SQL->Quote($status) |u,n %>"><% $data->{ $queue->id }->{ $status } || '0' %></a>
 </td>
 %   }
 </tr>
@@ -87,59 +87,31 @@ for my $queue (@queues) {
 </table>
 % }
 <%INIT>
+return unless @queues && @statuses;
 
-my $Queues = RT::Queues->new( $session{'CurrentUser'} );
-$Queues->UnLimit();
-$m->callback( CallbackName => 'SQLFilter', Queues => $Queues );
+my $max = 0;
 
-my @queues = grep $queue_filter->($_), @{ $Queues->ItemsArrayRef };
-$m->callback( CallbackName => 'Filter', Queues => \@queues );
-
- at queues = map {
-    {  id          => $_->Id,
-       Name        => $_->Name,
-       Description => $_->Description || '',
-       Lifecycle   => $_->Lifecycle->Name,
+my %groups;
+foreach my $queue ( @queues ) {
+    my $cycle = $queue->Lifecycle;
+    my $cycle_name = $cycle->Name;
+    if ( $groups{ $cycle_name } ) {
+        push @{ $groups{ $cycle_name }{'queues'} }, $queue;
+        next;
     }
-} grep $_, @queues;
-
-my %lifecycle;
-
-for my $queue (@queues) {
-    my $cycle = RT::Lifecycle->Load( $queue->{'Lifecycle'} );
-    $lifecycle{ lc $cycle->Name } = $cycle;
-}
 
-unless (@statuses) {
-    my %seen;
-    foreach my $set ( 'initial', 'active' ) {
-        foreach my $lifecycle ( map $lifecycle{$_}, sort keys %lifecycle ) {
-            push @statuses, grep !$seen{ lc $_ }++, $lifecycle->Valid($set);
-        }
-    }
+    $groups{ $cycle_name } = {
+        cycle => $cycle,
+        statuses => [ grep $cycle->IsValid( $_), @statuses ],
+        queues => [$queue],
+    };
+    $max = @{ $groups{ $cycle_name }{'statuses'} }
+        if $max < @{ $groups{ $cycle_name }{'statuses'} };
 }
 
-my $data     = {};
-my $statuses = {};
-
-use RT::Report::Tickets;
-my $report = RT::Report::Tickets->new( RT->SystemUser );
-my $query =
-    "(".
-    join(" OR ", map {s{(['\\])}{\\$1}g; "Status = '$_'"} @statuses) #'
-    .") AND (".
-    join(' OR ', map "Queue = ".$_->{id}, @queues)
-    .")";
-$query = 'id < 0' unless @queues;
-$report->SetupGroupings( Query => $query, GroupBy => [qw(Status Queue)] );
-
-while ( my $entry = $report->Next ) {
-    $data->{ $entry->__Value("Queue") }->{ $entry->__Value("Status") }
-        = $entry->__Value('id');
-    $statuses->{ $entry->__Value("Status") } = 1;
-}
 </%INIT>
 <%ARGS>
-$queue_filter => undef
- at statuses => ()
+ at queues          => ()
+ at statuses        => ()
+$data            => {}
 </%ARGS>
diff --git a/share/html/Elements/QueueSummaryByStatus b/share/html/Elements/QueueSummaryByStatus
index 1c01542..efd9c02 100644
--- a/share/html/Elements/QueueSummaryByStatus
+++ b/share/html/Elements/QueueSummaryByStatus
@@ -58,16 +58,16 @@
 my $i = 0;
 for my $queue (@queues) {
     $i++;
-    my $name = $queue->{Name};
+    my $name = $queue->Name;
     $name =~ s/'/\\'/g;
     my $queue_cond = "Queue = '$name' AND ";
-    my $lifecycle = $lifecycle{ lc $queue->{'Lifecycle'} };
+    my $lifecycle = $queue->Lifecycle;
     my $all_q = $queue_cond . '(' . join( " OR ", map "Status = '$_'", grep $lifecycle->IsValid($_), @statuses ) . ')';
 </%PERL>
 <tr class="<% $i%2 ? 'oddline' : 'evenline'%>" >
 
 <td>
-    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $all_q |u,n %>" title="<% $queue->{Description} %>"><% $queue->{Name} %></a>
+    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $all_q |u,n %>" title="<% $queue->Description %>"><% $queue->Name %></a>
 </td>
 
 <%perl>
@@ -75,7 +75,7 @@ for my $queue (@queues) {
    if ( $lifecycle->IsValid( $status ) ) {
 </%perl>
 <td align="right">
-    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $queue_cond ."Status = '$status'" |u,n %>"><% $data->{$queue->{id}}->{$status } || '-' %></a>
+    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $queue_cond ."Status = '$status'" |u,n %>"><% $data->{ $queue->id }->{$status } || '0' %></a>
 </td>
 %   } else {
 <td align="right">-</td>
@@ -85,55 +85,10 @@ for my $queue (@queues) {
 % }
 </table>
 <%INIT>
-
-my $Queues = RT::Queues->new( $session{'CurrentUser'} );
-$Queues->UnLimit();
-$m->callback( CallbackName => 'SQLFilter', Queues => $Queues );
-
-my @queues = grep $queue_filter->($_), @{ $Queues->ItemsArrayRef };
-$m->callback( CallbackName => 'Filter', Queues => \@queues );
-
- at queues = map {
-    {  id          => $_->Id,
-       Name        => $_->Name,
-       Description => $_->Description || '',
-       Lifecycle   => $_->Lifecycle->Name,
-    }
-} grep $_, @queues;
-
-my %lifecycle;
-
-for my $queue (@queues) {
-    my $cycle = RT::Lifecycle->Load( $queue->{'Lifecycle'} );
-    $lifecycle{ lc $cycle->Name } = $cycle;
-}
-
-unless (@statuses) {
-    my %seen;
-    foreach my $set ( 'initial', 'active' ) {
-        foreach my $lifecycle ( map $lifecycle{$_}, sort keys %lifecycle ) {
-            push @statuses, grep !$seen{ lc $_ }++, $lifecycle->Valid($set);
-        }
-    }
-}
-
-my $data     = {};
-my $statuses = {};
-
-use RT::Report::Tickets;
-my $report = RT::Report::Tickets->new( RT->SystemUser );
-my $query = @queues
-    ? join(' OR ', map "Queue = ".$_->{id}, @queues)
-    : 'id < 0';
-$report->SetupGroupings( Query => $query, GroupBy => [qw(Status Queue)] );
-
-while ( my $entry = $report->Next ) {
-    $data->{ $entry->__Value("Queue") }->{ $entry->__Value("Status") }
-        = $entry->__Value('id');
-    $statuses->{ $entry->__Value("Status") } = 1;
-}
+return unless @queues && @statuses;
 </%INIT>
 <%ARGS>
-$queue_filter => undef
- at statuses => ()
+ at queues          => ()
+ at statuses        => ()
+$data            => {}
 </%ARGS>

commit dbda3478e86052f3c28b25b79d26d9a58966f53e
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Wed Feb 2 00:17:34 2011 +0300

    use new QueueSummary

diff --git a/share/html/Elements/MyAdminQueues b/share/html/Elements/MyAdminQueues
index eeb7859..7c6111b 100644
--- a/share/html/Elements/MyAdminQueues
+++ b/share/html/Elements/MyAdminQueues
@@ -45,8 +45,14 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<&|/Widgets/TitleBox, title => loc("Queues I administer"), bodyclass => "" &>
-<& /Elements/QueueSummaryByStatus,
-   queue_filter => sub { $_->CurrentUserHasRight('AdminQueue') },
+<&|/Widgets/TitleBox,
+    title => loc("Queues I administer"),
+    bodyclass => "",
+    titleright => loc("Edit"),
+    titleright_href => RT->Config->Get('WebPath').'/Prefs/QueueSummary.html?Pref=MyAdminQueues',
+&>
+<& /Elements/QueueSummary,
+    preference => 'MyAdminQueues',
+    queue_filter => sub { $_->CurrentUserHasRight('AdminQueue') },
 &>
 </&>
diff --git a/share/html/Elements/MySupportQueues b/share/html/Elements/MySupportQueues
index df3df4a..6904258 100644
--- a/share/html/Elements/MySupportQueues
+++ b/share/html/Elements/MySupportQueues
@@ -45,8 +45,14 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<&|/Widgets/TitleBox, title => loc("Queues I'm an AdminCc for"), bodyclass => "" &>
-<& /Elements/QueueSummaryByStatus,
-   queue_filter => sub { $_->IsAdminCc($session{'CurrentUser'}->Id) },
+<&|/Widgets/TitleBox,
+    title => loc("Queues I'm an AdminCc for"),
+    bodyclass => "",
+    titleright => loc("Edit"),
+    titleright_href => RT->Config->Get('WebPath').'/Prefs/QueueSummary.html?Pref=MySupportQueues',
+&>
+<& /Elements/QueueSummary,
+    preference => 'MySupportQueues',
+    queue_filter => sub { $_->IsAdminCc($session{'CurrentUser'}->Id) },
 &>
 </&>
diff --git a/share/html/Elements/Quicksearch b/share/html/Elements/Quicksearch
index b7b1783..4aee492 100644
--- a/share/html/Elements/Quicksearch
+++ b/share/html/Elements/Quicksearch
@@ -50,17 +50,11 @@
     title => loc("Quick search"),
     bodyclass => "",
     titleright => loc("Edit"),
-    titleright_href => RT->Config->Get('WebPath').'/Prefs/Quicksearch.html',
+    titleright_href => RT->Config->Get('WebPath').'/Prefs/QueueSummary.html?EditUnwanted=1',
 &>
-<& $comp,
-   queue_filter => sub { $_->CurrentUserHasRight('ShowTicket') && !exists $unwanted->{$_->Name} },
+<& /Elements/QueueSummary,
+    preference => 'QuickSearch',
+    queue_filter => sub { $_->CurrentUserHasRight('ShowTicket') },
 &>
 </&>
 </div>
-<%INIT>
-my $unwanted = $session{'CurrentUser'}->UserObj->Preferences('QuickSearch', {});
-my $comp = $SplitByLifecycle? '/Elements/QueueSummaryByLifecycle' : '/Elements/QueueSummaryByStatus';
-</%INIT>
-<%ARGS>
-$SplitByLifecycle => 1
-</%ARGS>

commit 764ff02151d97021305e5c7c5545a7879e6a43db
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Wed Feb 2 00:18:11 2011 +0300

    new preferences UI for all portlets based on QueueSummary

diff --git a/share/html/Prefs/QueueSummary.html b/share/html/Prefs/QueueSummary.html
index 93bd399..815a82c 100644
--- a/share/html/Prefs/QueueSummary.html
+++ b/share/html/Prefs/QueueSummary.html
@@ -46,45 +46,86 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <& /Elements/Header, Title => $title &>
-<& /Elements/Tabs
-&>
+<& /Elements/Tabs &>
+
 <& /Elements/ListActions, actions => \@actions &>
-<h1><&|/l&>Select queues to be displayed on the "RT at a glance" page</&></h1>
-<form method="post" action="Quicksearch.html" name="Preferences">
+
+<form method="post" action="QueueSummary.html" name="Preferences">
+<input type="hidden" class="hidden" name="Pref" value="<% $Pref %>" \>
+<input type="hidden" class="hidden" name="EditUnwanted" value="<% $EditUnwanted %>" \>
+
+<h1><&|/l&>Select table preferences</&></h1>
+
+<input type="checkbox" class="checkbox" name="ShowEmptyRows" value="1" \
+% if ( $preference->{'ShowEmptyRows'} ) {
+checked="checked" \
+% }
+/><&|/l&>Show rows with all zeros</&><br />
+
+<input type="checkbox" class="checkbox" name="ShowEmptyColumns" value="1" \
+% if ( $preference->{'ShowEmptyColumns'} ) {
+checked="checked" \
+% }
+/><&|/l&>Show columns with all zeros</&><br />
+
+<input type="checkbox" class="checkbox" name="SplitByLifecycle" value="1" \
+% if ( $preference->{'SplitByLifecycle'} ) {
+checked="checked" \
+% }
+/><&|/l&>Split into groups with different status sets (lifecycles)</&><br />
+
+% if ( $EditUnwanted ) {
+<h1><&|/l&>Select queues to be displayed</&></h1>
 <ul>
 % for my $queue (@queues) {
-<li><input type="checkbox" class="checkbox" name="Want-<%$queue->Name%>" value="1"
-% unless ($unwanted->{$queue->Name}) {
-checked="checked"
+<li><input type="checkbox" class="checkbox" name="Want" value="<% $queue->Name %>" \
+% unless ($preference->{'Unwanted'}{ $queue->Name }) {
+checked="checked" \
 % }
-/><%$queue->Name%>: <%$queue->Description%></li>
+/><% $queue->Name %>: <% $queue->Description %></li>
 % }
 </ul>
+% }
 <& /Elements/Submit, Caption => loc("Save Changes"), Label => loc('Save'), Name => 'Save'&>
 
 </form>
 
 <%INIT>
 my @actions;
+
 my $title = loc("Customize").' '.loc("Quick search");
+
 my $user = $session{'CurrentUser'}->UserObj;
-my $unwanted = $user->Preferences('QuickSearch', {});
-my $Queues = RT::Queues->new($session{'CurrentUser'});
-$Queues->UnLimit;
-my @queues = grep {$_->CurrentUserHasRight('ShowTicket')} @{$Queues->ItemsArrayRef};
-
-if ($ARGS{'Save'}) {
-    for my $queue (@queues) {
-        if ($ARGS{"Want-".$queue->Name}) {
-	    delete $unwanted->{$queue->Name};
-	}
-        else {
-	    ++$unwanted->{$queue->Name};
-        }
-    }
-
-    my ($ok, $msg) = $user->SetPreferences('QuickSearch', $unwanted);
+
+my $preference = $user->Preferences($Pref, {});
+
+my @queues;
+if ( $EditUnwanted ) {
+    my $Queues = RT::Queues->new($session{'CurrentUser'});
+    $Queues->UnLimit;
+    @queues = grep { $_->CurrentUserHasRight('ShowTicket') } @{ $Queues->ItemsArrayRef };
+}
+
+if ( $Save ) {
+    my %Want = map { $_ => 1 } @Want;
+    $preference->{'Unwanted'} = { map { $_ => 1 } grep !$Want{ $_ }, map $_->Name, @queues };
+
+    $preference->{$_} = $ARGS{$_} foreach qw(
+        SplitByLifecycle
+        ShowEmptyRows
+        ShowEmptyColumns
+    );
+
+    my ($ok, $msg) = $user->SetPreferences( $Pref => $preference );
     push @actions, $ok ? loc('Preferences saved.') : $msg;
 }
 
 </%INIT>
+<%ARGS>
+$Pref         => 'QuickSearch'
+
+$EditUnwanted => 0
+ at Want         => ()
+
+$Save         => 0
+</%ARGS>

commit 67cd856d599af200f4c65db95b555f879a749773
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Wed Feb 2 00:20:00 2011 +0300

    drop "quicksearch" preferences tab
    
    there are multiple quick search like portlets, each with its own
    preferences

diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index ba63a3e..237b157 100755
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -392,7 +392,6 @@ my $build_admin_menu = sub {
         $settings->child( about_me => title => loc('About me'), path     => '/User/Prefs.html', );
         $settings->child( search_options => title => loc('Search options'), path => '/Prefs/SearchOptions.html', );
         $settings->child( myrt => title => loc('RT at a glance'), path => '/Prefs/MyRT.html', );
-        $settings->child( quicksearch => title => 'Quick search' => title => loc('Quick search'), path => '/Prefs/Quicksearch.html');
 
         my $search_menu = $settings->child( 'saved-searches' => title => 'Saved Searches' );
         my $searches = [ $m->comp( "/Search/Elements/SearchesForObject",

-----------------------------------------------------------------------


More information about the Rt-commit mailing list