[Rt-commit] rt branch, 4.0/hide-requestor-groups, created. rt-4.0.0rc4-39-g58cc846

Alex Vandiver alexmv at bestpractical.com
Tue Feb 8 15:38:48 EST 2011


The branch, 4.0/hide-requestor-groups has been created
        at  58cc84676b86f7734e85245f405766e99bd4270d (commit)

- Log -----------------------------------------------------------------
commit 58cc84676b86f7734e85245f405766e99bd4270d
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Feb 8 15:38:44 2011 -0500

    Setting groups limit to undef skips group display on MoreAboutRequestor
    
    Flip the default to 0 to maintain the same default behavior

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index 6fa55e9..cc69e23 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -906,9 +906,9 @@ Set($MoreAboutRequestorExtraInfo, '');
 
 =item C<$MoreAboutRequestorGroupsLimit>
 
-By default, the 'More about requestor' box on Ticket/Display.html shows all
-the groups of the Requestor.
-Use this to limit the number of groups.
+By default, the 'More about requestor' box on Ticket/Display.html
+shows all the groups of the Requestor.  Use this to limit the number
+of groups; a value of undef removes the group display entirely.
 
 e.g.
 
@@ -916,7 +916,7 @@ Set($MoreAboutRequestorGroupsLimit, 10);
 
 =cut
 
-Set($MoreAboutRequestorGroupsLimit, undef);
+Set($MoreAboutRequestorGroupsLimit, 0);
 
 =item C<$AutocompleteOwners>
 
diff --git a/share/html/Ticket/Elements/ShowRequestor b/share/html/Ticket/Elements/ShowRequestor
index d0cedbd..0a605f8 100755
--- a/share/html/Ticket/Elements/ShowRequestor
+++ b/share/html/Ticket/Elements/ShowRequestor
@@ -116,7 +116,8 @@
 </div>
 % }
 
-% if ( $ShowGroups ) {
+% my $grouplimit = RT->Config->Get('MoreAboutRequestorGroupsLimit');
+% if ( $ShowGroups and defined $grouplimit ) {
 <div class="more-about-user-groups">
   <span class="label">
     <&|/l&>Groups this user belongs to</&>
@@ -126,7 +127,7 @@
   [<a href=<% RT->Config->Get('WebPath') . '/Admin/Users/Memberships.html?id=' . $requestor->id %> ><&|/l&>Edit</&></a>]
 % }
   </span>
-  <span class="value"><& /Elements/ShowMemberships, UserObj => $requestor, Limit => RT->Config->Get('MoreAboutRequestorGroupsLimit') &></span>
+  <span class="value"><& /Elements/ShowMemberships, UserObj => $requestor, Limit => $grouplimit &></span>
 </div>
 % }
 

-----------------------------------------------------------------------


More information about the Rt-commit mailing list