[Rt-commit] rt branch, 4.0/sanity-check-add-principal, updated. rt-3.9.7-1168-g4098df3

Thomas Sibley trs at bestpractical.com
Fri Jan 7 12:23:39 EST 2011


The branch, 4.0/sanity-check-add-principal has been updated
       via  4098df3e2d037db8b049d23d4e33e3bf7cd07f2b (commit)
      from  6e93fd3ad6461865837a37f9a4df0412ad3ca2a8 (commit)

Summary of changes:
 share/html/Admin/Elements/EditRights |    2 +-
 share/html/NoAuth/js/util.js         |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 4098df3e2d037db8b049d23d4e33e3bf7cd07f2b
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Jan 7 12:22:48 2011 -0500

    Work around Firefox's insanity of moving block elements within <a>s up a level

diff --git a/share/html/Admin/Elements/EditRights b/share/html/Admin/Elements/EditRights
index 069afb9..75dc192 100644
--- a/share/html/Admin/Elements/EditRights
+++ b/share/html/Admin/Elements/EditRights
@@ -122,7 +122,7 @@ for my $category (@$Principals) {
 % }
         </script>
 % my $type = lc $AddPrincipal eq 'user' ? loc('username') : loc($AddPrincipal);
-        <div class="warning"><&|/l, $type &>Invalid [_1]</&></div>
+        <span class="warning"><&|/l, $type &>Invalid [_1]</&></span>
       </a>
     </li>
 % }
diff --git a/share/html/NoAuth/js/util.js b/share/html/NoAuth/js/util.js
index 2125e4f..6c926f6 100644
--- a/share/html/NoAuth/js/util.js
+++ b/share/html/NoAuth/js/util.js
@@ -298,7 +298,7 @@ function toggle_addprincipal_validity(input, good) {
         jQuery(input).nextAll(".warning").hide();
         jQuery("#acl-AddPrincipal input[type=checkbox]").removeAttr("disabled");
     } else {
-        jQuery(input).nextAll(".warning").show();
+        jQuery(input).nextAll(".warning").css("display", "block");
         jQuery("#acl-AddPrincipal input[type=checkbox]").attr("disabled", "disabled");
     }
     update_addprincipal_title(input);

-----------------------------------------------------------------------


More information about the Rt-commit mailing list