[Rt-commit] rt branch, 3.8/perlcritic, updated. rt-3.8.10-165-gdff3872

Thomas Sibley trs at bestpractical.com
Mon Jul 25 10:43:33 EDT 2011


The branch, 3.8/perlcritic has been updated
       via  dff38721c8600ab870142d86e2bdbe769c21ca94 (commit)
      from  31e78c8366ca39dc4b0b22ad36341553112546cb (commit)

Summary of changes:
 lib/RT/Action/CreateTickets.pm |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

- Log -----------------------------------------------------------------
commit dff38721c8600ab870142d86e2bdbe769c21ca94
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Jul 25 10:35:32 2011 -0400

    Remove old, never used references to %T::X meant to be filled in by the template
    
    This entered RT in a82f10ef88 and appears to be the only place that
    [$%@]X or T::X was ever used in the RT codebase.  It seems to be core
    code originally meant to support a custom extension by the author.

diff --git a/lib/RT/Action/CreateTickets.pm b/lib/RT/Action/CreateTickets.pm
index 5fd9028..959154b 100755
--- a/lib/RT/Action/CreateTickets.pm
+++ b/lib/RT/Action/CreateTickets.pm
@@ -671,11 +671,6 @@ sub ParseLines {
 
         if ($err) {
             $RT::Logger->error( "Ticket creation failed: " . $err );
-            while ( my ( $k, $v ) = each %T::X ) {
-                $RT::Logger->debug(
-                    "Eliminating $template_id from ${k}'s parents.");
-                delete $v->{$template_id};
-            }
             next;
         }
     }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list