[Rt-commit] rt branch, 3.8/perlcritic, updated. rt-3.8.10-183-g1227290

Thomas Sibley trs at bestpractical.com
Wed Jul 27 16:40:28 EDT 2011


The branch, 3.8/perlcritic has been updated
       via  12272901855ced249bbe07b3aa6a34ce6246acba (commit)
      from  491abf396d4bc04e0f9ef1ad4344b6c1459dcb8f (commit)

Summary of changes:
 lib/RT/Handle.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 12272901855ced249bbe07b3aa6a34ce6246acba
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Jul 27 16:36:09 2011 -0400

    Setting *acl to an empty sub causes redefined warnings
    
    There is no good way around this with the constraints we are under, so
    we'll need to rely on local's magical properties when you don't specify
    an initial value.

diff --git a/lib/RT/Handle.pm b/lib/RT/Handle.pm
index f21826d..989bc49 100755
--- a/lib/RT/Handle.pm
+++ b/lib/RT/Handle.pm
@@ -431,7 +431,7 @@ sub InsertACL {
         $path = $base_path;
     }
 
-    local *acl = sub {};
+    local *acl;
     do $path || return (0, "Couldn't load ACLs: " . $@);
     my @acl = acl($dbh);
     foreach my $statement (@acl) {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list