[Rt-commit] rt branch, 4.0/version-shenanigans, created. rt-4.0.0rc6-23-ge2f269e

[Kevin Falcone]

The branch, 4.0/version-shenanigans has been created
        at  e2f269e5c991d716d0e815ab379b35871a84b443 (commit)

- Log -----------------------------------------------------------------
commit e2f269e5c991d716d0e815ab379b35871a84b443
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Thu Mar 10 16:24:06 2011 -0500

    Make $RT::VERSION accessible from RT.pm
    
    When we moved the autogenerated code into RT/Generated.pm we broke any
    sort of version checking that looked at RT.pm (MakeMaker::ExtUtils and
    Module::Install).  The particular hacks they require are documented
    above the relevant code.
    
    I reiterate my comment in the code of "I wonder what this breaks"

diff --git a/lib/RT.pm b/lib/RT.pm
index 9d51fad..cb1ba4e 100644
--- a/lib/RT.pm
+++ b/lib/RT.pm
@@ -785,6 +785,31 @@ L<DBIx::SearchBuilder>
 
 =cut
 
+# These work around us not declaring RT::VERSION here (but instead
+# using lib/RT/Generated.pm.  This allowed us to no longer have an
+# RT.pm.in but means we need version shenanigans
+
+# if in a perl module, you say requires('RT','3.8.9') ExtUtils::MM_Unix's
+# parse_version looks for a VERSION line outside of POD, so if you want to
+# declare something that won't actually be parsed at runtime, you're supposed
+# to if (0) or unless (1) it
+if (0) {
+    use RT::Generated; our $VERSION = $RT::VERSION;
+}
+
+# Unfortunately, auto_install doesn't use the above version hack, it wants to
+# require RT; RT->VERSION but that doesn't seem to pick up the LoadGeneratedData
+# import into RT::VERSION.  Also, in perl 5.12, version parsing is stricter and
+# versions like 4.0.0rc6 or 4.0.0-22-g12345a die during the compare, so we strip
+# off cruft to make it happier.  I wonder what this breaks.
+sub VERSION {
+    my $version = $RT::VERSION;
+    $version =~ s/rc|pre|alpha/_/;
+    $version =~ s/-\d+-g[a-f0-9]+$//;
+    return $version;
+}
+
+
 require RT::Base;
 RT::Base->_ImportOverlays();
 

-----------------------------------------------------------------------