[Rt-commit] rt branch, 4.0/cf-spurious-update, updated. rt-4.0.0-181-g4e00e52

Thomas Sibley trs at bestpractical.com
Fri May 6 16:22:17 EDT 2011


The branch, 4.0/cf-spurious-update has been updated
       via  4e00e521ef1a2552a397ba5f69f566b586ae4dfc (commit)
      from  db025dddbfa37df845e14c2ec279657cb472171b (commit)

Summary of changes:
 share/html/Admin/CustomFields/Modify.html |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 4e00e521ef1a2552a397ba5f69f566b586ae4dfc
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri May 6 16:20:51 2011 -0400

    Always show a result message when changing a CF's BasedOn
    
    At the same time, remove the error message check which was cruft from
    the age of attributes.

diff --git a/share/html/Admin/CustomFields/Modify.html b/share/html/Admin/CustomFields/Modify.html
index fc206e1..e77a5ec 100644
--- a/share/html/Admin/CustomFields/Modify.html
+++ b/share/html/Admin/CustomFields/Modify.html
@@ -220,7 +220,7 @@ if ( $ARGS{'Update'} && $id ne 'new' ) {
 
     if (($CustomFieldObj->BasedOn||'') ne ($BasedOn||'')) {
         my ($good, $msg) = $CustomFieldObj->SetBasedOn( $BasedOn );
-        push @results, $msg unless $good or $msg =~ /No entry found/;
+        push @results, $msg;
     }
 
     my $paramtag = "CustomField-". $CustomFieldObj->Id ."-Value";

-----------------------------------------------------------------------


More information about the Rt-commit mailing list