[Rt-commit] rt branch, 4.0/consistent-result-msg-quotes, created. rt-4.0.0-182-g9b40256

Thomas Sibley trs at bestpractical.com
Fri May 6 16:45:32 EDT 2011


The branch, 4.0/consistent-result-msg-quotes has been created
        at  9b40256046ee474a6a8d4d33d707d9d4e009d675 (commit)

- Log -----------------------------------------------------------------
commit 9b40256046ee474a6a8d4d33d707d9d4e009d675
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri May 6 16:44:00 2011 -0400

    Consistently quote the old value and new value in the result message
    
    Somewhat surprisingly, this doesn't break any tests.

diff --git a/lib/RT/Record.pm b/lib/RT/Record.pm
index 0252507..ae12aca 100644
--- a/lib/RT/Record.pm
+++ b/lib/RT/Record.pm
@@ -495,7 +495,7 @@ sub _Set {
           $self->loc(
             "[_1] changed from [_2] to [_3]",
             $self->loc( $args{'Field'} ),
-            ( $old_val ? "'$old_val'" : $self->loc("(no value)") ),
+            ( $old_val ? '"$old_val"' : $self->loc("(no value)") ),
             '"' . $self->__Value( $args{'Field'}) . '"' 
           );
       } else {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list