[Rt-commit] rt branch, 4.0-trunk, updated. rt-4.0.4-46-g3a0dfb3

Kevin Falcone falcone at bestpractical.com
Tue Nov 15 14:10:52 EST 2011


The branch, 4.0-trunk has been updated
       via  3a0dfb3ac98c151e481fcf1d1f9483dd04d07834 (commit)
       via  a56182c53d2c50448643ca3e845424c85018f3d2 (commit)
      from  3232138aef06f4893623a86b371be8c3f52aab02 (commit)

Summary of changes:
 share/html/Elements/ColumnMap                 |    2 +-
 share/html/Elements/RT__Dashboard/ColumnMap   |    2 +-
 share/html/Elements/RT__SavedSearch/ColumnMap |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit a56182c53d2c50448643ca3e845424c85018f3d2
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Nov 15 12:19:38 2011 -0500

    The Name column in dashboard and saved search lists should not be titled foo
    
    The primary page showing dashboard and saved search collection lists
    specifies an explicit /TITLE:$title in the format, so this oversight was
    never caught.

diff --git a/share/html/Elements/RT__Dashboard/ColumnMap b/share/html/Elements/RT__Dashboard/ColumnMap
index 701db53..488a832 100644
--- a/share/html/Elements/RT__Dashboard/ColumnMap
+++ b/share/html/Elements/RT__Dashboard/ColumnMap
@@ -58,7 +58,7 @@ my $COLUMN_MAP = {
         value     => sub { return $_[0]->Id },
     },
     Name => {
-        title     => sub { return "foo" }, #'Name', # loc
+        title     => 'Name', # loc
         attribute => 'Name',
         value     => sub { return $_[0]->Name()||loc("Unnamed dashboard") },
     },
diff --git a/share/html/Elements/RT__SavedSearch/ColumnMap b/share/html/Elements/RT__SavedSearch/ColumnMap
index 81b0041..aeedf09 100644
--- a/share/html/Elements/RT__SavedSearch/ColumnMap
+++ b/share/html/Elements/RT__SavedSearch/ColumnMap
@@ -58,7 +58,7 @@ my $COLUMN_MAP = {
         value     => sub { return $_[0]->Id },
     },
     Name => {
-        title     => sub { return "foo" }, #'Name', # loc
+        title     => 'Name', # loc
         attribute => 'Name',
         value     => sub { return $_[0]->Name()||loc("Unnamed search") },
     },

commit 3a0dfb3ac98c151e481fcf1d1f9483dd04d07834
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Nov 15 11:44:38 2011 -0500

    Interpolate $id and $checked in RadioButton columns
    
    77a25da mistakenly use q{} instead of qq{}

diff --git a/share/html/Elements/ColumnMap b/share/html/Elements/ColumnMap
index 2e8506c..c649fe6 100644
--- a/share/html/Elements/ColumnMap
+++ b/share/html/Elements/ColumnMap
@@ -148,7 +148,7 @@ my $COLUMN_MAP = {
             my $arg = $m->request_args->{ $name };
             my $checked = '';
             $checked = 'checked="checked"' if $arg && $arg == $id;
-            return \qq{<input type="radio" name="}, $name, \q{" value="$id" $checked />};
+            return \qq{<input type="radio" name="}, $name, \qq{" value="$id" $checked />};
         },
     },
     (map {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list