[Rt-commit] rt annotated tag, rt-4.1.5, created. rt-4.1.5

Alex Vandiver alexmv at bestpractical.com
Tue Dec 4 01:27:21 EST 2012


The annotated tag, rt-4.1.5 has been created
        at  e421176ea9d44d06a616744a411a1a87aa57690c (tag)
   tagging  23fbcaed0ccb9ab9d3ad38ea92601a041c7d22e5 (commit)
  replaces  rt-4.0.8
 tagged by  Alex Vandiver
        on  Tue Dec 4 01:25:57 2012 -0500

- Log -----------------------------------------------------------------
tag 4.1.5 development release
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAlC9l3UACgkQMflWJZZAbqDqkQCdEwDyIRAElXot29awi6GkxUwJ
rJEAn2LIwbBv9ck4MEPQrXRlMzA3aqsy
=NDIS
-----END PGP SIGNATURE-----

Alex Vandiver (236):
      Actually display something when only passed a $Address
      Merge branch '4.0-trunk'
      Merge branch '4.0-trunk'
      Warnings avoidance for undef bidnings during SQL query logging
      Remove duplicate "Lang" which caused "That is already the current value" on lang changes
      POD nitpick
      Merge branch '4.0-trunk'
      Merge branch '4.2/split-up-setowner-a-bit'
      Revert b8b8a88..9adb5f8 to place them on a branch for further development
      Reinstate b8b8a88..9adb5f8 on a brnach for further development
      Merge branch '4.2/rename-LogToScreen'
      Merge branch '4.2/attachment-length-on-create'
      Provide a stable, consistent ordering for reminders with the same due date
      Merge branch '4.2/reminder-permissions'
      Merge branch '4.0-trunk' into master
      Merge branch '4.2/user_preferences_cache'
      Move loading and calling of Module::Refresh to only one codepath
      Merge branch '4.0-trunk'
      Merge branch '4.2/stop-hardcoding-perl'
      Flip UseSQLForACLChecks to on by default
      Remove a horrid and wrong unquoting regex used by GetReferencedQueues
      Merge branch '4.2/remove-setoriginobj'
      Remove the unused Authenticate method
      Merge branch '4.0-trunk'
      If a module is missing, don't bother spewing the full @INC; simply let it show as MISSING
      Merge branch '4.2/cmd-symlinks'
      Replace RT::Attributes->WithId with the clearer ->new and ->Load
      Fix LimitToActiveStatus to compile
      Since each fail doesn't list @INC anymore, display it once at the end
      Update test comments to match the tests they're on
      Merge branch '4.2/language-change-results'
      Tests for capturing parens in EmailSubjectTagRegex
      Update tests for the "Language changed" message being in the new language
      Merge branch '4.0-trunk'
      Merge branch '4.2/clean-autohandler'
      Merge branch '4.2/improve-subject-parsing'
      Remove an empty WebExternalAutoInfo block which could never run
      Remove conditional around code that should always be run
      Merge branch '4.2/reminder-queue-change'
      Merge branch '4.0-trunk'
      Merge branch '4.0-trunk'
      Remove quotes in CF form elements to avoid implying correct quoting
      Merge branch '4.0-trunk'
      Add TODO tests to cover warnings caused by Locale::Maketext::Fuzzy [rt.cpan.org #72302]
      Merge branch '4.2/active-status'
      Merge branch '4.2/auto-apply-user-group-cfs-globally'
      Ensure that portlet names are HTML-escaped
      Merge branch '4.2/allowed-components'
      Merge branch '4.2/loc-watcher-for-txn-desc'
      Merge branch '4.2/logo-color-picker'
      Merge branch '4.0-trunk'
      Locale::Maketext::Fuzzy 0.11 fixes the unintended and incorrect fuzzy match
      Ensure that I18N::LangTags::Detect only finds the "C" locale in tests
      Default to verifying SSL certificate in the mail gateway
      With the Pg FTS, catch and skip attachments which contain invalid UTF8 bytes
      Strengthen wording about our ability (or lack thereof) to FTS index on Pg
      If we fail to index on Pg, ensure that we continue indexing past that point
      Merge branch '4.0-trunk'
      When updating "text" fields "text", don't display old and new values
      Fix the error message (copied from users) on queue disable
      Prohibit creating tickets in disabled queues
      Remove all whitespace separating adjacent encoded-word chunks
      Join all adjacent QP encoded-word chunks, in case octets were split
      Merge branch '4.0-trunk'
      Merge branch '4.0-trunk'
      Avoid warnings if CheckIntegrity is called twice as a class method
      Remove the bottom margin that superfish adds to menus
      Make the date entry widgets on bulk update page be datetime widgets
      Allow non-ExecuteCode users to create Simple templates
      Allow altering template type to Simple and changing Content simultaneously
      Default the Type according to the permissions of the current user
      Encode the interface (Email/Web/Mobile/REST) that content came from
      Merge branch '4.0-trunk'
      Stop warning on four configuration options removed in 4.0
      Mark a new deprecation warning to be removed in 4.4
      Remove no longer used components
      /Elements/MyReminders is not deprecated; remove misleading comment
      Remove back-compat argument to CF admin page, deprecated in bddd336 (3.8.0)
      Remove back-compat _PrivacyObjects method, deprecated in 36df10d (4.0.0)
      Remove back-compat argument form to SendEmail, deprecated in 699ed17 (3.8.0)
      Warn, and deprecate for 4.4, the old UpdateCustomFields call convention
      Remove deprecations on ->Limit* helpers on CustomFields
      Remove ->Import methods
      Allow the passing of actions through to Abort
      Remove the unused DeleteCategory method from CFVs
      Remove the no-longer-used $attachment->Quote method; use $txn->Content
      Remove support for a global _IsOverrideGlobalACL method, last referenced in RT2
      Merge branch '4.2/web-external-auth'
      Make tests pass on inline server, which caches callbacks across restarts
      Ensure that BASIC_AUTH in testing Apache configs always has a value
      Unify install-mode testing technique
      Rewrite RT_SiteConfig.pm entirely when setting options during testing
      Move locale loading earlier, so we don't cache false negative
      Merge branch '4.0-trunk'
      Make ExternalAuth also respect the ?next=hash argument after logins
      Provide some rationale in comments for the convoluted logic
      Fix a typo, preventing emails from setting internal encryption header
      Remove internal signing and encryption hints from incoming mail
      Restrict users to only signing with queue or their own personal keys
      Don't propose any secret keys to users with no email address
      Explicitly restrict private keys to ones offered
      Avoid spurious update and warning messages on key update
      Require AdminUser to set PGP private key IDs, not merely ModifySelf
      Ensure that no --arguments can be snuck to GPG commands as arguments
      Refactor shared code controlling if a message will be encrypted or signed
      Refactor RT::Action::SendEmail->Commit to consolidate RecordOutgoingEmail path
      When creating tickets via the UI, always set signing/encryption headers
      Differentiate "always sign" from "default to signing when composing"
      Descriptions of just-created transactions should always be readable
      Make rt-crontool pass the newly-added "use warnings" pragma
      Only check the u+x bit, not the entire mode
      Clean out vestigial comments referencing factory
      Remove shebang lines from new test files
      Move policy checks to have descriptive options
      Only walk the directory structure once looking for files
      When possible, use .gitignore to skip ignored files
      Check for lack of +x on share/ and t/data/
      Check for the presence (or absence) of the BPS license tag
      Remove +x bit from a large number of files that have no need of it
      Remove BPS block from t/ files
      Depend on the extension, not path; tag the autohandler or dhandler
      Copy over timepicker copyright to its css file
      Add missing BPS license blocks
      RT::ObjectCustomFieldValues calls LimitToEnabled by default
      Move "global or queue" logic to LoadCustomFieldByIdentifier
      Promote _LookupId to a public method, and optimize slightly
      Remove unnecessary RT::Class::_LookupId
      Cache CFs in ColumnMap on a per-request basis
      Merge branch '4.0/update-translations' into 4.0-trunk
      Merge branch '4.0/auth-token-reset' into 4.0-trunk
      Test queues with spaces in them
      Merge branch '4.0/broader-object-names-in-cli' into 4.0-trunk
      Test that the database always sees an upper-case NULL
      Accept lower-case "null" in the query builder
      Merge branch '4.0/dashboard-mail-in-outlook' into 4.0-trunk
      Merge branch '4.0/date-formats-in-user-tz' into 4.0-trunk
      Merge branch '4.0/cf-edit-alignment-fix' into 4.0-trunk
      Merge branch '4.0/clean-old-session-lock-files' into 4.0-trunk
      Merge branch '4.0/config-set-ref' into 4.0-trunk
      Minor wording fixes
      Merge branch '4.0/document-initialdata' into 4.0-trunk
      Remove a stray unnecessary # loc
      Merge branch '4.0/group-by-i18n-in-search-chart-page' into 4.0-trunk
      Merge branch '4.0/handle-IS-vs-is' into 4.0-trunk
      Ensure that attachments don't get an X-RT-Interface forced on them
      Give any MIMEObjs (via Content, for example) a default X-RT-Interface
      Unify two different loc strings that only occur once each
      Update upgrade dir for to reflect next version
      Merge branch '4.0/load-modules-later-in-tests' into 4.0-trunk
      Merge branch '4.0/log-more-sql-queries' into 4.0-trunk
      Merge branch '4.0/menu-convenience-methods' into 4.0-trunk
      Merge branch '4.0/remove-cache-self' into 4.0-trunk
      Merge branch '4.0/rest-documentation-cleanup' into 4.0-trunk
      Merge branch '4.0/rt-apache-absolute-paths' into 4.0-trunk
      Merge branch '4.0/name-principal-in-msg' into 4.0-trunk
      Consolidate example mysqldump commands into a single file
      Merge branch '4.0/scrub-dashboard-javascript' into 4.0-trunk
      As 1599f0d scrubs javascript in dashboards, remove the flag
      Make postgres example also output to a single file
      Merge branch '4.0/backup-docs' into 4.0-trunk
      Remove an extra "my" brought in by merge 6b82917
      Remove spurious \ escaping before ' in POD and comments
      Ensure that even disabled queues get upgraded
      Merge branch '4.0/lifecycle-default-value' into 4.0-trunk
      Switch to using RT->Config->Set so tests pass under Apache
      Sort scrips based on ObjectScrips' SortOrder, not description
      As Disabled is no longer a Stage on Scrips, provide a UI for altering it
      Use existing check() infrastructure
      Ensure that the closing } during compile checking is on its own line
      Remove /Admin/Elements/SelectScrip, last referenced in 392f8fd
      Merge branch '4.0/columnmap-cache-cf' into 4.0-trunk
      Merge branch '4.0/loose-cf-name-in-rest' into 4.0-trunk
      Merge branch '4.2/custom-field-arg-parsing'
      Don't pass one shared CustomFields object between CF grouping lists
      IsGlobal returns the ObjectScrip record, conveniently
      Remove unnecessary passing of Default to EditCustomField
      Avoid computing NamePrefix by hand wherever possible
      Use new _ParseObjectCustomFieldArgs and _NormalizeObjectCustomFieldValue methods
      Use the _NormalizeObjectCustomFieldValue refactoring
      Merge branch '4.2/allow-times-for-ical-feeds'
      Push the CF grouping into the NamePrefix, to allow for separation
      Synchronize CF values in the browser using JavaScript
      Live-synchronize textareas and text entry boxes as you type
      Warn if the browser submits inconsistent data for a CF rendered twice
      Pass a string as Pattern, as Pg doesn't strigify Regexp objects on insert
      Merge branch '4.0/before-update-callback-on-mobile' into 4.0-trunk
      Merge branch '4.0/custom-field-styles-for-mobile' into 4.0-trunk
      Increase Log::Dispatch minimum version to 2.30, for consistent warnings
      Don't apply change/keyup handlers if the CF only appears once
      Rename groupings tests to not imply groups
      Refactor groupings tests
      Correctly test for different submitted values with select-multiple CFs
      Tests for CFs being rendered in more than one location
      Adjust a regex to match the new grouping style
      Merge branch '4.2/custom-field-groupings'
      Merge branch '4.2/cf-validation-messages'
      Merge branch '4.2/link-api-refactoring'
      Escape '/'s in JSON, to allow safe use in <script> tags
      Add security tests for vulnerabilities released 2012-05-22
      Merge branch '4.0/clean-jumbo-message-box' into 4.0-trunk
      Merge branch '4.2/remove-deprecations'
      Refactor DeferOwner logic
      Stop splitting SetOwner into _Set and _NewTransaction
      Remove UpdateTicket argument to _Set, simplifying logic
      Deprecate and move away from RT::Group->Load____RoleGroup methods
      Understand role groups like Owner which always contain exactly one user
      Abstract out determination of role class from domain
      Maintain one-user invariant, even when a user is removed
      Move removal after addition of the new groupmember, to avoid id reuse
      Update denormalized "Owner" column on tickets on group change
      Make CreateRoleGroup respect InsideTransaction
      Factor out role group creation for tickets and queues
      Factor out role group argument parsing
      Iteratively add roles, as their addition may impact rights
      Remove closing fold markers; these have no opening fold
      Merge branch '4.2/web-home-path-column-map'
      Merge branch '4.2/user-set-disabled-error'
      Apply transaction batch on tickets to remove warnings
      Merge branch '4.2/test-shredder-pm'
      Merge branch '4.2/shredding-links'
      Merge branch '4.2/validator-exit-code'
      Merge branch '4.2/validate-after-shredding-in-tests'
      Merge branch '4.2/scrips-ui'
      Merge branch '4.2/render-menu-in-lib'
      Upgrade for 4.1.3 has already been merged; renumber to 4.1.5
      Warnings avoidance, if LoadByName is called without a Queue
      Adjust locstring for grammar
      Merge branch '4.2/template-name-instead-of-id'
      Merge branch '4.0-trunk'
      Updates for scrips applying to multiple queues
      Queue is now immutable on templates
      Merge branch '4.2/generic-history-rendering'
      Add a TODO'd test for watcher transactions when users are shredded
      WatchAsAdminCc was mis-spelt, but unnecessary
      Remove a warning during creation of unowned tickets
      Merge branch '4.2/shredder-watcher-history'

Chia-liang Kao (4):
      mark command line boilerplate
      get taint check its own begin block
      Use Cwd::abs_path instead of FindBin to determine the base of the binary files for libs.
      update the boilerplate for all scripts

Christian Loos (3):
      use in ShowSimplifiedRecipients the same hint as in PreviewScrips
      create menu items only if we load a valid object
      fix indent after commit fb13e4d

Emmanuel Lacour (3):
      Allow adding users to groups when creating RT users with rt-setup-database
      Sort CF by name in query builder (closes: #16437)
      Don't run scrips for reminders on ticket queue changes

Jesse Vincent (2):
      Refactor RT::Ticket->SetOwner to be a bit easier to override
      Remove an extraneous "my" that caused warnings.

Jim Berry (1):
      Add callbacks before and after ticket search results for extra UI

Jim Brandt (13):
      Adding tests for new upgrade history methods.
      Added ConnectToDatabase calls so the new history entries can be added to the DB. Noted where these might be removed if InsertData can stop disconnecting safely.
      Add component and version options to rt-setup-database for upgrade history
      Update articles documentation
      Improve error message when creating an Article before a Class
      Style change to move down Modify search link
      Add DECRYPTION_INFO to ignore_keywords.
      Add time as an option for iCal feed entries
      Provide time in iCal feed based on query param
      Add single event option to iCal feed
      Update ical tests for new ticket URLs
      Additional callbacks for mobile reply page
      Add cflabel to mobile style sheet

Kevin Falcone (66):
      Minor english frobs
      Add a --links-only
      stop hardcoding perl
      This is dead code from 2.1.11 that was never doc'ed or used
      Remove unused variables that were fallbacks in 3.8 and below
      Merge branch '4.2/remove-authenticate-method'
      Unroll this loop so we can do more work in it
      Add a dropdown to pick the Subject CF
      Store the results of picking your SubjectOverride
      Use the Process method to handle the default value value
      Better messages (not ids)
      Don't update when this is the already set value
      Move the setting into the library
      Redirect after we actually process everything
      Pass the Queue so that Articles can limit to it
      Add a second Articles hook to clobber Ticket Subjects.
      This should always be a Custom Field Id and thus a number
      Tests for subject overriding
      Add an add_after method
      Add an add_before method
      Merge branch '4.2/concise-missing-testdep'
      Merge branch '4.2/default-mail-precedence'
      Merge branch '4.2/links-in-validator'
      Merge branch '4.2/remove-attributes-withid'
      Merge branch '4.2/locale-maketext-fuzzy-bump'
      Merge branch '4.2/remove-externalauthinfo-stub-block'
      Merge branch '4.2/ticketsql-quoting'
      Merge branch '4.2/remove-cfqueues-wrong-unquoting'
      Merge branch '4.2/session-properties'
      Merge branch '4.2/validate-ssl-mailgate'
      Revert "should clear the message box if the message is recorded already"
      Merge branch '4.2/clean-jumbo-message-box'
      Merge branch '4.0-trunk'
      Remove some erroneous documentation added in 702d1fd
      This code was a runtime error
      Switch tests to check names of queues in addition to ids of queues
      Test that changing a Queue's name is reflected in the dropdowns
      Make a few checks case insensitive
      Hopefully the last variable rename from component to package
      Display the upgrade time in the current user's timezone
      Merge branch '4.2/upgrade-history'
      Merge branch '4.2/checkintegrity-warnings'
      Merge branch '4.2/disallow-ticket-creation-disabled-queue'
      Merge branch '4.2/extensible-acl-object-targets'
      Switch to using DECODED_ARGS
      Merge branch '4.2/sticky-simple-search'
      GPG 1.4.12 tweaked the header on the trustdb
      Merge branch '4.0/dashboard-mailer-dummy-error_headers_out' into 4.0-trunk
      Merge branch 'security/3.8/csrf-blacklist' into 3.8.15-releng
      Merge branch 'security/3.8/email-header-injection' into 3.8.15-releng
      Merge branch 'security/3.8/signing' into 3.8.15-releng
      Merge branch 'security/3.8/warn-about-redirect-after-login' into 3.8.15-releng
      bump version for 3.8.15
      Merge branch '4.0.8-releng' into 4.0-trunk
      Merge branch '3.8.15-releng' into 3.8-trunk
      Merge branch '3.8-trunk' into 4.0-trunk
      Merge branch '4.0-trunk'
      Pull in updates from launchpad
      Merge branch '4.0/loc-escape-squares' into 4.0-trunk
      Fold our upgrades tests into the code policy tests
      Update upgrades written since this branch was created
      Merge branch '4.0/update-subject-after-extractid' into 4.0-trunk
      Rename this to be less confusing
      Remove the ProcessTicketCustomFieldUpdates backcompat wrapper
      Merge branch '4.2/silence-test-warnings'
      Merge branch 'security/4.0/tests' into 4.0-trunk

Paul Tomblin (1):
      Add a name to one of the two "Default" callbacks in Logout

Ruslan Zakirov (149):
      we work with one DB type at a time, use elsif
      factor out RT::Config::__GetNameByRef into Symbol::Global::Name
      validate links
      cache user preferences
      calculate attachment's length on create and store
      fix typo
      look only at correct links when checking LocalX
      don't validate "LocalX =~ X" for MergedInto links
      SQLite's concatenation is ||
      %WebSessionProperties option - more backends can be used
      adjust Test::Builder's level
      localize watcher's name for BriefDescription of txns
      Revert "adjust Test::Builder's level"
      if LANG is not english then tests got confused
      Merge branch '4.0-trunk'
      redirect if we have results
      drop __Relates and friends
      use lookahead in s/// instead of while loop
      make labels (aka object names) less restrictive
      Merge branch '4.2/allow-status-change-in-inactive-set-with-unresolved-deps'
      Don't encode folded headers, such as Subject
      Merge branch '4.2/mailgate-errors'
      Merge branch '4.2/load-menus-sooner'
      load module after importing everything
      Extract concept of many-to-many association and sorting
      Rename ApplyAndSort to AddAndSort, as "Apply" already has meaning in RT
      Unify global and queue-specific scrip administration pages
      Use new AddAndSort interface to apply scrips to multiple queues
      Update the validator to understand ObjectScrips
      sort scrips in initialdata by description
      We don't need to separate out the list of global scrips
      Allow scrips to be reordered and deleted in the web UI
      Pass all arguments through for tables with additional columns
      Move Stage to being a property of ObjectScrips, not Scrips
      Disabled column map for scrips
      shrink number of lines of code
      Add missing closing tag (</select>)
      process stage when we apply scrips to queues
      check rights when we add/remove scrips to/from queues
      make sure we pass id further, not a string
      check that template exists when we add scrip
      tidy test file
      test adding/removing scrips from queues
      Add ->IsGlobal method on Scrips and CFs, as an alias for ->IsAdded(0)
      add Admin/Scrips/ dir with index
      Split turn EditScrip into Create and Modify pages
      Admin/Scrips/Objects.html page
      turn open function call into @Final
      delete empty upgrade/*/content files
      test upgrade/*/content files
      use strict and warnings in ever upgrade/*/content
      avoid used only once warnings
      $tmp was never defined in upgrade/3.8.2/content
      mark data arrays with 'our'
      mark $action with 'my'
      add a few 'my' into declarations
      avoid "used only once" warning
      Move to a template picker that accounts for multiple queues
      test basics of administrating scrips
      make sure disabled scrips are not executed
      Upgrade scripts for new schema
      apply scrip to multiple queues from initialdata
      Documentation for the new ApplyAndSort API
      Scrip and CF ->IsAddedToAny methods
      Force CF "Disabled" flag into a 0/1 boolean
      Add deprecated Apply* methods to CustomFields for back-compat
      ::Test::Web->dom method that return Mojo::DOM
      use messages returned by ValidateCustomFields
      names for forms on Ticket's pages
      add Groups related methods to RT::CustomField[s]
      Group argument in {Show,Edit}CustomFields comps
      pass all arguments from Tickets's ShowCustomFields
      show custom fields in different places in UI
      don't render any wrappers if content is empty
      split editing CFs into groups
      add CFs processing to pages where we need it
      test custom field groups
      mark BUILTIN_GROUPS as our for potential extensions
      put group name into title of the box
      add ticket-info-cfs-group class to title boxes
      add generic /Elements/EditCustomFields
      /Elements/EditCustomFieldCustomGroups
      deprecate /Ticket/Elements/EditCustomFields
      add a new argument in LimitToGroup
      custom field groups for Users
      indent and minor refactoring
      minor refactoring
      Attachments and TextAttachments for all records in the system
      Attachments and TextAttachments customizations for tickets
      replace mason comp with new methods
      use new method, other code there we have is messy
      first pass on generic ShowHistory, still on ticket's ShowTransaction
      introduce RecordType and deprecate ObjectTypeStr
      use Object->RecordType in Txn->FriendlyObjectType
      Record's ClassifyTransaction method
      generate default paths using $m->request_path
      first implementation of ShowTransaction
      use new ShowTransaction instead of ticket's
      FriendlyContentLength method for RT::Attachments
      delete variables we don't use
      escape filename for title/alt and add it the end of URL for download
      announce record type as CSS class on history wrapping div
      use <record type>-<id>-history id for history wrapper
      move <div class="history <% lc $record_type %>"> out of if clause
      return error asap from RT::Attachment->Create
      use new Attachments retrieving API instead of comps
      make CSS classes ticket-agnostic
      organize pre-fetched attachments like we need them later
      change Template column in Scrips from id to Name
      we don't need `require`s as we have `use`s
      a test was deleted when .t files were merged
      make sure we can not create templates with duplicate names
      make sure we can not create template without name
      test that we can change template name
      make sure tmpl's name can't be set to empty or duplicate
      make sure we can not change template's queue
      RT::Template->LoadByName method
      more details in an error message
      undef as default Template arg in Scrip->Create, not 0
      IsEmpty column map for templates
      $tmpl->UsedBy, $scrips->LimitByTemplate methods and UsedBy ColumnMap
      show UsedBy and IsEmpty columns in templates AdminUI
      tidy, no code change, tiny doc changes
      pass arguments further to Action
      these DESTROY methods are useless
      drop RT::Action->IsApplicable
      we don't need to set $self->{'table'}
      upgrade step for Template column in Scrips table
      change how we pass template to RT::Action::*
      check template harder in RT::Scrip->Create
      test Templates in scrips' admin UI
      improve picking template for a scrip
      make sure you can not delete template in use
      fix shredding templates
      validator fix: Template in Scrips now references Name
      page menu links on /Admin/Scrips/Create.html
      match policy
      self-redirect Jumbo page after update
      return error message when we fail to set disabled
      switch shredder's tests over RT::Test
      delete all links while shredding
      make sure validator exits with meaningful exit code
      move run_validator into RT::Test
      check exit code when we expect DB to be invalid
      validate database in tests after each wipeout
      RenderMenu in libs instead of Menu component
      Merge branch '4.0/articles-doc-updates-plus-fixes' into 4.0-trunk
      Merge branch '4.0/case-insensitive-null' into 4.0-trunk
      shred {Add,Del}Watcher transactions with Principal

Shawn M Moore (62):
      Begin renaming summary to sidebar
      Rename summary to sidebar in initialdata
      Fix sidebar in admin UI for other users
      Upgrade script for user prefs
      Skip updating user prefs when there's a sidebar already
      Upgrade the default HomepageSettings too
      Merge branch 'rt-at-a-glance-renames' into 4.1-trunk
      Bump the version on the rt-at-a-glance-renames upgrade dir
      Case fix
      Remove punctuation to combine loc strings
      Permission Denied is the canonical casing
      Implement goto_create_ticket('General')
      Given lifecycles this is a needless lie
      Missing frequency display for m-f
      Refactor the store in session and pull from global config logic
      dashboards_in_menu can be a empty hashref when you Reset your pref
      Manage session{'dashboards_in_menu'} only in /Elements/Tabs
      Merge branch '4.2/per-user-dashboards-in-menu'
      These are brackets not braces
      Ticket->IsBookmarked
      First pass at Ticket->ToggleBookmark
      Various tidyings
      Make IsBookmarked on a merged ticket work again
      Pull out $bookmarks, reuse $id
      Just always push on the Merged list
      Don't frob Bookmarks config directly in a test
      Refactor ->Bookmarks into RT::User
      Use User->Bookmarks in ShowSearch and m/tickets/search
      Move Ticket->IsBookmarked and ->ToggleBookmark to RT::User
      Typo fix in RT_SiteConfig doc
      Drop IgnoreMissing from ShowSearch on RT at a Glance
      Validate portlets against HomepageComponents
      Move Predence defaulting closer to where we actually send email
      Test to ensure that we actually did rename the saved search
      Include the dashboard name in update messages
      Test that the aggressive caching happens with dashboard names too
      Merge branch '4.2/dashboard-search-cache'
      Merge branch '4.2/centralize-develmode'
      Revert "Move loading and calling of Module::Refresh to only one codepath"
      Remove unused ARGS block from autohandler
      Add Tickets->LimitActiveStatus and LimitInactiveStatus
      Use LimitActiveStatus in place of its definition
      Rename to LimitTo(Inactive|Active)Status for clarity
      Use a match instead of a substitution
      Assign capture groups and pull out the last as $id
      Update language handle *before* generating results messages
      Tests for language update results being in the new (not old) language
      Remove a runaway code fold
      Remove vestigial, guarded calls to a "SetOriginObj"
      RT->System->AddUpgradeHistory('RT', {...})
      UpgradeHistory for reading upgrade history
      Always include the rt_version we're using to upgrade
      First cut of adding history during an upgrade
      Add upgrade notes for each intermediate point upgrade too
      upgrade history for inserting initialdata
      Add before/after information for each upgrade history entry
      Include before history for point upgrades, after history for the full upgrade
      Begin displaying RT upgrade history in sys config
      Add an extra column, and for upgrade display the versions
      Need to initialize RT->System before adding upgrade history
      Be more specific for upgrades
      Include the content of the file we use for the insert action

Thomas Sibley (204):
      Rename $LogToScreen to $LogToSTDERR, but maintain back compat
      Ignore the new upgrade-articles script
      Make sure we have an RT::System object before using it - #16348
      Actually tell the user what queue we couldn't load
      Remove old, never used references to %T::X meant to be filled in by the template
      Pick theme colors directly from the logo
      Merge branch '4.2/update-subject-from-article'
      Preserve the current simple search query for easier refinement
      Allow the browser to remember past simple searches
      Scrub javascript from dashboard emails rather than relying on imperfect flags
      Initialize menus as soon as possible
      Start of documentation for the initialdata format
      Finish documenting all other data structures in initialdata files
      Document RT::Queue as a valid LookupType in RT::CustomField
      Rename and comment test file for a more accurate description
      Anonymous basic auth support in tests
      Note the most frustrating current limitations of initialdata files
      Provide a more helpful error from rt-mailgate when the POST fails
      Failing tests for deauthenticating when REMOTE_USER disappears
      Cleanup WebExternalAuth handling
      Deauthentication under continuous external auth with internal fallback
      Move the signature and reset auth token boxes into the columns
      Two-step process to reset your AuthToken
      Standard error pages for all reasons we abort external auth
      Ignore REMOTE_USER if we're logged in with internal auth
      Refactor the generation of login tangent links
      Tests for the WebExternalAuto and AutoCreate options
      Allow Privileged and Disabled to be set from WebExternalAutoInfo()
      Document the various external authentication solutions
      Refactor setting an Authorization header into RT::Test::Web
      Move logged_in_as into RT::Test::Web instead of copying parts of ->login
      Reference the new external auth docs from an error message
      Wordsmithing from Jim and I for clarity
      Reorganize the authentication docs with better headings
      Update doc pointer in authentication error
      Consistently use "internal" to describe RT's own authentication
      Global availability for all object types on which rights can be granted
      Remove support for $LinkTransactionsRun1Scrip
      Code formatting, no functional changes
      Move creation of link transactions from RT::Ticket into RT::Record
      Refactor our link type and direction maps into RT::Link
      Parsing OCFV form args into a data structure is useful in future functions
      Split OCFV normalization into a separate function for general use
      Consolidate parsing OCFV form args into Create parameters for new records
      Validate the ContextObject to assure correct behaviour
      Use a valid ContextObject during article creation
      Return ACLEquivalenceObjects rather than manually specifying EquivObjects for HasRight
      The new child effectively replaces the current child in the sort_order
      Refactor the guts of add_after and add_before into a single private method
      Sorting tests for the RT::Interface::Web::Menu API
      Display date format options in the user's timezone
      Merge branch '4.2/pass-apache-tests'
      Remove the factory script for generating classes based on the database
      Backup documentation covering the database and filesystem
      cache_self doesn't play nice with our use of flush_buffer; remove it
      Turn relative paths into absolute paths for Apache
      WebExternalOnly was renamed to WebFallbackToInternalAuth
      Intuit the next page when logging in at the RT web root
      Abstract away reading $session{NextPage} into two functions
      Anticipate storing more information about the next page in the session
      Check the original request for side-effects before prompting for login
      Blacklist components from automatic, argument-based CSRF whitelisting
      Log SQL queries under the true request path rather than Mason component
      Log SQL queries right before we abort a request
      Headers in the parsed MIME entities of Templates are modifiable
      Comment on our invalid pattern for splitting headers
      Perltidy only before updating the SetHeader method
      No need to match on the rest of the header line(s), just the tag
      Don't require a \r before the \n when forcing header continuations
      Refactor header value canonicalization for use by other methods
      Fix three bugs in SetHeader
      Let MIME::Head modify the X-RT-GnuPg-Status header to handle continuations
      Inform the user logging in about potential side-effects
      Include the potential request's action in the CSRF interstitial
      Don't 500 if we come across a session with NextPage of the old variety
      Remove hardcoded duplicate types from CreateTickets.pm
      Support singular link types for ticket creation
      Use our link maps instead of hardcoding link type pairs
      Refactor processing %ARGS for new links during record creation
      HTML::RewriteAttributes version 0.05 fixes dashboard email display in Outlook
      Merge remote tracking branch 'cloos/4.2/squelch_note'
      Merge branch '4.0/bulk-update-datetime' into 4.0-trunk
      Merge branch '4.0/clear-callback-cache-in-inline-tests' into 4.0-trunk
      Merge branch '4.0/invalid-queue-cache-on-name-change' into 4.0-trunk
      Merge branch '4.0/encoded-word-whitespace' into 4.0-trunk
      Merge branch '4.0/display-actions-on-abort' into 4.0-trunk
      Remove bogus stray line from the Slovenian translation
      Match /l_unsafe when extracting strings for localization
      Merge branch '4.0/code-policy' into 4.0-trunk
      Merge branch '4.2/drop-validation-bits-from-shredder'
      Note when to use --default-character-set=binary for MySQL backups
      Merge branch '4.0-trunk'
      Adhere to new code policy test from 4.0-trunk
      Merge branch '4.2/remove-dashboard-javascript-flag'
      Merge branch '4.0/stop-escaping-quote-in-pod' into 4.0-trunk
      Failing tests for square brackets in a system saved search
      Refactor loc-safe escaping of saved search descriptions
      Escape saved search descriptions for loc() when editing per-user Format prefs
      Merge branch '4.0/interface-in-headers' into 4.0-trunk
      Merge branch '4.0/search-result-callbacks' into 4.0-trunk
      Return an empty OCFVs object from $CF->ValuesForObject if $CF isn't loaded
      Shred ObjectScrip records when shredding a Scrip
      Better heading for TransactionCreate scrips and short explanatory text
      Display Normal and Batch instead of TransactionCreate and TransactionBatch
      Tests: Add a helper method to check a scrip's ObjectScrips records
      Tests: Ensure scrips can't be applied both globally and to individual queues from the UI
      Disable selection of individual objects when "apply globally" is checked
      Turn the apply globally checkbox labels into real clickable <label>s
      Grab the parent form and checkbox state from the current element in setCheckbox()
      setCheckbox()es within the closest form _or_ collection list
      Merge branch '4.2/strict-upgrade-scripts'
      Merge remote-tracking branch 'cloos/4.0/validate-menu-load-obj' into 4.0-trunk
      Stricter checking for a valid CustomFieldGroups config when using it
      Validate the CustomFieldGroups config option after the config is loaded
      Correct typo resulting in no current user for the fallback value
      Replace more uses of the now-deprecated /Ticket/Elements/EditCustomFields
      Avoid an uninitialized warning triggered by new user creation
      ShowCustomFieldCustomGroups element to match the element for Edit
      Refactor built-in custom field grouping registration into a method
      Extend rather than override existing built-in groupings for an object class
      Remove unimplemented Group method
      Rename custom field "group" concept to "groupings"
      Typo caused intepolation of non-existent variable
      Document the new CF grouping config and methods
      Refactor calculation of the grouping record class to use
      Move CustomGroupings closer to Groupings so the documentation is adjacent
      RT::CustomField->Groupings should always return built-in groupings
      Allow Groupings and CustomGroupings to be called as class methods
      Replace form_name/input/click pattern with a simple usage of submit_form_ok
      Use the IsOnlyGlobal method instead of matching the LookupType directly
      Show the stage selector for global scrips
      Split use strict and warnings onto separate lines for master's policy test
      Merge branch '4.2/apply-scrips-to-multiple-queues'
      Catch specific warnings emitted by three test files
      TODO failing tests instead of skipping them
      Provide a Create link when viewing the "all scrips" page
      Filter down from all readable columns rather than hardcode a list
      Add comment about a potential perf improvement when listing attachments
      Remove the AttachmentUnits option and use FriendlyContentLength instead
      Remove support for intermixing transactions from multiple tickets in history
      Respect the OldestTransactionsFirst preference under Self Service …
      Use validation results returned by ValidateCustomFields
      Only link relationship labels to ticket searches when editing ticket links
      Provide a callback for extensions to modify the relationship label link
      ShowLinks: Consolidate generation of Clone links and use RT::Link API
      ShowLinks: Construct clone links only if the current user can CreateTicket
      ShowLinks: Work with any object that isa RT::Record, not just RT::Ticket
      ShowLinks: Refactor to remove a lot of repetition
      ShowLinksOfType: Add a callback to allow changing $Recurse and $MaxDepth
      ShowLinks: Sort links in all relationship types as not tickets, active, or inactive
      ShowLinks: Not all RefersTo links have a LocalTarget; weed out undefined values
      Embed config and current user data into each page for javascript
      Convert tabs to spaces; whitespace only change
      LimitToRolesForTicket never worked because of non-interpolating single quotes
      Handling roles on arbitrary objects in the rights editor
      Automatic friendly descriptions for arbitrary role groups
      Convenience method to load arbitrary role groups based on an object
      CreateRoleGroup can take an Object in place of Domain and Instance
      Don't assume new role groups are for tickets/queues
      Implement RT::Queue's methods about roles using the new methods of RT::Group
      Refactor role registration metadata into RT::Record
      HasRole method to check role existence on a class
      Bail out of LoadRoleGroup if the object passed is unloaded
      Require Instance (even if it's 0) when creating a new role group
      Block duplicate role group creation
      Set system role groups' Instance to RT->System->id
      Group.Instance is numeric, drop quoting and incorrect comment
      Document transaction requirement of CreateRoleGroup and follow our own advice
      Refactor role group check on Principal into a public method
      Sort object types for stability when combining ACE hashes
      Restrict rights granted to system role groups
      Basic tests for variable AvailableRights
      Move unused role data structure used for l10n closer to role registration
      Remove nonsensical rights granted to system role groups
      Convenience method for loading role groups on records
      Convenience methods to add/delete members from record role groups
      Include Real Name in the JS CurrentUser info
      License tag the new JavascriptConfig component
      Merge branch '4.2/config-in-js'
      Parity with the latest versions of ShowHistory and ShowTransaction
      Use relative links in history rather than guessing the current page
      Force history display when toggling header mode
      Add an AfterContent callback to ShowTransaction
      Fully replace ticket-specific history display with generic components
      Fix rendering regression introduced by removing nested .transaction divs
      Replace Articles' history component with the new generic one
      Remove unused FindAttachments component
      Replace /Ticket/Elements/FindTransactions with RT::Record->SortedTransactions
      Link the Last Updated timestamp to a specific transaction
      Move history styles into the base theme
      Use .transaction instead of div.history-container
      WebHomePath column map for use in hrefs inside search Formats
      Fix tests to follow links relative to the current page, not the server base
      Record a txn on the RT::Record object when adding or removing a role member
      Validate that PrincipalId is actually passed to DeleteRoleMember, as doc'd
      Merge branch '4.2/extensible-roles'
      Stay at the top of the history when toggling full/brief headers
      Merge branch '4.0/custom-scrip-trailing-newline' into 4.0-trunk
      Merge branch '4.0/make-date-tests-locale-independent' into 4.0-trunk
      Merge branch '4.0/terse-textarea-updates' into 4.0-trunk
      Merge branch '4.0/simple-template-permission' into 4.0-trunk
      Merge branch '4.0/pg-fts-invalid-character' into 4.0-trunk
      Merge branch '4.0/page-menu-overlap' into 4.0-trunk
      Merge branch '4.2/unowned-create'

Tim Cutts (3):
      err_headers_out method for fake web request object
      Make fake web request methods safer
      Re-read Subject from Message after ExtractTicketId

sunnavy (61):
      5.5 only supports Engine='...', it's good 4.1 also supports that
      forgot upgrade file, also use all caps
      RT->System is not inited if we are in install mode
      trs already fixed this in 4.0-trunk.
      respect RT_SITE_CONFIG for installer
      allow RT->LoadConfig to load RT_SiteConfig.pm again and again in case it's updated
      allow load RT_SiteConfig.pm again and again by default
      site config file is not always etc/RT_SiteConfig.pm
      add zh_CN support in tests
      tests for /Install/
      test SendmailPath
      more test about OwnerEmail
      it should be mobile login page if from mobile
      mobile ui tests
      to select/deselect all the queues with one click for Quicksearch
      $m->scomp() just returns the content, instead of showing it($m->comp does this)
      simple cf tests for mobile ui
      new DashboardsInMenu config pages
      make words consistent
      dashboards-in-menu test
      apparently we messed up return values of Ticket->Create
      show reminder added msg only if it was added successfully
      it's good to show users the action results
      don't show reminders in ticket page unless the user has ModifyTicket right
      reminders permission test
      safer to do permission check in the lib api
      return more action results to page
      we should always show reminders link if with EnableReminders
      permission check fix to reminders page
      RT::Ticket will check the rights for us, no need to check here
      always send checkbox's value to make ProcessTicketReminders() happy
      each reminder can have multiple result messages
      readonly subject and due if without ModifyTicket permission
      move hidden checkbox input to td to make ui looks better
      sync tests for reminders permission update
      more reminder permission tests
      better test file name
      reminder permissions test in api level
      more reminder permission tests
      hide cf Objects page for User/Group as Enable/Disable is enough in this case.
      allow to set inactive status with unresolved deps if current status is inactive
      fix the loc of "group by" in search chart page by joining the sperated loc-ed words
      simplify Queue Lifecycle column's logic to avoid empty values
      test queue's lifecycle change in admin ui
      upgrade script to update queue lifecycle column from null to "default"
      margin-left ".edit-custom-field .entry" to fix the alignment bug in #19518
      upgrade lifecycle to "default" for values like 0 or empty string
      handle ref values right when they are set multiple times in config files
      pricipal name is more clear than literal "principal" in return message
      clean session lock files ourselves
      make "NULL" case insensitive in sql
      test for lower cased null
      code policy test
      update code to meet code policy
      test and fix devel tools to meet code policy too
      "[" and "]" need to be escaped in loc
      return the unescaped string if it's not in .po
      remove limitation of cf name in rest
      we use "," to split fields, so "," can't be allowed
      non-greedy regex is more right in splitting cf's name and value
      test cf name edge cases in rest

-----------------------------------------------------------------------


More information about the Rt-commit mailing list