[Rt-commit] rt branch, 4.0/mobile-login, updated. rt-4.0.8-261-g34bd21a

Thomas Sibley trs at bestpractical.com
Mon Dec 31 20:04:16 EST 2012


The branch, 4.0/mobile-login has been updated
       via  34bd21a256b1a8c17848b73b33db7d56821d3323 (commit)
       via  260239ee9bce09b62d45e2bc89a4b0ea4e570d8d (commit)
      from  4b1ddff04fee8f495050505c97f5734bedce2b19 (commit)

Summary of changes:
 share/html/NoAuth/Login.html       |  2 +-
 share/html/m/{ => _elements}/login | 18 ++++--------------
 2 files changed, 5 insertions(+), 15 deletions(-)
 rename share/html/m/{ => _elements}/login (89%)

- Log -----------------------------------------------------------------
commit 260239ee9bce09b62d45e2bc89a4b0ea4e570d8d
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Dec 31 16:43:22 2012 -0800

    Only preserve the next and mobile query params on mobile login
    
    Preserving the rest is a relict of the previous login behaviour without
    redirects.

diff --git a/share/html/m/login b/share/html/m/login
index f956bac..2e638ee 100644
--- a/share/html/m/login
+++ b/share/html/m/login
@@ -76,19 +76,8 @@
 
 <& /Elements/Submit, Label => loc('Login')&>
 
-% foreach my $key (keys %ARGS) {
-%  if ( $key !~ /^(?:user|pass|actions)$/ ) {
-% 	if (ref($ARGS{$key}) =~ /ARRAY/) {
-% 		foreach my $val (@{$ARGS{$key}}) {
-<input type="hidden" class="hidden" name="<%$key %>" value="<% $val %>" />
-% 		}
-% 	}
-%	else {
-<input type="hidden" class="hidden" name="<% $key %>" value="<% $ARGS{$key} %>" />
-% 	}
-%  }
-% }
-</form>
+<input type="hidden" name="next" value="<% $next %>" />
+<input type="hidden" name="mobile" value="1" />
 
 <script type="text/javascript">
 if (window.location.hash) {
@@ -109,4 +98,5 @@ $user => ""
 $pass => undef
 $goto => undef
 $actions => undef
+$next => ""
 </%ARGS>

commit 34bd21a256b1a8c17848b73b33db7d56821d3323
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Dec 31 16:46:09 2012 -0800

    Move /m/login into /m/_elements/ for consistency with /Elements/Login

diff --git a/share/html/NoAuth/Login.html b/share/html/NoAuth/Login.html
index b5054fb..913d805 100644
--- a/share/html/NoAuth/Login.html
+++ b/share/html/NoAuth/Login.html
@@ -51,7 +51,7 @@ $ARGS{'actions'} = [$msg] if not $good and $msg;
 </%init>
 
 % if ( RT::Interface::Web::MobileClient() || $ARGS{mobile} ) {
-<& /m/login, %ARGS &>
+<& /m/_elements/login, %ARGS &>
 % } else {
 <& /Elements/Login, %ARGS &>
 % }
diff --git a/share/html/m/login b/share/html/m/_elements/login
similarity index 99%
rename from share/html/m/login
rename to share/html/m/_elements/login
index 2e638ee..0478f9a 100644
--- a/share/html/m/login
+++ b/share/html/m/_elements/login
@@ -91,7 +91,7 @@ if (window.location.hash) {
 </&>
 </div><!-- #login-box -->
 </div><!-- #login-body -->
-<& _elements/full_site_link &>
+<& /m/_elements/full_site_link &>
 </&>
 <%ARGS>
 $user => ""

-----------------------------------------------------------------------


More information about the Rt-commit mailing list