[Rt-commit] rt branch, 4.0/transactionbatch-currentuser-leak, updated. rt-4.0.6-219-g2ccd7ec

Kevin Falcone falcone at bestpractical.com
Fri Jun 29 14:53:02 EDT 2012


The branch, 4.0/transactionbatch-currentuser-leak has been updated
       via  2ccd7ec11c3b862493eaee418c02a8af157c6281 (commit)
      from  c656be23e06a8cdc6f411673873a47ac878f0a97 (commit)

Summary of changes:
 lib/RT/Ticket.pm |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

- Log -----------------------------------------------------------------
commit 2ccd7ec11c3b862493eaee418c02a8af157c6281
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Jun 29 14:47:57 2012 -0400

    Remove some repeated code.
    
    DESTROY was doing very similar code to ApplyTransactionBatch
    so just call ApplyTransactionBatch

diff --git a/lib/RT/Ticket.pm b/lib/RT/Ticket.pm
index 0a4bb24..28f1e36 100644
--- a/lib/RT/Ticket.pm
+++ b/lib/RT/Ticket.pm
@@ -3392,11 +3392,7 @@ sub DESTROY {
         return;
     }
 
-    return if $self->RanTransactionBatch;
-    my $batch = $self->TransactionBatch;
-    return unless $batch && @$batch;
-
-    return $self->_ApplyTransactionBatch;
+    return $self->ApplyTransactionBatch;
 }
 
 

-----------------------------------------------------------------------


More information about the Rt-commit mailing list