[Rt-commit] rt branch, 4.2/apply-scrips-to-multiple-queues, updated. rt-4.0.8-461-g873e6bf

Alex Vandiver alexmv at bestpractical.com
Wed Nov 14 11:52:47 EST 2012


The branch, 4.2/apply-scrips-to-multiple-queues has been updated
       via  873e6bf6c3fde236df9c3e4b151342bf1b05ea99 (commit)
      from  e168ad8f10451250f79e8bbc47d655e50c4ca9df (commit)

Summary of changes:
 share/html/Elements/Tabs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 873e6bf6c3fde236df9c3e4b151342bf1b05ea99
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Nov 1 15:47:31 2012 -0700

    Use the IsOnlyGlobal method instead of matching the LookupType directly
    
    IsOnlyGlobal provides a consistent single place to determine if a CF is
    always global.  This is particularly important for extensions adding new
    LookupTypes which may also be global only.

diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index d32e1da..280bc3c 100644
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -356,7 +356,7 @@ my $build_admin_menu = sub {
             $tabs->child( basics           => title => loc('Basics'),       path => "/Admin/CustomFields/Modify.html?id=".$id );
             $tabs->child( 'group-rights'   => title => loc('Group Rights'), path => "/Admin/CustomFields/GroupRights.html?id=" . $id );
             $tabs->child( 'user-rights'    => title => loc('User Rights'),  path => "/Admin/CustomFields/UserRights.html?id=" . $id );
-            unless ( $obj->LookupType =~ /^RT::(?:User|Group)$/ ) {
+            unless ( $obj->IsOnlyGlobal ) {
                 $tabs->child( 'applies-to' => title => loc('Applies to'),   path => "/Admin/CustomFields/Objects.html?id=" . $id );
             }
         }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list