[Rt-commit] rt branch, 4.2/route-actions-via-update-page, created. rt-4.1.6-406-g7d89942

Ruslan Zakirov ruz at bestpractical.com
Wed Apr 17 13:44:43 EDT 2013


The branch, 4.2/route-actions-via-update-page has been created
        at  7d89942dfeb2567d9fd3945d3c3715809be4fcb9 (commit)

- Log -----------------------------------------------------------------
commit 7d89942dfeb2567d9fd3945d3c3715809be4fcb9
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Sun Jul 15 20:16:56 2012 +0400

    point all status change actions to Update.html
    
    Quick actions are now routed to Display.html. It makes
    harder to implement variouse extensions that require
    users to fill CFs/core fields/etc when status is changed.
    
    These quick links should fall through Update.html to
    Display.html in vanilla RT and stay backwards compatible.

diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index a2f7743..52ab883 100644
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -668,20 +668,13 @@ my $build_main_nav = sub {
 
                     my $action = $info->{'update'} || '';
                     my $url = '/Ticket/';
-                    if ($action) {
-                        $url .= "Update.html?"
-                            . $query_string->(
-                                Action        => $action,
-                                DefaultStatus => $next,
-                                id            => $id,
-                            );
-                    } else {
-                        $url .= "Display.html?"
-                            . $query_string->(
-                                Status => $next,
-                                id     => $id,
-                            );
-                    }
+                    $url .= "Update.html?". $query_string->(
+                        $action
+                            ? (Action        => $action)
+                            : (SubmitTicket  => 1, Status => $next),
+                        DefaultStatus => $next,
+                        id            => $id,
+                    );
                     my $key = $info->{'label'} || ucfirst($next);
                     $actions->child( $key => title => loc( $key ), path => $url);
                 }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list