[Rt-commit] rt branch, 4.0/queue-summary-status-casing, created. rt-4.0.17-69-g5a55798

Alex Vandiver alexmv at bestpractical.com
Wed Aug 7 11:46:16 EDT 2013


The branch, 4.0/queue-summary-status-casing has been created
        at  5a5579867ae459ce3c55571450a501220ba9b3a8 (commit)

- Log -----------------------------------------------------------------
commit 5a5579867ae459ce3c55571450a501220ba9b3a8
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Aug 7 11:40:50 2013 -0400

    Fix queue summary ("Quick Search") with non-lowercase statuses
    
    798505e forced statuses to be stored in lower-case in the database.
    However, the loop in QueueSummaryBy... stored the counts from the GROUP
    BY (which are lower-case) in a hash, and looked them up by canonical
    case -- resulting in "-"s displayed for all non-lowercase statuses.
    
    Add the necessary lc() calls in the hash lookups to find the grouped
    results.

diff --git a/share/html/Elements/QueueSummaryByLifecycle b/share/html/Elements/QueueSummaryByLifecycle
index 44d6b5a..df5983c 100644
--- a/share/html/Elements/QueueSummaryByLifecycle
+++ b/share/html/Elements/QueueSummaryByLifecycle
@@ -75,7 +75,7 @@ for my $queue (@queues) {
 
 %   for my $status (@cur_statuses) {
 <td align="right">
-    <a href="<% $link_status->($queue, $status) %>"><% $data->{$queue->{id}}->{$status } || '-' %></a>
+    <a href="<% $link_status->($queue, $status) %>"><% $data->{$queue->{id}}->{lc $status} || '-' %></a>
 </td>
 %   }
 </tr>
diff --git a/share/html/Elements/QueueSummaryByStatus b/share/html/Elements/QueueSummaryByStatus
index 2a8dc53..65a823e 100644
--- a/share/html/Elements/QueueSummaryByStatus
+++ b/share/html/Elements/QueueSummaryByStatus
@@ -72,7 +72,7 @@ for my $queue (@queues) {
    if ( $lifecycle->IsValid( $status ) ) {
 </%perl>
 <td align="right">
-    <a href="<% $link_status->($queue, $status) %>"><% $data->{$queue->{id}}->{$status } || '-' %></a>
+    <a href="<% $link_status->($queue, $status) %>"><% $data->{$queue->{id}}->{lc $status} || '-' %></a>
 </td>
 %   } else {
 <td align="right">-</td>

-----------------------------------------------------------------------


More information about the Rt-commit mailing list