[Rt-commit] rt branch, 4.0/queue-names-in-customfield-listing, created. rt-4.0.17-76-g126e8ac

[Kevin Falcone]

The branch, 4.0/queue-names-in-customfield-listing has been created
        at  126e8ac461e09e90fba0bbb574a871e4e534d85d (commit)

- Log -----------------------------------------------------------------
commit 126e8ac461e09e90fba0bbb574a871e4e534d85d
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Mon Aug 12 15:33:58 2013 -0400

    The AdminSearchResultFormat for CustomFields used can()
    
    Since our ::Records are made of AUTOLOAD, can() fails until someone
    calls ->Name on a Queue.  /Admin/CustomFields/ would show Applied #3
    sometimes for a Queue until every rt-server process had called
    $queue->Name.
    
    RT has had a way to work around this forever, and now that 4.0-trunk
    actually calls all _BuildAccessible on all our classes, we should just
    use _Accessible.

diff --git a/share/html/Elements/RT__CustomField/ColumnMap b/share/html/Elements/RT__CustomField/ColumnMap
index 9df091d..9a3f377 100644
--- a/share/html/Elements/RT__CustomField/ColumnMap
+++ b/share/html/Elements/RT__CustomField/ColumnMap
@@ -104,7 +104,7 @@ my $COLUMN_MAP = {
                 $res .= ', ' if $res;
 
                 my $id = '';
-                $id = $record->Name if $record->can('Name');
+                $id = $record->Name if $record->_Accessible('Name','read');
                 $id ||= "#". $record->id;
                 $res .= $id;
 

-----------------------------------------------------------------------