[Rt-commit] rt branch, 4.2/cf-limits-with-role-rights, repushed

[Alex Vandiver]

The branch 4.2/cf-limits-with-role-rights was deleted and repushed:
       was 90c8ecc8b66c99a6994c104a00628e64659f3af0
       now a4c8bfa4cbbe1744f79bcb5fa9c78da83733648c

1:  717c30d = 1:  717c30d Switch two locations which call ->Type directly to examining $type
2:  90c8ecc ! 2:  a4c8bfa Avoid warnings and build better queries on CF limits with role rights
    @@ -28,6 +28,10 @@
              $cfkey ||= $cf->id;
          } elsif ($cf =~ /^\d+$/) {
     -        my $obj = RT::CustomField->new( $self->CurrentUser );
    ++        # Intentionally load as the system user, so we can build better
    ++        # queries; this is necessary as we don't have a context object
    ++        # which might grant the user rights to see the CF.  This object
    ++        # is only used to inspect the properties of the CF itself.
     +        my $obj = RT::CustomField->new( RT->SystemUser );
              $obj->Load($cf);
              if ($obj->id) {