[Rt-commit] rtir branch, 2.9/test-failures, created. 3.0.0rc1-32-geab0359

[Kevin Falcone]

The branch, 2.9/test-failures has been created
        at  eab0359b4bed861f27e5a2c06b146b57a25e05de (commit)

- Log -----------------------------------------------------------------
commit 8125e4f11a321fcdc47c1cbd3186bc159b65f9ed
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Jan 18 20:17:32 2013 -0500

    t/walk-web.t was failing because of undef warnings

diff --git a/html/RTIR/Create.html b/html/RTIR/Create.html
index 1be3ea7..83658dc 100644
--- a/html/RTIR/Create.html
+++ b/html/RTIR/Create.html
@@ -213,7 +213,7 @@
 %      Type => 'messages',
 %      Include => {'Create', 'Correspond'},
 %      QuoteText => $quote);
-%      $ARGS{Content} =~ s/\>/>/g;
+%      $ARGS{Content} =~ s/\>/>/g if $ARGS{Content};
 %   }
 % } else {
 %   $include_signature = 0;

commit eab0359b4bed861f27e5a2c06b146b57a25e05de
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Jan 18 20:17:59 2013 -0500

    Failing because we properly catch library warnings now
    
    4.0/actually-catch-test-warnings and 4.0/catch-test-file-warnings meant
    that any warnings thrown out of libraries (not just the server) during
    testing need to be accounted for.

diff --git a/t/020-incident-and-investigation.t b/t/020-incident-and-investigation.t
index 4e2f2da..b0efec0 100644
--- a/t/020-incident-and-investigation.t
+++ b/t/020-incident-and-investigation.t
@@ -3,7 +3,8 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 27;
+use RT::IR::Test tests => 28;
+use Test::Warn;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -51,7 +52,9 @@ $agent->display_ticket( $ir);
     my $inv = RT::Ticket->new( $RT::SystemUser );
     $inv->Load( $inv_id );
     ok $inv->id, 'loaded investigation';
-    is $inv->FirstCustomFieldValue('Classification'), undef, 'no classification CF for Invs';
+    warning_like {
+        is $inv->FirstCustomFieldValue('Classification'), undef, 'no classification CF for Invs';
+    } qr/Couldn't load custom field by 'Classification' identifier/, "Loading a non-applied CF warns";
     is $inv->FirstCustomFieldValue('IP'), '172.16.0.1', 'IP is here';
 }
 

-----------------------------------------------------------------------