[Rt-commit] rtir branch, 2.9-trunk, updated. 3.0.0rc1-36-g02af3f5

[Kevin Falcone]

The branch, 2.9-trunk has been updated
       via  02af3f5933d74adac08fd2567023c1a5c0a0d98b (commit)
       via  3de5d0eef085e0977c267069f9abbc0a61a2e261 (commit)
      from  8b4702f1ec143a7ae17b9e90671d8e1d832ed4c3 (commit)

Summary of changes:
 html/Callbacks/RTIR/Search/Elements/PickBasics/Default | 2 ++
 html/RTIR/Search/Elements/ProcessQuery                 | 7 -------
 2 files changed, 2 insertions(+), 7 deletions(-)

- Log -----------------------------------------------------------------
commit 3de5d0eef085e0977c267069f9abbc0a61a2e261
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Jan 25 16:04:05 2013 -0500

    Document some presumed intent for this callback.
    
    This means any Incident/Refine.html or other such pages don't have a
    Status or Queue option.

diff --git a/html/Callbacks/RTIR/Search/Elements/PickBasics/Default b/html/Callbacks/RTIR/Search/Elements/PickBasics/Default
index 8d1ff10..5a2dd61 100644
--- a/html/Callbacks/RTIR/Search/Elements/PickBasics/Default
+++ b/html/Callbacks/RTIR/Search/Elements/PickBasics/Default
@@ -1,4 +1,6 @@
 <%INIT>
+# I'm not sure why this isn't just "Only run on */Refine.html"
+# That would make the intent clearer.
 my $path = $m->request_comp->path;
 return unless $path =~ m{^/RTIR};
 return if $path =~ m{^/RTIR/Search/index.html};

commit 02af3f5933d74adac08fd2567023c1a5c0a0d98b
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Jan 25 22:55:37 2013 -0500

    We no longer need to do this weird dequoting dance.
    
    In RT's 8ba9858f we fixed GetReferencedQueues and removed all the core
    dequoting code.

diff --git a/html/RTIR/Search/Elements/ProcessQuery b/html/RTIR/Search/Elements/ProcessQuery
index eb32fe5..6d45231 100644
--- a/html/RTIR/Search/Elements/ProcessQuery
+++ b/html/RTIR/Search/Elements/ProcessQuery
@@ -156,13 +156,6 @@ if ( $BaseQuery ) {
     $queues = { %$queues, %{ $tree->GetReferencedQueues } };
 }
 
-# XXX: dequote queues hash
-# why we should do this? may be it's bug.
-foreach my $q ( keys %$queues ) {
-    next unless $q =~ /^['"](.*)['"]$/;
-    $queues->{ $1 } = delete $queues->{ $q };
-}
-
 # {{{ Deal with format changes
 my ( $AvailableColumns, $CurrentFormat );
 ( $query{'Format'}, $AvailableColumns, $CurrentFormat ) = $m->comp(

-----------------------------------------------------------------------