[Rt-commit] rt branch, 4.2/public-user-history, updated. rt-4.1.8-578-g1fc1376

Alex Vandiver alexmv at bestpractical.com
Mon Jul 1 16:02:50 EDT 2013


The branch, 4.2/public-user-history has been updated
       via  1fc13763715bcc52ee8cd4b663e1198e0b8abdb8 (commit)
      from  0e8a72352f4255785c6a30ef7ceb267564a40b60 (commit)

Summary of changes:
 lib/RT/User.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 1fc13763715bcc52ee8cd4b663e1198e0b8abdb8
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Jul 1 15:47:20 2013 -0400

    Recurse into CurrentUserCanSee as a refinement over "is it public"

diff --git a/lib/RT/User.pm b/lib/RT/User.pm
index 9101aab..d383d1f 100644
--- a/lib/RT/User.pm
+++ b/lib/RT/User.pm
@@ -1267,7 +1267,7 @@ sub CurrentUserCanSee {
     if ($what eq "Transaction" and $self->CurrentUserHasRight( 'ShowUserHistory' )) {
         my $type = $txn->__Value('Type');
         my $field = $txn->__Value('Field');
-        return 1 if $type eq "Set" and $self->_Accessible( $field, 'public' );
+        return 1 if $type eq "Set" and $self->CurrentUserCanSee($field, $txn);
 
         # RT::Transaction->CurrentUserCanSee deals with ensuring we meet
         # the ACLs on CFs, so allow them here

-----------------------------------------------------------------------


More information about the Rt-commit mailing list