[Rt-commit] rt branch, 4.2/charts, updated. rt-4.1.13-164-g005f3a2

[Thomas Sibley]

The branch, 4.2/charts has been updated
       via  005f3a280119b7fe99082fd28fa7d72bea9bad53 (commit)
       via  dd88aead7846fcc5ca9fdd36870117e5ed1d7809 (commit)
      from  e1538530daebfae89bae81234943997c01c9c713 (commit)

Summary of changes:
 TODO.charts             | 32 --------------------------------
 lib/RT/SearchBuilder.pm | 13 +++++++++++++
 2 files changed, 13 insertions(+), 32 deletions(-)
 delete mode 100644 TODO.charts

- Log -----------------------------------------------------------------
commit dd88aead7846fcc5ca9fdd36870117e5ed1d7809
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Jul 3 17:54:25 2013 -0700

    Remove charts TODO file
    
    They'll become feature request tickets.

diff --git a/TODO.charts b/TODO.charts
deleted file mode 100644
index 7741716..0000000
--- a/TODO.charts
+++ /dev/null
@@ -1,32 +0,0 @@
-Example dashboard + saved charts in initialdata for slick demo out of the box
-
-
-== Nice to have ==
-
-it'd be nice if full day and month names worked in 
-"Created.DayOfWeek = 'Thu'" searches.
-
-support more than one calculated function in diagrams,
-at least in bars
-
-support putting grouppings as columns of the table
-support horizontal totals when there are gropings as columns
-
-support links with partial queries in tables, for example
-table:
-
-                          Owner
-    Queue      Status     Nobody [3]
-    General[1] open[2]    10[4]
-
-    [1] - $query AND Queue = 'General'
-    [2] - [1] AND Status = 'open'
-    [3] - $query AND Owner = 'Nobody'
-    [4] - [2] AND [3]
-
-
-On my machine Created-LastUpdated interval is 1 second
-for newely created tickets. It's either bug or just
-operation is long enough to span over two seconds. It
-would be nice to ignore difference up to 3 seconds or
-something like that.

commit 005f3a280119b7fe99082fd28fa7d72bea9bad53
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Jul 3 17:55:09 2013 -0700

    Document NotSetDateToNullFunction

diff --git a/lib/RT/SearchBuilder.pm b/lib/RT/SearchBuilder.pm
index f8b0615..e1993c9 100644
--- a/lib/RT/SearchBuilder.pm
+++ b/lib/RT/SearchBuilder.pm
@@ -908,6 +908,19 @@ sub ColumnMapClassName {
     return $Class;
 }
 
+=head2 NotSetDateToNullFunction
+
+Takes a paramhash with an optional FIELD key whose value is the name of a date
+column.  If no FIELD is provided, a literal C<?> placeholder is used so the
+caller can fill in the field later.
+
+Returns a SQL function which evaluates to C<NULL> if the FIELD is set to the
+Unix epoch; otherwise it evaluates to FIELD.  This is useful because RT
+currently stores unset dates as a Unix epoch timestamp instead of NULL, but
+NULLs are often more desireable.
+
+=cut
+
 sub NotSetDateToNullFunction {
     my $self = shift;
     my %args = ( FIELD => undef, @_ );

-----------------------------------------------------------------------