[Rt-commit] [rtir] 01/02: Order query parameters to avoid perl-5.18's random hash ordering

Kevin Falcone falcone at bestpractical.com
Mon Jul 8 18:40:11 EDT 2013


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 2.9-trunk
in repository rtir.

commit 4e1cc329e0073847cc56d179db574b295e027a08
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Mon Jul 8 16:59:06 2013 -0400

    Order query parameters to avoid perl-5.18's random hash ordering
    
    This steals RT's ee0712a.  Without it, our t/web/walk.t wants to
    run around 4K tests, because it almost never thinks it has visited all
    the URLs.  It also makes for consistent URLs.
---
 html/Callbacks/RTIR/Elements/Tabs/Privileged | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html/Callbacks/RTIR/Elements/Tabs/Privileged b/html/Callbacks/RTIR/Elements/Tabs/Privileged
index 17b5c2e..d48b24a 100644
--- a/html/Callbacks/RTIR/Elements/Tabs/Privileged
+++ b/html/Callbacks/RTIR/Elements/Tabs/Privileged
@@ -50,7 +50,7 @@
 my $query_string = sub {
     my %args = @_;
     my $u    = URI->new();
-    $u->query_form(%args);
+    $u->query_form(map { $_ => $args{$_} } sort keys %args);
     return $u->query || '';
 };
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Rt-commit mailing list