[Rt-commit] [rtir] 05/12: Remove 'New Search' on subsearch pages

Kevin Falcone falcone at bestpractical.com
Fri Jul 12 10:40:03 EDT 2013


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 2.9/edit-search-regressions
in repository rtir.

commit a7f6f10a10db358c12601b414c27d9c221359fcc
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Mon Jul 8 19:00:41 2013 -0400

    Remove 'New Search' on subsearch pages
    
    Places such as the Merge list or Link list or other places where you
    search for a list of Incidents or Reports while performing an action
    have an Edit Search as well as New Search link.  Unfortunately, New
    Search takes you to a blank search without any Queues and doesn't
    provide a way to select Queues (this is because of an explicit choice in
    the PickBasics callbacks).  It's unclear what the behavior should be.
    Should it force you to the 'sane' set of Queues?  If so, that's actually
    a sizable feature to implement, and as this is a new feature in
    2.9-trunk and doesn't currently work, I'm removing it until it can be
    implemented properly.
    
    This caused t/walk-web.t to run less tests (because less tabs) so adjust
    the count there.
---
 html/Callbacks/RTIR/Elements/Tabs/Privileged | 24 ------------------------
 t/walk-web.t                                 |  2 +-
 2 files changed, 1 insertion(+), 25 deletions(-)

diff --git a/html/Callbacks/RTIR/Elements/Tabs/Privileged b/html/Callbacks/RTIR/Elements/Tabs/Privileged
index 47ae46a..957f13c 100644
--- a/html/Callbacks/RTIR/Elements/Tabs/Privileged
+++ b/html/Callbacks/RTIR/Elements/Tabs/Privileged
@@ -298,12 +298,6 @@ if ( $request_path =~ m{^/RTIR/(?:$re_rtir_types/)?(Display|Edit|Update|Forward|
         path => "/RTIR/Link/$direction/Refine.html?". $query_string->( %args ),
     );
     PageMenu()->child(
-        new_search => title => loc('New Search'),
-        path => "/RTIR/Link/$direction/Refine.html?". $query_string->(
-            NewQuery => 1, id => $id, Queue => $queue,
-        ),
-    );
-    PageMenu()->child(
         new => title => loc("New $type"),
         path => !$queue
             ? "/RTIR/Create.html?Child=$id&Queue=Incidents"
@@ -337,12 +331,6 @@ if ( $request_path =~ m{^/RTIR/(?:$re_rtir_types/)?(Display|Edit|Update|Forward|
         path => "/RTIR/Incident/Children/Refine.html?". $query_string->( %args ),
     );
     PageMenu()->child(
-        new_search => title => loc('New Search'),
-        path => "/RTIR/Incident/Children/Refine.html?". $query_string->(
-            NewQuery => 1, id => $id, Queue => $queue,
-        ),
-    );
-    PageMenu()->child(
         new => title => loc("New $type"),
         path => "/RTIR/Create.html?". $query_string->( Incident => $id, Queue => $queue ),
     );
@@ -369,12 +357,6 @@ if ( $request_path =~ m{^/RTIR/(?:$re_rtir_types/)?(Display|Edit|Update|Forward|
         path => "/RTIR/Merge/Refine.html?". $query_string->( %args ),
     );
     PageMenu()->child(
-        new_search => title => loc('New Search'),
-        path => "/RTIR/Merge/Refine.html?". $query_string->(
-            NewQuery => 1, id => $id,
-        ),
-    );
-    PageMenu()->child(
         back => title => loc('Back to ticket #[_1]', $id),
         path => "/RTIR/Display.html?id=$id",
     );
@@ -401,12 +383,6 @@ if ( $request_path =~ m{^/RTIR/(?:$re_rtir_types/)?(Display|Edit|Update|Forward|
         path => "/RTIR/Incident/Reply/Refine.html?". $query_string->( %args ),
     );
     PageMenu()->child(
-        new_search => title => loc('New Search'),
-        path => "/RTIR/Incident/Reply/Refine.html?". $query_string->(
-            NewQuery => 1, id => $id,
-        ),
-    );
-    PageMenu()->child(
         back => title => loc('Back to ticket #[_1]', $id),
         path => "/RTIR/Display.html?id=$id",
     );
diff --git a/t/walk-web.t b/t/walk-web.t
index ee5731f..6d02dc3 100644
--- a/t/walk-web.t
+++ b/t/walk-web.t
@@ -5,7 +5,7 @@ use warnings;
 
 use HTML::TreeBuilder;
 
-use RT::IR::Test tests => 579;
+use RT::IR::Test tests => 528;
 
 RT::Test->started_ok;
 my $m = default_agent();

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Rt-commit mailing list