[Rt-commit] [rtir] 12/12: No longer allow Editing of the Children search

Kevin Falcone falcone at bestpractical.com
Fri Jul 12 10:40:03 EDT 2013


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 2.9/edit-search-regressions
in repository rtir.

commit 9d08fe725561fe083b987b94c27cc5262d85116d
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Thu Jul 11 23:36:47 2013 -0400

    No longer allow Editing of the Children search
    
    Because we use ShowChildren, it's relatively difficult to pass along the
    relevant search parameters like we've been doing for all the other Edit
    Search updates.
    
    Because Children/index.html doesn't pass along updates from Refine.html
    back into the search, I'm not sure how this code was ever supposed to
    update the Query being run by ShowChildren.  Changing this became
    invasive quickly, and this is a new feature since 2.6 so we'll remove it
    rather than introduce even buggier code.
    
    Unlike other lists fixed on this branch, this UI *does* allow filtering
    by status, so while you can't build more complicated filters, you can at
    least do that.
---
 html/Callbacks/RTIR/Elements/Tabs/Privileged |  9 -----
 html/RTIR/Incident/Children/Refine.html      | 60 ----------------------------
 2 files changed, 69 deletions(-)

diff --git a/html/Callbacks/RTIR/Elements/Tabs/Privileged b/html/Callbacks/RTIR/Elements/Tabs/Privileged
index b160eb6..5e97005 100644
--- a/html/Callbacks/RTIR/Elements/Tabs/Privileged
+++ b/html/Callbacks/RTIR/Elements/Tabs/Privileged
@@ -318,20 +318,11 @@ if ( $request_path =~ m{^/RTIR/(?:$re_rtir_types/)?(Display|Edit|Update|Forward|
     my $id = $ticket->id;
 
     my %args = (
-        $search_arguments->(),
         id => $id,
         Queue => $queue,
     );
 
     PageMenu()->child(
-        link => title => loc('Show Results'),
-        path => "/RTIR/Incident/Children/?". $query_string->( %args ),
-    );
-    PageMenu()->child(
-        edit_search => title => loc('Edit Search'),
-        path => "/RTIR/Incident/Children/Refine.html?". $query_string->( %args ),
-    );
-    PageMenu()->child(
         new => title => loc("New $type"),
         path => "/RTIR/Create.html?". $query_string->( Incident => $id, Queue => $queue ),
     );
diff --git a/html/RTIR/Incident/Children/Refine.html b/html/RTIR/Incident/Children/Refine.html
deleted file mode 100644
index 0733a0c..0000000
--- a/html/RTIR/Incident/Children/Refine.html
+++ /dev/null
@@ -1,60 +0,0 @@
-%# BEGIN BPS TAGGED BLOCK {{{
-%#
-%# COPYRIGHT:
-%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
-%#                                          <sales at bestpractical.com>
-%#
-%# (Except where explicitly superseded by other copyright notices)
-%#
-%#
-%# LICENSE:
-%#
-%# This work is made available to you under the terms of Version 2 of
-%# the GNU General Public License. A copy of that license should have
-%# been provided with this software, but in any event can be snarfed
-%# from www.gnu.org.
-%#
-%# This work is distributed in the hope that it will be useful, but
-%# WITHOUT ANY WARRANTY; without even the implied warranty of
-%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-%# General Public License for more details.
-%#
-%# You should have received a copy of the GNU General Public License
-%# along with this program; if not, write to the Free Software
-%# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-%# 02110-1301 or visit their web page on the internet at
-%# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
-%#
-%#
-%# CONTRIBUTION SUBMISSION POLICY:
-%#
-%# (The following paragraph is not intended to limit the rights granted
-%# to you to modify and distribute this software under the terms of
-%# the GNU General Public License and is only of importance to you if
-%# you choose to contribute your changes and enhancements to the
-%# community by submitting them to Best Practical Solutions, LLC.)
-%#
-%# By intentionally submitting any modifications, corrections or
-%# derivatives to this work, or any other work intended for use with
-%# Request Tracker, to Best Practical Solutions, LLC, you confirm that
-%# you are the copyright holder for those contributions and you grant
-%# Best Practical Solutions,  LLC a nonexclusive, worldwide, irrevocable,
-%# royalty-free, perpetual, license to use, copy, create derivative
-%# works based on those contributions, and sublicense and distribute
-%# those contributions and any derivatives thereof.
-%#
-%# END BPS TAGGED BLOCK }}}
-<%INIT>
-return $m->comp(
-    '/RTIR/Search/Elements/RefinePage',
-    %ARGS,
-    ResultPage => 'RTIR/Incident/Children/?'. $m->comp('/Elements/QueryString',
-        id => $ARGS{'id'}, Queue => $ARGS{'Queue'},
-    ),
-    BaseQuery => RT::IR->Query(
-        Queue    => $ARGS{'Queue'},
-        MemberOf => $ARGS{'id'},
-    ),
-);
-</%INIT>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Rt-commit mailing list