[Rt-commit] rt branch, 4.2/clean-up-deps, created. rt-4.1.8-554-g9b277db

[Alex Vandiver]

The branch, 4.2/clean-up-deps has been created
        at  9b277db9ce70731caba3db748bac0420b61e85d9 (commit)

- Log -----------------------------------------------------------------
commit c6659e2f767b23df930d673362ba45d0c1b7ba1c
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Dec 24 13:03:39 2012 -0500

    DBIx::SearchBuilder includes a Class::ReturnValue dep; we don't use it

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index ec91180..b9444bd 100644
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -181,7 +181,6 @@ CGI::Cookie 1.20
 CGI::Emulate::PSGI
 CGI::PSGI 0.12
 Class::Accessor 0.34
-Class::ReturnValue 0.40
 CSS::Squish 0.06
 Date::Extract 0.02
 Date::Manip

commit ec230d16857b20a19369d86b251784bd5b21698e
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Dec 24 13:38:31 2012 -0500

    Remove two deps we do not use directly, but HTML::Mason merely requires

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index b9444bd..3da58d1 100644
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -269,8 +269,6 @@ Text::ParseWords
 $deps{'DEVELOPER'} = [ text_to_hash( << '.') ];
 Email::Abstract
 File::Find
-HTML::Form
-HTML::TokeParser
 Log::Dispatch::Perl
 Mojo::DOM
 Plack::Middleware::Test::StashWarnings 0.06

commit 8fb8589d6668b70f8c15aea28310d6ca816fffa9
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Dec 26 17:10:31 2012 -0500

    Remove the (socket => "inet"), suggestion, based on Sys::Syslog docs
    
    Modern Sys::Syslog stresses that setting setlogsock (which is what
    passing "socket" does) is strongly discouraged -- see the first two of
    the "THE RULES OF SYS::SYSLOG".  The two reports for Solaris and
    UnixWare (tickets #4717 and #5755) were for Sys::Syslog 0.04 or below,
    and should no longer be necessary with 0.16 or above.

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index b98de3b..6b74cb3 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -303,11 +303,9 @@ Set($LogStackTraces, "");
 
 =item C<@LogToSyslogConf>
 
-On Solaris or UnixWare, set to ( socket => 'inet' ).  Options here
-override any other options RT passes to L<Log::Dispatch::Syslog>.
-Other interesting flags include facility and logopt.  (See the
-L<Log::Dispatch::Syslog> documentation for more information.)  (Maybe
-ident too, if you have multiple RT installations.)
+Additional options to pass to L<Log::Dispatch::Syslog>; the most
+interesting flags include C<facility>, C<logopt>, and possibly C<ident>.
+See the L<Log::Dispatch::Syslog> documentation for more information.
 
 =cut
 

commit 9b277db9ce70731caba3db748bac0420b61e85d9
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue May 7 15:29:59 2013 -0400

    Remove the undocumented --download flag
    
    This flag, originally introduced in 42bf603, was meant to download
    "pristine" versions of the modules RT dependended on and import them
    wholesale into a Subversion repository.  This functionality was
    undocumented and unmaintained and more modern ways exist of doing the
    same.

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 3da58d1..b7e2b24 100644
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -74,8 +74,6 @@ GetOptions(
     'with-USERLOGO',
     'with-HTML-DOC',
 
-    'download=s',
-    'repository=s',
     'list-deps',
     'help|h',
 );
@@ -526,47 +524,6 @@ END
     return scalar `$ext 1>&2`;
 }
 
-sub download_mods {
-    my %modules;
-    use CPAN;
-    
-    foreach my $key (keys %deps) {
-        my @deps = (@{$deps{$key}});
-        while (@deps) {
-            my $mod = shift @deps;
-            my $ver = shift @deps;
-            next if ($mod =~ /^(DBD-|Apache-Request)/);
-            $modules{$mod} = $ver;
-        }
-    }
-    my @mods = keys %modules;
-    CPAN::get();
-    my $moddir = $args{'download'};
-    foreach my $mod (@mods) {
-        $CPAN::Config->{'build_dir'} = $moddir;
-        CPAN::get($mod);
-    }
-
-    opendir(DIR, $moddir);
-    while ( my $dir = readdir(DIR)) {
-        print "Dir is $dir\n";
-        next if ( $dir =~ /^\.\.?$/);
-
-        # Skip things we've previously tagged
-        my $out = `svn ls $args{'repository'}/tags/$dir`;
-        next if ($out);
-
-        if ($dir =~ /^(.*)-(.*?)$/) {
-            `svn_load_dirs -no_user_input -t tags/$dir -v $args{'repository'} dists/$1 $moddir/$dir`;
-            `rm -rf $moddir/$dir`;
-
-        }
-
-    }
-    closedir(DIR);
-    exit;
-}
-
 sub check_perl_version {
   section("perl");
   eval {require 5.010_001};

-----------------------------------------------------------------------