[Rt-commit] rt branch, 4.2/deprecate-elements-titlebox, created. rt-4.1.6-286-g64ee2f7

Alex Vandiver alexmv at bestpractical.com
Fri Mar 1 13:47:50 EST 2013


The branch, 4.2/deprecate-elements-titlebox has been created
        at  64ee2f74d8256347ae7fee2b2ad9e6b73896b9cc (commit)

- Log -----------------------------------------------------------------
commit 64ee2f74d8256347ae7fee2b2ad9e6b73896b9cc
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Feb 28 15:44:44 2013 -0500

    Note that /Elements/TitleBox and friends are deprecated
    
    /Widgets/TitleBox has existed since RT 3.6; mark the old
    /Elements/TitleBox as deprecated, and to be removed in 4.4.

diff --git a/lib/RT/StyleGuide.pod b/lib/RT/StyleGuide.pod
index deeb09f..7c6551f 100644
--- a/lib/RT/StyleGuide.pod
+++ b/lib/RT/StyleGuide.pod
@@ -781,9 +781,9 @@ should become           <&|/l, $m->scomp('/Elements/SelectNewTicketQueue')&><inp
 
 
 
-The string      <& /Elements/TitleBoxStart, width=> "40%", titleright => "RT $RT::VERSION for   RT->Config->Get('rtname')", title => 'Login' &>
+The string      <& /Widgets/TitleBoxStart, width=> "40%", titleright => "RT $RT::VERSION for   RT->Config->Get('rtname')", title => 'Login' &>
 
-should become   <& /Elements/TitleBoxStart,
+should become   <& /Widgets/TitleBoxStart,
                         width=> "40%",
                         titleright => loc("RT [_1] for [_2]",$RT::VERSION, RT->Config->Get('rtname')),
                         title => loc('Login'),
diff --git a/share/html/Articles/Article/Elements/ShowSavedSearches b/share/html/Articles/Article/Elements/ShowSavedSearches
index f0128e0..4f08d68 100644
--- a/share/html/Articles/Article/Elements/ShowSavedSearches
+++ b/share/html/Articles/Article/Elements/ShowSavedSearches
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<& /Elements/TitleBoxStart, title => loc('Saved searches') &>
+<& /Widgets/TitleBoxStart, title => loc('Saved searches') &>
 %# Keep track of what our current search ID is.
 <input type="hidden" name="CurrentSearch" value="<% $CurrentSearch ? $CurrentSearch : 'new' %>">
 %# Hide all the save functionality if the user shouldn't see it.
@@ -67,7 +67,7 @@
 <h2><&|/l&>Load a saved search</&></h2>
 <& SelectSavedSearches, Name => 'LoadSavedSearch', Default => $CurrentSearch &>
 <input value="<%loc('Load')%>" name="Load" type="submit">
-<& /Elements/TitleBoxEnd &>
+<& /Widgets/TitleBoxEnd &>
 
 <%INIT>
 unless ($session{'CurrentUser'}->HasRight( Right => 'LoadSavedSearch',
diff --git a/share/html/Articles/Article/Elements/ShowSearchCriteria b/share/html/Articles/Article/Elements/ShowSearchCriteria
index 85b5b51..e5b5958 100644
--- a/share/html/Articles/Article/Elements/ShowSearchCriteria
+++ b/share/html/Articles/Article/Elements/ShowSearchCriteria
@@ -46,9 +46,9 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 % if ($ARGS{'HideOptions'}) {
-<& /Elements/TitleBoxStart, title => loc('Advanced search'), class => "rolled-up", bodyclass => "hidden" &>
+<& /Widgets/TitleBoxStart, title => loc('Advanced search'), class => "rolled-up", bodyclass => "hidden" &>
 % } else {
-<& /Elements/TitleBoxStart, title => loc('Advanced search') &>
+<& /Widgets/TitleBoxStart, title => loc('Advanced search') &>
 % }
 <table>
 <tr>
@@ -142,7 +142,7 @@
 </tr>
 </table>
 <& /Elements/Submit, Label => loc('Search') &>
-<&/Elements/TitleBoxEnd&>
+<& /Widgets/TitleBoxEnd &>
 <%init>
 my @Classes =
  ( ref $ARGS{'Class'} eq 'ARRAY' )
diff --git a/share/html/Articles/Article/Search.html b/share/html/Articles/Article/Search.html
index bcf21f5..fd8e78f 100644
--- a/share/html/Articles/Article/Search.html
+++ b/share/html/Articles/Article/Search.html
@@ -62,11 +62,11 @@
 </td>
 <td valign="top" width="50%">
 <form action="Search.html" method="get">
-<& /Elements/TitleBoxStart, title => loc('Saved searches') &>
+<& /Widgets/TitleBoxStart, title => loc('Saved searches') &>
 <&|/l&>Load saved search:</&><br />
 <& Elements/SelectSavedSearches, Name => 'LoadSavedSearch', Default => $CurrentSearch &>
 <input value="<%loc('Load')%>" name="Load" type="submit" />
-<& /Elements/TitleBoxEnd &>
+<& /Widgets/TitleBoxEnd &>
 </form>
 </td>
 </tr>
diff --git a/share/html/Articles/Elements/CreateArticle b/share/html/Articles/Elements/CreateArticle
index fd9a546..f1e045f 100644
--- a/share/html/Articles/Elements/CreateArticle
+++ b/share/html/Articles/Elements/CreateArticle
@@ -45,13 +45,13 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<& /Elements/TitleBoxStart, title => loc('Create an article') &>
+<& /Widgets/TitleBoxStart, title => loc('Create an article') &>
 <ul>
 % while (my $Class = $Classes->Next) {
 <li><a href="Article/Edit.html?Class=<%$Class->Id%>"><%$Class->Name%></a></li> 
 % } 
 </ul>
-<& /Elements/TitleBoxEnd &>
+<& /Widgets/TitleBoxEnd &>
 <%init>
 my $Classes = RT::Classes->new($session{'CurrentUser'});
 $Classes->LimitToEnabled;
diff --git a/share/html/Articles/Elements/NewestArticles b/share/html/Articles/Elements/NewestArticles
index a379063..ab0041f 100644
--- a/share/html/Articles/Elements/NewestArticles
+++ b/share/html/Articles/Elements/NewestArticles
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<& /Elements/TitleBoxStart, title => loc("[_1] newest articles", $rows), bodyclass=> '' &>
+<& /Widgets/TitleBoxStart, title => loc("[_1] newest articles", $rows), bodyclass=> '' &>
 <table border="0" cellspacing="0" cellpadding="1" width="100%">
 <tr>
 <th align="right"><&|/l&>#</&></th>
@@ -67,7 +67,7 @@
 </tr>
 % }
 </table>
-<& /Elements/TitleBoxEnd &>
+<& /Widgets/TitleBoxEnd &>
 <%INIT>
 my $rows = 10;
 my $i;
diff --git a/share/html/Articles/Elements/QuickSearch b/share/html/Articles/Elements/QuickSearch
index f531f67..d005734 100644
--- a/share/html/Articles/Elements/QuickSearch
+++ b/share/html/Articles/Elements/QuickSearch
@@ -45,13 +45,13 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<& /Elements/TitleBoxStart, title => loc('Quick search') &>
+<& /Widgets/TitleBoxStart, title => loc('Quick search') &>
 <ul>
 % while (my $class = $classes->Next) {
 <li><a href="<%RT->Config->Get('WebPath')%>/Articles/Article/Search.html?Class=<%$class->Name%>&Parent=0&HideOptions=1"><%$class->Name%></a></li>
 % }
 </ul>
-<& /Elements/TitleBoxEnd &>
+<& /Widgets/TitleBoxEnd &>
 <%init>
 my $classes = RT::Classes->new($session{'CurrentUser'});
 $classes->LimitToEnabled;
diff --git a/share/html/Articles/Elements/UpdatedArticles b/share/html/Articles/Elements/UpdatedArticles
index 777bc48..e081fcb 100644
--- a/share/html/Articles/Elements/UpdatedArticles
+++ b/share/html/Articles/Elements/UpdatedArticles
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<& /Elements/TitleBoxStart, title => loc("[_1] most recently updated articles", $rows), bodyclass=> '' &>
+<& /Widgets/TitleBoxStart, title => loc("[_1] most recently updated articles", $rows), bodyclass=> '' &>
 <table border="0" cellspacing="0" cellpadding="1" width="100%">
 <tr>
 <th align="right"><&|/l&>#</&></th>
@@ -68,7 +68,7 @@
 </tr>
 % }
 </table>
-<& /Elements/TitleBoxEnd &>
+<& /Widgets/TitleBoxEnd &>
 <%INIT>
 my $rows = 10;
 my $i;
diff --git a/share/html/Elements/TitleBox b/share/html/Elements/TitleBox
index bed4003..2aadeb2 100644
--- a/share/html/Elements/TitleBox
+++ b/share/html/Elements/TitleBox
@@ -47,5 +47,6 @@
 %# END BPS TAGGED BLOCK }}}
 <%init>
 # For compatibility with 3.4
+RT->Deprecated( Remove => 4.4, Instead => "/Widgets/TitleBox" );
 $m->comp('/Widgets/TitleBox', %ARGS );
 </%init>
diff --git a/share/html/Elements/TitleBoxEnd b/share/html/Elements/TitleBoxEnd
index f1ac682..b8f215b 100644
--- a/share/html/Elements/TitleBoxEnd
+++ b/share/html/Elements/TitleBoxEnd
@@ -47,5 +47,6 @@
 %# END BPS TAGGED BLOCK }}}
 <%init>
 # For compatibility with 3.4
+RT->Deprecated( Remove => 4.4, Instead => "/Widgets/TitleBoxEnd" );
 $m->comp('/Widgets/TitleBoxEnd', %ARGS );
 </%init>
diff --git a/share/html/Elements/TitleBoxStart b/share/html/Elements/TitleBoxStart
index cb746c4..120022c 100644
--- a/share/html/Elements/TitleBoxStart
+++ b/share/html/Elements/TitleBoxStart
@@ -47,5 +47,6 @@
 %# END BPS TAGGED BLOCK }}}
 <%init>
 # For compatibility with 3.4
+RT->Deprecated( Remove => 4.4, Instead => "/Widgets/TitleBoxStart" );
 $m->comp('/Widgets/TitleBoxStart', %ARGS );
 </%init>

-----------------------------------------------------------------------


More information about the Rt-commit mailing list