[Rt-commit] rt branch, 4.0/fix-uninitialized-warning-in-show-user-verbose, created. rt-4.0.10-108-g518d789

? sunnavy sunnavy at bestpractical.com
Mon Mar 18 11:50:44 EDT 2013


The branch, 4.0/fix-uninitialized-warning-in-show-user-verbose has been created
        at  518d7891b9dda243dcc7ea6a36b915c290bf5fd5 (commit)

- Log -----------------------------------------------------------------
commit 518d7891b9dda243dcc7ea6a36b915c290bf5fd5
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Mar 18 23:40:24 2013 +0800

    fix uninitialized warnings in ShowUserVerbose

diff --git a/share/html/Elements/ShowUserVerbose b/share/html/Elements/ShowUserVerbose
index 72b89fc..f805b57 100644
--- a/share/html/Elements/ShowUserVerbose
+++ b/share/html/Elements/ShowUserVerbose
@@ -54,8 +54,9 @@ my $comment = '';
 
 if ($User) {
     $address = $User->EmailAddress;
-    $phrase  = $User->RealName if $User->RealName && lc $User->RealName ne lc $address;
-    $comment = $User->Name if lc $User->Name ne lc $address;
+    $phrase = $User->RealName
+      if $User->RealName && ( !$address || lc $User->RealName ne lc $address );
+    $comment = $User->Name if !$address || lc $User->Name ne lc $address;
 } else {
     $address = $Address;
 }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list