[Rt-commit] rt branch, 4.2/clean-up-deps, created. rt-4.1.8-267-gc930bc7

Alex Vandiver alexmv at bestpractical.com
Tue May 7 15:37:57 EDT 2013


The branch, 4.2/clean-up-deps has been created
        at  c930bc7cb2c83b4b3718ef5e91fde0a03a59cc6c (commit)

- Log -----------------------------------------------------------------
commit 73fbbeed70c3876117f708272b98e0ffe8d3b4af
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Dec 24 13:03:06 2012 -0500

    These deps are included in perl 5.8.3

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index bbcd02c..8abda55 100644
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -177,7 +177,6 @@ sub text_to_hash {
 $deps{'CORE'} = [ text_to_hash( << '.') ];
 Apache::Session 1.53
 CGI 3.38
-CGI::Cookie 1.20
 CGI::Emulate::PSGI
 CGI::PSGI 0.12
 Class::Accessor 0.34
@@ -189,15 +188,10 @@ DBI 1.37
 DBIx::SearchBuilder 1.63
 Devel::GlobalDestruction
 Devel::StackTrace 1.19
-Digest::base
-Digest::MD5 2.27
 Digest::SHA
 Email::Address
 Encode 2.39
-Errno
-File::Glob
 File::ShareDir
-File::Spec 0.8
 File::Temp 0.19
 HTML::Entities
 HTML::FormatText
@@ -227,8 +221,6 @@ Regexp::Common
 Regexp::Common::net::CIDR
 Regexp::IPv6
 Role::Basic 0.12
-Scalar::Util
-Storable 2.08
 Symbol::Global::Name 0.02
 Sys::Syslog 0.16
 Text::Password::Pronounceable
@@ -236,7 +228,6 @@ Text::Quoted 2.02
 Text::Template 1.44
 Text::WikiFormat 0.76
 Text::Wrapper
-Time::HiRes
 Time::ParseDate
 Tree::Simple 1.04
 UNIVERSAL::require
@@ -245,26 +236,20 @@ XML::RSS 1.05
 
 $deps{'MAILGATE'} = [ text_to_hash( << '.') ];
 Crypt::SSLeay
-Getopt::Long
 LWP::Protocol::https
 LWP::UserAgent 6.0
 Mozilla::CA
 Net::SSL
-Pod::Usage
 .
 
 $deps{'CLI'} = [ text_to_hash( << '.') ];
-Getopt::Long 2.24
 HTTP::Request::Common
 LWP
 Term::ReadKey
-Term::ReadLine
-Text::ParseWords
 .
 
 $deps{'DEVELOPER'} = [ text_to_hash( << '.') ];
 Email::Abstract
-File::Find
 HTML::Form
 HTML::TokeParser
 Log::Dispatch::Perl

commit 8c78e3e1057e235f8b9231b23b975a309ae221b6
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Dec 24 13:03:39 2012 -0500

    DBIx::SearchBuilder includes a Class::ReturnValue dep; we don't use it

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 8abda55..a131407 100644
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -180,7 +180,6 @@ CGI 3.38
 CGI::Emulate::PSGI
 CGI::PSGI 0.12
 Class::Accessor 0.34
-Class::ReturnValue 0.40
 CSS::Squish 0.06
 DateTime 0.44
 DateTime::Locale 0.40

commit 167ebaeb3fd99bc72fe8a51bd50e70ab2f1608d2
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Dec 24 13:22:46 2012 -0500

    Comment deps which can be removed if minimum perl verion increases

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index a131407..d68a20f 100644
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -176,10 +176,10 @@ sub text_to_hash {
 
 $deps{'CORE'} = [ text_to_hash( << '.') ];
 Apache::Session 1.53
-CGI 3.38
+CGI 3.38                           # 5.10.1 and above
 CGI::Emulate::PSGI
 CGI::PSGI 0.12
-Class::Accessor 0.34
+Class::Accessor 0.34               # For Class::Accessor::Fast
 CSS::Squish 0.06
 DateTime 0.44
 DateTime::Locale 0.40
@@ -187,11 +187,11 @@ DBI 1.37
 DBIx::SearchBuilder 1.63
 Devel::GlobalDestruction
 Devel::StackTrace 1.19
-Digest::SHA
+Digest::SHA                        # 5.10.0 and above
 Email::Address
 Encode 2.39
 File::ShareDir
-File::Temp 0.19
+File::Temp 0.19                    # 5.10.1 and above
 HTML::Entities
 HTML::FormatText
 HTML::Mason 1.43
@@ -205,7 +205,7 @@ IPC::Run3
 JSON
 LWP::Simple
 List::MoreUtils
-Locale::Maketext 1.06
+Locale::Maketext 1.06              # 5.10.0 and above
 Locale::Maketext::Fuzzy 0.11
 Locale::Maketext::Lexicon 0.32
 Log::Dispatch 2.30
@@ -221,7 +221,7 @@ Regexp::Common::net::CIDR
 Regexp::IPv6
 Role::Basic 0.12
 Symbol::Global::Name 0.02
-Sys::Syslog 0.16
+Sys::Syslog 0.16                   # 5.10.0 and above
 Text::Password::Pronounceable
 Text::Quoted 2.02
 Text::Template 1.44

commit 2a42301d3fc7330846522e10bf764602d3c2d9e1
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Dec 24 13:38:31 2012 -0500

    Remove two deps we do not use directly, but HTML::Mason merely requires

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index d68a20f..cb9aa0c 100644
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -249,8 +249,6 @@ Term::ReadKey
 
 $deps{'DEVELOPER'} = [ text_to_hash( << '.') ];
 Email::Abstract
-HTML::Form
-HTML::TokeParser
 Log::Dispatch::Perl
 Mojo::DOM
 Plack::Middleware::Test::StashWarnings 0.06

commit 0fa80c5f935695992f38d73320f0e86cbff8826f
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Dec 26 17:10:31 2012 -0500

    Remove the (socket => "inet"), suggestion, based on Sys::Syslog docs
    
    Modern Sys::Syslog stresses that setting setlogsock (which is what
    passing "socket" does) is strongly discouraged -- see the first two of
    the "THE RULES OF SYS::SYSLOG".  The two reports for Solaris and
    UnixWare (tickets #4717 and #5755) were for Sys::Syslog 0.04 or below,
    and should no longer be necessary with 0.16 or above.

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index a56891f..e93842b 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -303,11 +303,9 @@ Set($LogStackTraces, "");
 
 =item C<@LogToSyslogConf>
 
-On Solaris or UnixWare, set to ( socket => 'inet' ).  Options here
-override any other options RT passes to L<Log::Dispatch::Syslog>.
-Other interesting flags include facility and logopt.  (See the
-L<Log::Dispatch::Syslog> documentation for more information.)  (Maybe
-ident too, if you have multiple RT installations.)
+Additional options to pass to L<Log::Dispatch::Syslog>; the most
+interesting flags include C<facility>, C<logopt>, and possibly C<ident>.
+See the L<Log::Dispatch::Syslog> documentation for more information.
 
 =cut
 

commit c930bc7cb2c83b4b3718ef5e91fde0a03a59cc6c
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue May 7 15:29:59 2013 -0400

    Remove the undocumented --download flag
    
    This flag, originally introduced in 42bf603, was meant to download
    "pristine" versions of the modules RT dependended on and import them
    wholesale into a Subversion repository.  This functionality was
    undocumented and unmaintained and more modern ways exist of doing the
    same.

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index cb9aa0c..a6251a7 100644
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -74,8 +74,6 @@ GetOptions(
     'with-USERLOGO',
     'with-HTML-DOC',
 
-    'download=s',
-    'repository=s',
     'list-deps',
     'help|h',
 );
@@ -507,47 +505,6 @@ END
     return scalar `$ext 1>&2`;
 }
 
-sub download_mods {
-    my %modules;
-    use CPAN;
-    
-    foreach my $key (keys %deps) {
-        my @deps = (@{$deps{$key}});
-        while (@deps) {
-            my $mod = shift @deps;
-            my $ver = shift @deps;
-            next if ($mod =~ /^(DBD-|Apache-Request)/);
-            $modules{$mod} = $ver;
-        }
-    }
-    my @mods = keys %modules;
-    CPAN::get();
-    my $moddir = $args{'download'};
-    foreach my $mod (@mods) {
-        $CPAN::Config->{'build_dir'} = $moddir;
-        CPAN::get($mod);
-    }
-
-    opendir(DIR, $moddir);
-    while ( my $dir = readdir(DIR)) {
-        print "Dir is $dir\n";
-        next if ( $dir =~ /^\.\.?$/);
-
-        # Skip things we've previously tagged
-        my $out = `svn ls $args{'repository'}/tags/$dir`;
-        next if ($out);
-
-        if ($dir =~ /^(.*)-(.*?)$/) {
-            `svn_load_dirs -no_user_input -t tags/$dir -v $args{'repository'} dists/$1 $moddir/$dir`;
-            `rm -rf $moddir/$dir`;
-
-        }
-
-    }
-    closedir(DIR);
-    exit;
-}
-
 sub check_perl_version {
   section("perl");
   eval {require 5.008003};

-----------------------------------------------------------------------


More information about the Rt-commit mailing list