[Rt-commit] rt branch, 4.0/session-store-failure, created. rt-4.0.12-12-g53fbab0

[Thomas Sibley]

The branch, 4.0/session-store-failure has been created
        at  53fbab0f164591c564d3e786386b705443233c19 (commit)

- Log -----------------------------------------------------------------
commit 53fbab0f164591c564d3e786386b705443233c19
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue May 14 15:37:13 2013 -0700

    Correct a runtime error in our tied session error handler
    
    loc() isn't a function available from within the internals of the
    Session class, and especially not when we failed to store the current
    user's session.  Localization of this error doesn't make sense anyway
    since it now goes to the logs and not the end user.

diff --git a/lib/RT/Interface/Web/Session.pm b/lib/RT/Interface/Web/Session.pm
index 4edd9bd..7910d41 100644
--- a/lib/RT/Interface/Web/Session.pm
+++ b/lib/RT/Interface/Web/Session.pm
@@ -276,10 +276,8 @@ sub TIEHASH {
     eval { tie %session, $class, $id, $attrs };
     eval { tie %session, $class, undef, $attrs } if $@;
     if ( $@ ) {
-        die loc("RT couldn't store your session.") . "\n"
-          . loc("This may mean that that the directory '[_1]' isn't writable or a database table is missing or corrupt.",
-            $RT::MasonSessionDir)
-          . "\n\n"
+        die "RT couldn't store your session.  "
+          . "This may mean that that the directory '$RT::MasonSessionDir' isn't writable or a database table is missing or corrupt.\n\n"
           . $@;
     }
 

-----------------------------------------------------------------------