[Rt-commit] rt branch, 4.0/do-not-load-object-of-value-zero, created. rt-4.0.12-17-ge25b715

[? sunnavy]

The branch, 4.0/do-not-load-object-of-value-zero has been created
        at  e25b715912487293dd2dbf45abf2b712ef182db9 (commit)

- Log -----------------------------------------------------------------
commit e25b715912487293dd2dbf45abf2b712ef182db9
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed May 15 23:52:42 2013 +0800

    no need to load object with id of value 0
    
    so we won't get warnings of "Couldn't load object RT::Transaction #0" when
    updating tickets with txn cfs

diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
index ba7b56d..e4545fb 100644
--- a/lib/RT/Interface/Web.pm
+++ b/lib/RT/Interface/Web.pm
@@ -2666,10 +2666,10 @@ sub ProcessObjectCustomFieldUpdates {
     foreach my $arg ( keys %$ARGSRef ) {
 
         # format: Object-<object class>-<object id>-CustomField-<CF id>-<commands>
-        next unless $arg =~ /^Object-([\w:]+)-(\d*)-CustomField-(\d+)-(.*)$/;
+        next unless $arg =~ /^Object-([\w:]+)-(\d+)-CustomField-(\d+)-(.*)$/;
 
         # For each of those objects, find out what custom fields we want to work with.
-        $custom_fields_to_mod{$1}{ $2 || 0 }{$3}{$4} = $ARGSRef->{$arg};
+        $custom_fields_to_mod{$1}{$2}{$3}{$4} = $ARGSRef->{$arg};
     }
 
     # For each of those objects

-----------------------------------------------------------------------