[Rt-commit] rt branch, 4.2/unintentionally-multipart-rest, created. rt-4.2.0-42-g925f49a

Kevin Falcone falcone at bestpractical.com
Fri Nov 8 14:18:46 EST 2013


The branch, 4.2/unintentionally-multipart-rest has been created
        at  925f49ac4e3d49804f42f86eae409fac929367eb (commit)

- Log -----------------------------------------------------------------
commit 925f49ac4e3d49804f42f86eae409fac929367eb
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Nov 8 14:05:26 2013 -0500

    Don't create an empty part on text/plain ticket creations.
    
    We tell ->build the Type of "multipart/mixed" but passing in Content-
    Type means that MIME::Entity will make us an empty part of Content-Type:
    text/plain. We then attach the *real* text/plain part and then when we
    call make_singlepart it returns "can't do that, more than 1 part" and
    leaves us with a horrible message.
    
    When this commit was backported in af919efbe it correctly didn't set
    Content-Type.
    
    Sample of MIME generated available in issues #27229.

diff --git a/share/html/REST/1.0/Forms/ticket/default b/share/html/REST/1.0/Forms/ticket/default
index 2abf8e8..c8f3bbd 100644
--- a/share/html/REST/1.0/Forms/ticket/default
+++ b/share/html/REST/1.0/Forms/ticket/default
@@ -194,7 +194,6 @@ else {
                     From => $session{CurrentUser}->EmailAddress,
                     Subject => $v{Subject},
                     'X-RT-Interface' => 'REST',
-                    'Content-Type' => $v{'Content-Type'} || 'text/plain',
                 );
             $v{MIMEObj}->attach(
                 Data => $text,

-----------------------------------------------------------------------


More information about the Rt-commit mailing list