[Rt-commit] rt branch, 4.0/autocomplete-cf-in-search-builder, repushed

? sunnavy sunnavy at bestpractical.com
Fri Oct 4 22:01:15 EDT 2013


The branch 4.0/autocomplete-cf-in-search-builder was deleted and repushed:
       was 8977d64470fae3e9f914372fc789814a8812953a
       now 4ef418698d79bdbd2e0580c5b1dabfd27ac6003e

1:  8977d64 ! 1:  4ef4186 autocomplete "Autocomplete cf" in search builder
    @@ -1,6 +1,16 @@
     Author: sunnavy <sunnavy at bestpractical.com>
     
    -    autocomplete "Aotocomplete cf" in search builder
    +    autocomplete "Autocomplete cf" in search builder
    +    
    +    though we already have Elements/EditCustomFieldAutocomplete, it requires a few
    +    code changes to make it work here, 2 main things:
    +    
    +    * current ajax custom field values helper requires context object, which we
    +      don't have one in search builder
    +    * EditCustomFieldAutocomplete is mainly used in objects' edit pages, the input name
    +      isn't compatible here.
    +    
    +    making another simpler version(<10 lines) seems more right here.
     
     diff --git a/share/html/Elements/SelectCustomFieldValue b/share/html/Elements/SelectCustomFieldValue
     --- a/share/html/Elements/SelectCustomFieldValue



More information about the Rt-commit mailing list