[Rt-commit] [rtir] 07/08: Remove a double-call ported from 3.0

Kevin Falcone falcone at bestpractical.com
Fri Apr 18 21:20:54 EDT 2014


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 3.2/test-fixes
in repository rtir.

commit 04efb5490951cb6629d999d8bd7feb6bb54d0e45
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Apr 18 21:17:02 2014 -0400

    Remove a double-call ported from 3.0
    
    The old code would call out and hit the wrap again and then shortcut
    back to the orig_Create.  When that was ported, I didn't notice that it
    was calling back on itself, but it showed up in stacktraces while
    debugging t/gnupg/*.t and was removed.
---
 lib/RT/IR.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/RT/IR.pm b/lib/RT/IR.pm
index 37bc74d..3db2a80 100644
--- a/lib/RT/IR.pm
+++ b/lib/RT/IR.pm
@@ -903,7 +903,8 @@ if ( RT::IR->HasConstituency ) {
             return $orig_Create->($self,%args);
         }
 
-        my @res = $self->Create(
+        my @res = $orig_Create->(
+            $self,
             %args,
             'CustomField-'. $cf->id => $value,
         );

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list