[Rt-commit] rt branch, 4.4/login-password-auto-complete, created. rt-4.2.3-200-g0ded761

[Alex Vandiver]

The branch, 4.4/login-password-auto-complete has been created
        at  0ded7617e71500a5e12e3db6cee7fcc3833ea08b (commit)

- Log -----------------------------------------------------------------
commit 0ded7617e71500a5e12e3db6cee7fcc3833ea08b
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Wed Apr 9 00:07:17 2014 -0300

    I#29071: Allow auto-completion of passwords
    
    ...as default for all logins (in case browser can do that and has the
    appropriate setting enabled). This remove the optional feature on 4.2
    introduced in 281f39c2e.

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index 14153c9..2876d90 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -1845,16 +1845,6 @@ It defaults to on.  Set this to 0 to disable it.
 
 Set($QuoteFolding, 1);
 
-=item C<$AllowLoginPasswordAutoComplete>
-
-Allow browsers to remember the user's password on login (in case the
-browser can do so, and has the appropriate setting enabled). Defaults
-to false.
-
-=cut
-
-Set($AllowLoginPasswordAutoComplete, 0);
-
 =back
 
 
diff --git a/share/html/Elements/Login b/share/html/Elements/Login
index b3d900c..44596bf 100644
--- a/share/html/Elements/Login
+++ b/share/html/Elements/Login
@@ -73,7 +73,7 @@
 
 <div class="input-row">
     <span class="label"><&|/l&>Password</&>:</span>
-    <span class="input"><input type="password" name="pass" <% RT->Config->Get('AllowLoginPasswordAutoComplete') ? '' : 'autocomplete="off"' | n %> /></span>
+    <span class="input"><input type="password" name="pass" %> /></span>
 </div>
 
 <input type="hidden" name="next" value="<% $next %>" />
diff --git a/t/web/login.t b/t/web/login.t
index 4b3620d..862782a 100644
--- a/t/web/login.t
+++ b/t/web/login.t
@@ -3,8 +3,6 @@ use warnings;
 
 use RT::Test;
 
-RT::Config->Set(AllowLoginPasswordAutoComplete => 1);
-
 my ( $baseurl, $m ) = RT::Test->started_ok;
 
 my $ticket = RT::Test->create_ticket(

-----------------------------------------------------------------------