[Rt-commit] rt branch, 4.2/customfieldgrouping-extensibility, repushed

Kevin Falcone falcone at bestpractical.com
Wed Aug 6 13:47:39 EDT 2014


The branch 4.2/customfieldgrouping-extensibility was deleted and repushed:
       was f85567a43d1f7c5242089155aa161f52b746f94c
       now b1ba2c3d6ae2b4fa36226e65518ffaee89f62442

1:  4937273 ! 1:  4abd0fa RT::CustomField provides a wrapper to get the 'type', use it
    @@ -2,11 +2,15 @@
     
         RT::CustomField provides a wrapper to get the 'type', use it
         
    -    Hardcoding ref here means that if anything extends
    +    Hardcoding ref here meant that if anything extends
         RT::CustomField->_GroupingClass, it'll fail to find the groupings and
         dump all your CFs into the Custom Fields group.  By calling back in to
         GroupingClass, you get the 'magic' type and can look it up in the
         groupings.
    +    
    +    NewItem provides an empty CustomField with ContextObject set which
    +    overriders of _GroupingClass can use for more context when
    +    LimitoToGrouping is called on an empty object (during object creation)
         
         RTIR uses this to provide an RTIR::Ticket grouping type so you can
         separate CF groupings on RTIR tickets from those on core tickets.
    @@ -23,7 +27,7 @@
          my $obj = shift;
          my $grouping = shift;
      
    -+    my $grouping_class = RT::CustomField->_GroupingClass($obj);
    ++    my $grouping_class = $self->NewItem->_GroupingClass($obj);
     +
          my $config = RT->Config->Get('CustomFieldGroupings');
             $config = {} unless ref($config) eq 'HASH';
2:  fa25f47 < -:  ------- Pass extra context to _GroupingClass
3:  f85567a = 2:  b1ba2c3 Allow @Groupings to be passed in



More information about the rt-commit mailing list