[Rt-commit] [rtir] 01/01: Set an increased MaxInlineBody, not an unlimited one

Alex Vandiver alexmv at bestpractical.com
Thu Dec 4 15:50:27 EST 2014

This is an automated email from the git hooks/post-receive script.

alexmv pushed a commit to branch 3.2/provide-maxinlinebody
in repository rtir.

commit ef5bcce06da0660f280bb3e8e7624fdd6b9ad328
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Dec 4 14:58:20 2014 -0500

    Set an increased MaxInlineBody, not an unlimited one
    Inlining all textual content, with no upper limit, can cause performance
    problems -- particularly if a large number of MakeClicky targets exist
    therein.  Since RTIR enables a number of more complex MakeClicky
    extensions, this is higher risk for RTIR than plain RT installs.
    Provide a mamimum (25k) which is larger than the RT default (12k), but
    small enough to catch bodies which might cause performance problems.
 docs/UPGRADING-3.2 | 9 +++++++++
 etc/RTIR_Config.pm | 5 ++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/docs/UPGRADING-3.2 b/docs/UPGRADING-3.2
index 1b70753..58a3c19 100644
--- a/docs/UPGRADING-3.2
+++ b/docs/UPGRADING-3.2
@@ -37,3 +37,12 @@ copy the IP for you, but didn't do so if you later added another IR to
 an existing Incident.  If you do no want this behavior, it is controlled
 by the "On Linking To Incident Copy IPs" scrip in the Incident Report
+RTIR 3.2.0 and earlier set an unlimited value for the core setting
+C<MaxInlineBody>, overriding the default of 12k.  This could cause
+performance problems on large emails with large numbers of IP addresses,
+URLs, or other MakeClicky targets.  RTIR now sets a C<MaxInlineBody> of
diff --git a/etc/RTIR_Config.pm b/etc/RTIR_Config.pm
index d5bf761..65f1b15 100644
--- a/etc/RTIR_Config.pm
+++ b/etc/RTIR_Config.pm
@@ -314,12 +314,11 @@ unless (defined $default_queue) {
 =item C<$MaxInlineBody>
 By default, RT only displays text attachments inline up to
-the first 16k. RTIR will display them no matter how long
-they are.
+the first 12k; RTIR increases this to 25k.
-Set($MaxInlineBody, 0);
+Set($MaxInlineBody, 25 * 1024);
 =item C<$OverdueAfter>

To stop receiving notification emails like this one, please contact
the administrator of this repository.

More information about the rt-commit mailing list