[Rt-commit] rt branch, 4.4/ajax-preview-scrips, updated. rt-4.2.3-206-gcb750e1

? sunnavy sunnavy at bestpractical.com
Sat Jul 12 05:31:36 EDT 2014


The branch, 4.4/ajax-preview-scrips has been updated
       via  cb750e1f93a6ed15d7880057565d0890e8349e32 (commit)
      from  e79c9a623320ffb89fe8ba0204c6e95178febf86 (commit)

Summary of changes:
 share/html/Helpers/PreviewScrips            | 10 +++++-----
 share/html/Helpers/ShowSimplifiedRecipients | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

- Log -----------------------------------------------------------------
commit cb750e1f93a6ed15d7880057565d0890e8349e32
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Jul 12 17:30:26 2014 +0800

    "return" still emits the footer, incorrectly. thanks to chmrr++

diff --git a/share/html/Helpers/PreviewScrips b/share/html/Helpers/PreviewScrips
index 3ef3fce..8cceb89 100644
--- a/share/html/Helpers/PreviewScrips
+++ b/share/html/Helpers/PreviewScrips
@@ -48,21 +48,21 @@
 <%init>
 my $TicketObj = RT::Ticket->new($session{CurrentUser});
 $TicketObj->Load($ARGS{id});
-return unless $TicketObj->id && $ARGS{UpdateType};
+$m->abort unless $TicketObj->id && $ARGS{UpdateType};
 
-return unless $TicketObj->CurrentUserHasRight('ShowOutgoingEmail');
+$m->abort unless $TicketObj->CurrentUserHasRight('ShowOutgoingEmail');
 if ( $ARGS{UpdateType} eq 'private' ) {
-    return
+    $m->abort
       unless $TicketObj->CurrentUserHasRight( 'CommentOnTicket' ) || $TicketObj->CurrentUserHasRight( 'ModifyTicket' );
 }
 else {
-    return
+    $m->abort
       unless $TicketObj->CurrentUserHasRight( 'ReplyToTicket' ) || $TicketObj->CurrentUserHasRight( 'ModifyTicket' );
 }
 
 my $Object = $TicketObj->DryRun(%ARGS);
 my %recips;
-return unless $Object;
+$m->abort unless $Object;
 
 my %squelched = ProcessTransactionSquelching( \%ARGS );
 </%init>
diff --git a/share/html/Helpers/ShowSimplifiedRecipients b/share/html/Helpers/ShowSimplifiedRecipients
index d336754..ab45134 100644
--- a/share/html/Helpers/ShowSimplifiedRecipients
+++ b/share/html/Helpers/ShowSimplifiedRecipients
@@ -46,23 +46,23 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <%init>
-return unless RT->Config->Get('SimplifiedRecipients', $session{'CurrentUser'});
+$m->abort unless RT->Config->Get('SimplifiedRecipients', $session{'CurrentUser'});
 
 my $TicketObj = RT::Ticket->new($session{CurrentUser});
 $TicketObj->Load($ARGS{id});
-return unless $TicketObj->id && $ARGS{UpdateType};
+$m->abort unless $TicketObj->id && $ARGS{UpdateType};
 
 if ( $ARGS{UpdateType} eq 'private' ) {
-    return
+    $m->abort
       unless $TicketObj->CurrentUserHasRight( 'CommentOnTicket' ) || $TicketObj->CurrentUserHasRight( 'ModifyTicket' );
 }
 else {
-    return
+    $m->abort
       unless $TicketObj->CurrentUserHasRight( 'ReplyToTicket' ) || $TicketObj->CurrentUserHasRight( 'ModifyTicket' );
 }
 
 my $Object = $TicketObj->DryRun(%ARGS);
-return unless $Object;
+$m->abort unless $Object;
 
 my %headers = (To => {}, Cc => {}, Bcc => {});
 my %no_squelch;

-----------------------------------------------------------------------


More information about the rt-commit mailing list