[Rt-commit] [rtir] 01/01: Stop providing a custom EditDates

Kevin Falcone falcone at bestpractical.com
Mon Jul 21 17:14:37 EDT 2014


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 3.2/remove-copied-editdates
in repository rtir.

commit 7f0089f763505fcfb6d97775237b1afc9c35a05f
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Mon Jul 21 16:55:15 2014 -0400

    Stop providing a custom EditDates
    
    The only reason (despite lots of commits) for this to exist was to stop
    the editing of Due and Started on Incidents.  This policy seems to date
    from when RTIR provided built-in SLA scrips rather than advocating
    RT-Extension-SLA.
    
    Additionally, if you pass in a default, it'll populate the box, which is
    nice, but I can't find parts of the UI which link to that.  If that
    turns out to be important, it seems like a useful core feature, rather
    than existing in a copy of core.
    
    Closes issues 29958
---
 MANIFEST                     |   1 -
 html/RTIR/Edit.html          |   2 +-
 html/RTIR/Elements/EditDates | 103 -------------------------------------------
 3 files changed, 1 insertion(+), 105 deletions(-)

diff --git a/MANIFEST b/MANIFEST
index 159acd7..68f0ab1 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -73,7 +73,6 @@ html/RTIR/Elements/AttachReports
 html/RTIR/Elements/DueIncidents
 html/RTIR/Elements/EditConstituency
 html/RTIR/Elements/EditCustomFields
-html/RTIR/Elements/EditDates
 html/RTIR/Elements/EditPeople
 html/RTIR/Elements/EditRTIRField
 html/RTIR/Elements/Header
diff --git a/html/RTIR/Edit.html b/html/RTIR/Edit.html
index 0fc2736..f45daab 100644
--- a/html/RTIR/Edit.html
+++ b/html/RTIR/Edit.html
@@ -136,7 +136,7 @@
 <td valign="top" width="50%">
 
 <&| /Widgets/TitleBox, title => loc('Dates'), class => 'ticket-info-dates'  &>
-<& /RTIR/Elements/EditDates, %ARGS, TicketObj => $Ticket &>
+<& /Ticket/Elements/EditDates, %ARGS, TicketObj => $Ticket &>
 </&>
 
 </td>
diff --git a/html/RTIR/Elements/EditDates b/html/RTIR/Elements/EditDates
deleted file mode 100644
index e41bc91..0000000
--- a/html/RTIR/Elements/EditDates
+++ /dev/null
@@ -1,103 +0,0 @@
-%# BEGIN BPS TAGGED BLOCK {{{
-%#
-%# COPYRIGHT:
-%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
-%#                                          <sales at bestpractical.com>
-%#
-%# (Except where explicitly superseded by other copyright notices)
-%#
-%#
-%# LICENSE:
-%#
-%# This work is made available to you under the terms of Version 2 of
-%# the GNU General Public License. A copy of that license should have
-%# been provided with this software, but in any event can be snarfed
-%# from www.gnu.org.
-%#
-%# This work is distributed in the hope that it will be useful, but
-%# WITHOUT ANY WARRANTY; without even the implied warranty of
-%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-%# General Public License for more details.
-%#
-%# You should have received a copy of the GNU General Public License
-%# along with this program; if not, write to the Free Software
-%# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-%# 02110-1301 or visit their web page on the internet at
-%# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
-%#
-%#
-%# CONTRIBUTION SUBMISSION POLICY:
-%#
-%# (The following paragraph is not intended to limit the rights granted
-%# to you to modify and distribute this software under the terms of
-%# the GNU General Public License and is only of importance to you if
-%# you choose to contribute your changes and enhancements to the
-%# community by submitting them to Best Practical Solutions, LLC.)
-%#
-%# By intentionally submitting any modifications, corrections or
-%# derivatives to this work, or any other work intended for use with
-%# Request Tracker, to Best Practical Solutions, LLC, you confirm that
-%# you are the copyright holder for those contributions and you grant
-%# Best Practical Solutions,  LLC a nonexclusive, worldwide, irrevocable,
-%# royalty-free, perpetual, license to use, copy, create derivative
-%# works based on those contributions, and sublicense and distribute
-%# those contributions and any derivatives thereof.
-%#
-%# END BPS TAGGED BLOCK }}}
-<table>
-  <tr>
-    <td class="label"><&|/l&>Starts</&>:</td>
-    <td class="value"><& /Elements/SelectDate,
-        menu_prefix => 'Starts',
-        Default     => $Starts_Date,
-        current     => 0,
-    &> (<% $TicketObj->StartsObj->AsString %>)
-    </td>
-  </tr>
-
-% if ($qname ne 'Incidents') {
-  <tr>
-    <td class="label"><&|/l&>Started</&>:</td>
-    <td class="value"><& /Elements/SelectDate,
-        menu_prefix => 'Started',
-        Default => $Started_Date,
-        current => 0,
-    &> (<% $TicketObj->StartedObj->AsString %>)
-    </td>
-  </tr>
-% }
-  <tr>
-    <td class="label"><&|/l&>Last Contact</&>:</td>
-    <td class="value"><& /Elements/SelectDate,
-        menu_prefix => 'Told',
-        Default => $Told_Date,
-        current => 0,
-    &> (<% $TicketObj->ToldObj->AsString %>)
-    </td>
-  </tr>
-% if ($qname ne 'Incidents') {
-  <tr>
-    <td class="label"><&|/l&>Due</&>:</td>
-    <td class="value"><& /Elements/SelectDate,
-        menu_prefix => 'Due',
-        Default => $Due_Date,
-        current => 0,
-    &> (<% $TicketObj->DueObj->AsString %>)
-    </td>
-  </tr>
-% }
-    </td>
-  </tr>
-</table>
-<%ARGS>
-$TicketObj => undef
-
-$Starts_Date  => ''
-$Told_Date    => ''
-$Started_Date => ''
-$Due_Date     => ''
-</%ARGS>
-<%INIT>
-my $qname = $TicketObj->QueueObj->Name;
-</%INIT>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list