[Rt-commit] rt branch, 4.2.5-releng, updated. rt-4.2.5rc1-16-g8f9afb8

Alex Vandiver alexmv at bestpractical.com
Thu Jun 5 20:29:07 EDT 2014


The branch, 4.2.5-releng has been updated
       via  8f9afb8106d478397ce0573051806806aed0028c (commit)
      from  03dfc5e4c67b867eb1dc5b9ade6def456e593eed (commit)

Summary of changes:
 lib/RT/ObjectCustomFieldValue.pm | 1 -
 1 file changed, 1 deletion(-)

- Log -----------------------------------------------------------------
commit 8f9afb8106d478397ce0573051806806aed0028c
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jun 5 19:55:49 2014 -0400

    Revert "Provide a better error message for loading OCFVs on an invalid CF"
    
    This reverts commit 404787322dffbf7faa13f43a3ad9ff0691ea6b55.
    
    The CF object may not be readable without context.

diff --git a/lib/RT/ObjectCustomFieldValue.pm b/lib/RT/ObjectCustomFieldValue.pm
index 110928c..d041953 100644
--- a/lib/RT/ObjectCustomFieldValue.pm
+++ b/lib/RT/ObjectCustomFieldValue.pm
@@ -140,7 +140,6 @@ sub LoadByCols {
     if ( $args{CustomField} ) {
         $cf = RT::CustomField->new( $self->CurrentUser );
         $cf->Load( $args{CustomField} );
-        return (0, $self->loc("Cannot load custom field [_1]",$args{CustomField})) unless $cf->id;
 
         my ($ok, $msg) = $cf->_CanonicalizeValue(\%args);
         return ($ok, $msg) unless $ok;

-----------------------------------------------------------------------


More information about the rt-commit mailing list