[Rt-commit] rt branch, 4.2/scripstage-queue-columnmap-i18n, repushed

Wallace Reis wreis at bestpractical.com
Mon Mar 3 16:09:37 EST 2014


The branch 4.2/scripstage-queue-columnmap-i18n was deleted and repushed:
       was 8e07ffed3b9e76bea2fe66588c1f5316b9c9dc86
       now 9d3e5a03f778a3754569c9c708f2f76c6e275313

1:  8e07ffe ! 1:  9d3e5a0 I#28739: ScripStage leaks internal value
    @@ -96,13 +96,11 @@
          $Default = 'TransactionCreate';
      }
     -my @stages = ['TransactionCreate', loc('Normal')];
    -+my @stages = 'TransactionCreate';
    - 
    - push @stages, RT->Config->Get('UseTransactionBatch')
    +-
    +-push @stages, RT->Config->Get('UseTransactionBatch')
     -            ? ['TransactionBatch', loc('Batch')]
     -            : ['TransactionBatch', loc('Batch (disabled by config)')];
    -+            ? 'UseTransactionBatch'
    -+            : 'TransactionBatch';
    ++my @stages = ('TransactionCreate', 'TransactionBatch');
      </%INIT>
      <%ARGS>
      $Default => 'TransactionCreate'
    @@ -118,7 +116,7 @@
                  my $os = RT::ObjectScrip->new( $_[0]->CurrentUser );
                  $os->LoadByCols( Scrip => $_[-1], ObjectId => $_[0]->id );
     -            return $os->Stage;
    -+	    return $_[0]->loc( $os->FriendlyStage );
    ++            return $_[0]->loc( $os->FriendlyStage );
              },
          },
      };
    @@ -135,7 +133,7 @@
     +        value => sub {
     +            my $os = RT::ObjectScrip->new( $_[0]->CurrentUser );
     +            $os->LoadByCols( Scrip => $_[-1], ObjectId => $_[0]->id );
    -+	    return $_[0]->loc( $os->FriendlyStage );
    ++            return $_[0]->loc( $os->FriendlyStage );
     +        },
     +    },
      };



More information about the rt-commit mailing list